Bug 148848 - Make "Auto Spellcheck" a module-level or document-level option
Summary: Make "Auto Spellcheck" a module-level or document-level option
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Spell-Checking
  Show dependency treegraph
 
Reported: 2022-04-29 12:05 UTC by Rafael Lima
Modified: 2023-07-11 05:34 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Lima 2022-04-29 12:05:17 UTC
Currently it seems that the Auto Spellcheck option is saved at the LibreOffice level globally. For instance:

1) Open Writer and enable Auto Spellcheck
2) Close Writer
3) Open Calc and notice that Auto Spellcheck is enabled
4) Close Calc
5) Open Writer again and disable Auto Spellcheck
6) Close Writer
7) Open Calc and notice that now Auto Spellcheck is now disabled

So enabling and disabling Auto Spellcheck in Writer will affect the option state in Calc. This causes a few problems: for example, in Writer it is common to leave Auto Spellcheck ON because the user is writing complete sentences. However in Calc it is common to leave this option OFF, since the user won't be typing full sentences (or even full words).

Because I alternate between Writer and Calc very often, I find myself having the following problem:
1) I open Writer to review a text document and enable Auto Spellcheck
2) Then I close Writer and some time later I open Calc
3) Now Auto Spellcheck is enabled in Calc, so I have to manually disable it
4) Then I close Calc and later I open Writer again to review another text document
5) Now Auto Spellcheck is off because I disabled it in Calc; so I have to manually enable it again
6) And this cycle goes on ...

To solve this issue, I think we should save the Auto Spellcheck state either at the module level (so that Writer, Calc, Impress and Draw remember their states and do not affect each other). Or we could save the Auto Spellcheck state to the document itself, which would be an interesting approach as well.

System info:
Version: 7.3.2.2 / LibreOffice Community
Build ID: 30(Build:2)
CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Ubuntu package version: 1:7.3.2~rc2-0ubuntu0.21.10.1~lo1
Calc: threaded
Comment 1 Eyal Rozenberg 2022-05-03 17:54:33 UTC
Confirmed the behavior with:

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: d9b33ed6644203141fdb0776c291425c2bc9f5ac
CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: en-IL (en_IL); UI: en-US


Now, as for the suggestion:

* Module-level - I'm definitely in favor of this as a user.

* Document-level... I'm not sure. Let someone who uses the spellchecker more make the argument for it.
Comment 2 V Stuart Foote 2022-05-03 19:21:29 UTC
+1 to function at the module level, i.e. enabled in Writer but disabled in Calc

Doing it per-document *across modules* would be a nuisance to use and no improvement over current state of things.
Comment 3 Rafael Lima 2022-05-03 20:06:51 UTC
(In reply to V Stuart Foote from comment #2)
> +1 to function at the module level, i.e. enabled in Writer but disabled in
> Calc
> 
> Doing it per-document *across modules* would be a nuisance to use and no
> improvement over current state of things.

I agree with you... I think having this option set at the module level would be the best way to go.

Setting it at the document level might annoy some users.
Comment 4 Cor Nouws 2022-05-05 11:48:12 UTC
I appreciate this idea.
Comment 5 Heiko Tietze 2022-05-05 14:00:47 UTC
The topic was on the agenda of the design meeting and was unanimously accepted.
Comment 6 Heiko Tietze 2022-05-05 14:09:25 UTC
Caolan at ESC: "thought it already works like this". Haven't checked the issue myself, Eyal you confirmed by testing?
Comment 7 Cor Nouws 2022-05-10 07:45:04 UTC
(In reply to Heiko Tietze from comment #6)
> Caolan at ESC: "thought it already works like this". Haven't checked the
> issue myself, Eyal you confirmed by testing?

indeed - my bad. Double checked now. WFM.
Comment 8 Rafael Lima 2022-05-10 12:55:10 UTC
(In reply to Cor Nouws from comment #7)
> indeed - my bad. Double checked now. WFM.

Hi Cor, was there a patch fixing the issue? It was set as FIXED without referencing a patch. Based on what you said, it should have been set as WORKSFORME.

I still can reproduce the bug on my machine, so WFM doesn't seem to fit here. To reproduce the bug, run the following steps:

1) Open Writer and take note of the status of the "Auto Spellcheck" (f.i. suppose it is now enabled)
2) Do not change anything. Simply close Writer and all other LO applications.
3) Now open Calc... notice that the "Auto Spellcheck" status will be the same as in Writer (in this example, it is enabled)
4) Do not change anything. Simply close Calc (and all other LO application, if any is open)
5) Now open Writer and change the status of "Auto Spellcheck" (in this example, set it to disabled)
6) Now close Writer (and all other LO application, if any is open)
7) Open Calc and notice that the "Auto Spellcheck" has now changed to the same status that was set in Writer (in this example, it will be disabled now)
Comment 9 Cor Nouws 2022-05-11 09:08:15 UTC
Hi Rafael,

(In reply to Rafael Lima from comment #8)
> (In reply to Cor Nouws from comment #7)
> > indeed - my bad. Double checked now. WFM.
> 
> Hi Cor, was there a patch fixing the issue? It was set as FIXED without
> referencing a patch. Based on what you said, it should have been set as
> WORKSFORME.

Yes, correct.
 
> I still can reproduce the bug on my machine, so WFM doesn't seem to fit
> here. To reproduce the bug, run the following steps:
> ..

I tried that scenario.
Could it be, seeing your report, that it is because you use the Ubuntu packages?
(Ubuntu package version: 1:7.3.2~rc2-0ubuntu0.21.10.1~lo1)
Comment 10 Rafael Lima 2022-05-11 11:02:08 UTC
(In reply to Cor Nouws from comment #9)
> Could it be, seeing your report, that it is because you use the Ubuntu
> packages?
> (Ubuntu package version: 1:7.3.2~rc2-0ubuntu0.21.10.1~lo1)

Hi Cor. I don't think so. I also tested the steps from Comment #8 using LO 7.4 alpha built from source and the bug is still reproducible.

System info:
Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 4351a6ca782e1d2081ba819338ebbf6a2d2ee2b2
CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: CL
Comment 11 Buovjaga 2023-07-11 05:34:26 UTC
I reproduce Rafael's original description on Windows

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 81726f5af5fda25f0d92ffc8458d7f24eb16f408
CPU threads: 2; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: en-US (en_FI); UI: en-US
Calc: threaded