Bug 148908 - RTF paste only pastes content up to ToC from attached ODT
Summary: RTF paste only pastes content up to ToC from attached ODT
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.2.3.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: RTF-Paste
  Show dependency treegraph
 
Reported: 2022-05-03 09:41 UTC by Telesto
Modified: 2024-03-03 05:09 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2022-05-03 09:41:09 UTC
Description:
Crash on RTF paste: Writerfilterlo!writerfilter::dmapper::ConversionHelper::convertTwipToMM100Unsigned+0x17370:

Steps to Reproduce:
1. Open attachment 164591 [details] (bug 135911)
2. Discard the update links
3. CTRL+A
3. CTRL+C
4. CTRL+N
5. CTRL+SHIFT+V
6. Select RTF paste

Actual Results:
Crash

Expected Results:
No crash


Reproducible: Always


User Profile Reset: No



Additional Info:
Found in
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 4659fc2f0a7223a89446edff0b77e58758b5edf5
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: en-US (nl_NL); UI: en-GB
Calc: CL

No crash with
Version: 7.0.7.0.0+ (x64)
Build ID: 626ea4e62a3e5005fe9825923a1c0c5bdb61cc08
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Xisco Faulí 2022-05-03 10:13:01 UTC
Reproduced in

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 75fe4051320ef9b1f4323fa958e8df3db2066882
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded
Comment 2 Xisco Faulí 2022-05-03 10:25:02 UTC
In

Version: 7.2.0.0.alpha1+ / LibreOffice Community
Build ID: ff2ba77f22b2e96f96f5537aec1705956b47583d
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded

it hangs after pasting as RTF
Comment 3 Xisco Faulí 2022-05-03 10:27:13 UTC
(In reply to Xisco Faulí from comment #2)
> In
> 
> Version: 7.2.0.0.alpha1+ / LibreOffice Community
> Build ID: ff2ba77f22b2e96f96f5537aec1705956b47583d
> CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
> Locale: es-ES (es_ES.UTF-8); UI: en-US
> Calc: threaded
> 
> it hangs after pasting as RTF

Not reproduced in

Version: 7.1.0.0.alpha1+
Build ID: 738bcf5e9a8c443d60c29c3a8068e8c16c72638a
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded
Comment 4 Kira Tubo 2023-09-15 19:51:32 UTC
No longer reproducible in current stable and daily master builds. Closing ticket as RESOLVED - WORKSFORME. 

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 9a37652b79001bf5208841b9221dee851b9b6d0f
CPU threads: 6; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

Version: 7.6.1.2 (X86_64) / LibreOffice Community
Build ID: f5defcebd022c5bc36bbb79be232cb6926d8f674
CPU threads: 6; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded
Comment 5 Telesto 2023-09-15 20:14:44 UTC
Still crashing for me
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: be9d7bee88eff89c0d361f23abb447ac2086c3b4
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL threaded
Comment 6 BogdanB 2023-11-21 20:08:27 UTC
Crash in 7.4 (oldest)
Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 10981fb2fa26474f432e85165b1babbca6d74e16
CPU threads: 16; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded

Crash in 7.5 (oldest)
Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: b419eb4bd407c26ee813a347fdf14424908379e1
CPU threads: 16; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded

Don't crash in 24.2. (oldest)
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 590408329ee47496c813709a1bcc8cd35f6ebbb1
CPU threads: 16; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded

Seems solved for me in master.
Comment 7 BogdanB 2023-12-06 14:14:25 UTC
Working well also in
Version: 7.6.3.1 (X86_64) / LibreOffice Community
Build ID: c4af5b1259bceea6e979e6fe2435dbee7a5a87c2
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: ro-RO (en_US); UI: en-US
Calc: threaded

Working well also with Force Skia Software rendering enabled
Version: 7.6.3.1 (X86_64) / LibreOffice Community
Build ID: c4af5b1259bceea6e979e6fe2435dbee7a5a87c2
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: ro-RO (en_US); UI: en-US
Calc: threaded
Comment 8 Telesto 2023-12-06 15:02:45 UTC
My observations at this point with macOS

* Crash pasting normally
* No crash when pasting RTF, but only 4 pages are pasted


Version: 24.2.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 1a74a87b442857567d20da5dc97bbbc278745afd
CPU threads: 8; OS: macOS 13.4.1; UI render: default; VCL: osx
Locale: nl-NL (nl_NL.UTF-8); UI: en-US
Calc: threaded
Comment 9 BogdanB 2023-12-06 15:32:46 UTC
Crash with simple paste, instead of paste as RTF.
And just 4 pages. Also on
Version: 24.2.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: bc95ece0618b9886890d9c758b9d0ebc0fc41c69
CPU threads: 16; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 10 Tex2002ans 2024-03-03 02:48:28 UTC
CRASH:

- https://crashreport.libreoffice.org/stats/crash_details/7dd02c2e-a839-4652-a8c1-0d5e033f58c9

in:

Version: 24.2.1.2 (X86_64) / LibreOffice Community
Build ID: db4def46b0453cc22e2d0305797cf981b68ef5ac
CPU threads: 8; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

By doing a "simple Ctrl+V paste" like BogdanB said in comment 9.

- - -

So to get CRASH, I mostly did comment 0, but substituted step 5:

1. Open attachment 164591 [details] (bug 135911)
2. Discard the update links
3. CTRL+A
3. CTRL+C
4. CTRL+N
5. Ctrl+V

LibreOffice chugged away for a little while, I was able to see/move around the document, but it ultimately crashed about 20 seconds later.

- - -

Following comment 0 exactly and:

- I DID NOT get a crash.

but RTF paste did miss lots of text, because it:

- Only pasted in 4 pages / 204 words.
   - vs. 164 pages / 68,362 words in original.
Comment 11 Aron Budea 2024-03-03 05:08:59 UTC
Let's keep this bug report focused on the RTF paste, and open a new one on any issue concerning regular paste.

The crash during RTF paste got introduced by the 7.2 backport of the following commit in 7.3, bibisected using bibisect-linux-64-7.2. Before that the RTF paste was hanging, or was just taking a very long time, I haven't waited for it to finish.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=05f92eb1359c399c43d3bcbe8942034408fa23eb
author		László Németh <nemeth@numbertext.org>	2021-10-01 17:42:48 +0200
committer	László Németh <nemeth@numbertext.org>	2021-10-04 08:22:23 +0200

"tdf#77051 DOCX: fix user index and index entry support"

The crash is fixed since the following commit's 7.4 backport, reverse bibisected using repo bibisect-linux-64-7.4. However, content is only pasted up to ToC, and not further.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=5431b756d45bebe74beaba2026704552ee6891f0
author		Jaume Pujantell <jaume.pujantell@collabora.com>	2023-04-27 14:54:55 +0200
committer	Ashod Nakashian <ash@collabora.com>	2023-05-03 12:42:31 +0200

"tdf#154478 fix comments empy after ToC"