Bug 148951 - (F1) on Fill Format Mode in Styles Sidebar goes to General Writer Help, instead of relevant page (win, gen, kf5, qt5 VCLs)
Summary: (F1) on Fill Format Mode in Styles Sidebar goes to General Writer Help, inste...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Documentation (show other bugs)
Version:
(earliest affected)
7.3.7.2 release
Hardware: All All
: medium normal
Assignee: Olivier Hallot
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Sidebar-Styles Help-Link
  Show dependency treegraph
 
Reported: 2022-05-05 12:07 UTC by sdc.blanco
Modified: 2023-07-20 12:00 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2022-05-05 12:07:49 UTC
Open Styles sidebar (F11)
Select Fill Format Mode (paintcan at top)
Press F1

Actual: https://help.libreoffice.org/7.4/en-US/text/swriter/main0000.html
Expected: https://help.libreoffice.org/7.4/en-US/text/swriter/guide/stylist_fillformat.html
Comment 1 Stéphane Guillou (stragu) 2023-07-19 15:06:43 UTC
For me, it works when focusing the sidebar deck with F11, then pressing tab once to highlight the button, then pressing F1: I get to https://help.libreoffice.org/7.4/en-US/text/simpress/01/05100000.html?System=UNIX&DbPAR=WRITER&HID=SFX2_HID_TEMPLDLG_WATERCAN#bm_id3152896 with:

Version: 7.4.7.2 / LibreOffice Community
Build ID: 723314e595e8007d3cf785c16538505a1c878ca5
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

However, once I click anywhere else on this deck and the button highlight is lost, then press F1, I get to either a 404 page or the generic Writer help page.

Same in 24.2.

Seth, can you confirm that highlighting the button+F1 does lead to the right help page, but clicking it + F1 doesn't?

For me, looks like it's the norm that clicking a button then pressing F1 leads to the generic help - unless clicking a button opens a dialog. (Tried gen and gtk3 VCLs.)
Comment 2 sdc.blanco 2023-07-19 16:53:26 UTC
(In reply to Stéphane Guillou (stragu) from comment #1)
> Seth, can you confirm that highlighting the button+F1 does lead to the right
> help page, but clicking it + F1 doesn't?

(not sure what action corresponds to "highlighting" vs. "clicking")

But -- with 7.2.7.2 (and offline help installed)

1.  F11
2.  Hover (or click(mouse) over paintcan (Fill format)
3.  F1

Actual: relevant (offline) help page is shown.

Version: 7.2.7.2 (x64) / LibreOffice Community
Build ID: 8d71d29d553c0f7dcbfa38fbfda25ee34cce99a2
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: da-DK (da_DK); UI: en-US
Calc: CL

with 24.2

1. Open new document, F11
2. Tab  (which highlights the paintcan)
3. F1

Actual:  404 error  Help ID: sfx/ui/templatepanel/right

1. New document, F11
2. Click on paintcan
3. F1

Actual: 404 error  Help ID: SFX2_HID_TEMPLDLG_TOOLBOX_LEFT

1. New document, F11
2. Tab (to paint) F1. result:  sfx/ui/templatepanel/right
3. Click on paintcan F1  result:  sfx/ui/templatepanel/right  (notice difference to previous case).

1. New document, click on any of the modules on the right vertical edge.
2. F1 Result: generic help page.
3. Select Styles deck, click on any of the style options in top panel, F1. Result: Help ID: SFX2_HID_TEMPLDLG_TOOLBOX_LEFT
4.  click paintcan, F1.  Result: Help ID: SFX2_HID_TEMPLDLG_TOOLBOX_LEFT

If I press Tab, then sometimes I can different Help IDs
Help ID: .uno:PickList
Help ID: sfx/ui/templatepanel/showpreview

but hard to see what is selected, or what Tab is doing in this situation.

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 693411e60c6bbd1c2ef25490cc3902f6b2461682
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: da-DK (da_DK); UI: en-US
Calc: CL threaded
Comment 3 Stéphane Guillou (stragu) 2023-07-20 10:31:04 UTC
(In reply to sdc.blanco from comment #2)
> (not sure what action corresponds to "highlighting" vs. "clicking")

For me, navigating with the keyboard (Tab and arrows) will highlight the button (on Ubuntu + GNOME and gtk3 VCL it's a coloured frame around the button), whereas clicking will execute the command but won't highlight the button.

For example:
- F11 > click Fill Format Mode: Fill Format Mode is depressed but the highlight frame is still on the Paragraph Styles button.

Testing again _with gtk3 VCL_, using only the tab navigation to reach the Fill Format Mode button, F1 leads me to the right help page, in both 7.2 and 24.2, so I can't confirm the issue with gtk3 VCL.
Clicking, pressing enter, or hovering will always lead to the same result: F1 leads to whatever button is highlighted.

However, with gen VCL, I can confirm that F1 with the button highlighted leads to a 404 page with HID sfx/ui/templatepanel/right
With kf5 and qt5 VCLs, the button highlight is not visible, but I get the same 404 + HID when using the same keyboard sequence.

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 46d7119b8be03968017e59d882e5671350304e15
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: x11
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Same issue with gen VCL in 7.3:

Version: 7.3.7.2 / LibreOffice Community
Build ID: e114eadc50a9ff8d8c8a0567d6da8f454beeb84f
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: x11
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

In 7.2 + gen VCL, I could not focus the deck's toolbar with the keyboard.

So, in conclusion, I can confirm getting a 404 when Fill Format Mode is highlighted with all VCLs except gtk3.

(By the way: while testing, I reported bug 156397 for erroneous help bookmarks for Paragraph Styles and List Styles)
Comment 4 sdc.blanco 2023-07-20 12:00:07 UTC
Adding CC to Stuart and Jim in case they have some wisdom about navigating and help ids in the styles deck. While this ticket is currently classified as a documentation problem, maybe there are also navigation issues or limitations in the use of help ids in the UI itself (possibly related to bug 156376 or an issue similar to the issue that might underlie bug 147911).