Bug 149001 - Top border is too wide on the "rest-of-the-toolbar" popup
Summary: Top border is too wide on the "rest-of-the-toolbar" popup
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
(earliest affected) release
Hardware: All Windows (All)
: lowest trivial
Assignee: Not Assigned
Keywords: implementationError
Depends on:
Blocks: Toolbars-Overflow
  Show dependency treegraph
Reported: 2022-05-09 11:49 UTC by Mike Kaganski
Modified: 2023-04-06 16:13 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:

Screenshot (42.54 KB, image/png)
2022-05-09 11:49 UTC, Mike Kaganski
Screenshot detail (3.34 KB, image/png)
2022-05-09 18:32 UTC, LeroyG
Another screenshot detail (2.61 KB, image/png)
2022-05-09 18:35 UTC, LeroyG

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2022-05-09 11:49:57 UTC
Created attachment 180014 [details]

Version: (x64) / LibreOffice Community
Build ID: 0c87c0b87a3bbc2c57b2dd65ba2dd0aeb2f0b0c3
CPU threads: 12; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: CL

Make the document window narrow enough that toolbars don't fit into the width; then click on the [>>] button that allows to see the rest of the toolbar's buttons (see the screenshot)

The popup panel has 2-pixel top border (the rest have 1-pixel) on Windows 10; it starts a bit too high, so that the [>>] button itself covers 1-pixel part of the border.

"Regression" after commit 81d4fbc0daa54889ccb09e6a3fadff9c70d99448
  Author Maxim Monastirsky <momonasmon@gmail.com>
  Date   Sun Feb 12 22:14:48 2017 +0200
    tdf#42029 Use a floating toolbar to show clipped items

Or rather, a small implementation error.
Comment 1 LeroyG 2022-05-09 18:32:18 UTC
Created attachment 180023 [details]
Screenshot detail

I can see a two pixel border in four sides, but do not know why is lighter at the top left border. Maybe the Windows of the original post use same colors.

Version: (x86) / LibreOffice Community
Build ID: e1f30c802c3269a1d052614453f260e49458c82c
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win
Locale: es-MX (es_MX); UI: en-US
Calc: threaded
Comment 2 LeroyG 2022-05-09 18:35:14 UTC
Created attachment 180024 [details]
Another screenshot detail

This time the lighter color is at the top right border. I deduce that it is shown at the >> button nearer side.

Maybe, not a bug.
Comment 3 Maxim Monastirsky 2022-05-12 00:12:47 UTC
No idea why the top border in that screenshot is wider, and can't remember seeing anything like this before. However it's expected for the top border to not be drawn underneath the button, so that the button and the popup look like a single continuous area. This was introduced for subtoolbar popups back in OOo for i#32185, and later expanded to other popups in Go-oo's toolbar-decorations-vcl.diff. The problem here is that the ">>" button doesn't show the pressed state when clicked, which is why it looks worse.