Bug 149010 - "Previous Link" and "Next Link" should only appear on Frames Options tab
Summary: "Previous Link" and "Next Link" should only appear on Frames Options tab
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Heiko Tietze
URL:
Whiteboard: target:7.4.0
Keywords:
Depends on:
Blocks: Object-Properties-Dialog Image-Dialog
  Show dependency treegraph
 
Reported: 2022-05-09 21:43 UTC by sdc.blanco
Modified: 2022-06-08 18:36 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2022-05-09 21:43:14 UTC
According to https://help.libreoffice.org/7.4/en-US/text/swriter/01/05060900.html:

Previous link

Displays the item (object, graphic, or frame) that comes before the current item in a linked sequence. To add or change the previous link, select a name from the list. If you are linking frames, the current frame and the target frame must be empty.

Next link

Displays the item (object, graphic, or frame) that comes after the current item in a linked sequence. To add or change the next link, select a name from the list. If you are a linking frames, the target frame must be empty.

Question 1:  afaict, it is only possible to link/display frames using these controls.  Which is at fault, the help description or the behavior of LO?

Question 2:  If only frames can be linked, then the "Previous Link" and "Next Link" should not appear at all when selected OLE Objects and Images are using the Options tab (this question might need to be filed as a separate ticket).
Comment 1 Regina Henschel 2022-05-10 13:07:55 UTC
(In reply to sdc.blanco from comment #0)

> Question 1:  afaict, it is only possible to link/display frames using these
> controls.  Which is at fault, the help description or the behavior of LO?

The draw:chain-next-name attribute is only usable with <draw:text-box> elements. That is currently only implemented for Frames in Writer. It would be possible for the shape "Text box" too, but that is not implemented. But you are right, it is not possible for images or OLE objects or media. 

> 
> Question 2:  If only frames can be linked, then the "Previous Link" and
> "Next Link" should not appear at all when selected OLE Objects and Images
> are using the Options tab (this question might need to be filed as a
> separate ticket).

I think, they should be hidden when not applicable.
Comment 2 sdc.blanco 2022-05-10 13:27:26 UTC
(In reply to Regina Henschel from comment #1)
> draw:chain-next-name attribute is ... only implemented for Frames in Writer. 
> would be possible for the shape "Text box" too, but ... not implemented. 
> not possible for images or OLE objects or media.
==> Help page must be revised -- to specify Frames only.
==> NeedsUXEval about whether to implement for "Text box" (no opinion from OP)


> > Question 2:  If only frames can be linked, then the "Previous Link" and
> > "Next Link" should not appear at all when selected OLE Objects and Images
==> NeedsUXEval 

And given that these controls can only be used with Frames, but not with Images or OLE Objects, then they should only be shown in the Frames Option dialog, but not the Image or Object  Option dialog ( code pointer: sw/source/ui/frmdlg/frmpage.cxx )

Changing bug summary...
Comment 3 sdc.blanco 2022-05-11 14:41:12 UTC
Additional UXEval question --

Can the heading be improved for the section where Previous Link and Next Link appear? 

"Names" is neither informative nor accurate -- but have not been able to formulate a good alternative.

If "Previous Link" and "Next Link" will only appear with Frames, then Image and Object will only have Name, Text Alternative, and Description.  I tried, without success, to find a label that would refer primarily to those functions.
Comment 4 Heiko Tietze 2022-05-12 09:39:26 UTC
(In reply to sdc.blanco from comment #2)
> ==> NeedsUXEval about whether to implement for "Text box"

My take: keep text boxes simple. Will bring this to the attention of the ESC.

(In reply to Regina Henschel from comment #1)
> I think, they should be hidden when not applicable.

(In reply to sdc.blanco from comment #2)
> > > Question 2:  If only frames can be linked, then the "Previous Link" and
> > > "Next Link" should not appear at all when selected OLE Objects and Images

Yes, rather hide in this case than disable.

(In reply to sdc.blanco from comment #3)
> Can the heading be improved for the section where Previous Link and Next
> Link appear? 

We could separate these two controls from the Names frame and have an extra Sequence frame.
Comment 5 sdc.blanco 2022-05-12 10:50:51 UTC
(In reply to Heiko Tietze from comment #4)
> could separate these two controls from the Names frame and have an extra
> Sequence frame.
+1

But original question remains....the current dialog appears as follows 

Names
  Name
  Text Alternative
  Description


-- where the "main" content is more about accessibility (or if "Description" is not going to be exported, then "documentation").  

otoh, section label is not a big deal. On the other, many Eve users want the UI to be "intuitive"/"transparent" without having to read documentation -- perhaps a better descriptor than "Names" can be found. (maybe "Object Description"? )
Comment 6 Heiko Tietze 2022-05-12 11:33:36 UTC
(In reply to sdc.blanco from comment #5)
> But original question remains... where the "main" content is more about accessibility 

Description is exported in case of PDF. Accessibility sounds good to me, even considering Name to be relevant on the Navigator.
Comment 7 Heiko Tietze 2022-05-12 14:20:37 UTC
There was a GSoC project to enabled chaining for text boxes.

http://gsoc15-draw.logdown.com/posts/276831-text-chaining-in-draw-an-attempt-to-specifications
http://gsoc15-draw.logdown.com/posts/283339-text-chaining-in-draw-results-at-midterm
https://matteocam.github.io/output/announcing-chained-text-in-draw-a-prototype-implementation.html

But the next/previous link entries are shown for other objects as well, like images, that clearly need these entries to be disabled. So we have to do it anyway.

=> disable controls conditionally, rename the "Names" section to "Accessibiliy" and put "Next/Previous" into an extra frame labeled "Sequences" (sounds more user-friendly to me than Chain).
Comment 8 sdc.blanco 2022-05-12 14:28:32 UTC Comment hidden (off-topic)
Comment 9 Heiko Tietze 2022-05-12 14:30:46 UTC Comment hidden (off-topic)
Comment 10 sdc.blanco 2022-05-12 16:40:17 UTC Comment hidden (off-topic)
Comment 11 Regina Henschel 2022-05-12 17:19:56 UTC
There is a deeper problem with the section "Names": The field "Name" belongs to attribute "draw:name" and is not related to accessibility, but is used for navigation and links. The real accessibility field is "svg:title" and that is missing here. You can only set it via Format > Description. Having a section "Accessibility" is fine, but then it needs to contain both "svg:title" and "svg:desc" and should not contain "draw:name". There could then be an additional section "Name" for the "draw:name" attribute.
Comment 12 sdc.blanco 2022-05-12 18:14:44 UTC
(In reply to Regina Henschel from comment #11)
> field "Name" belongs to attribute "draw:name" ... used for navigation and links.
Understood.  Comment 6 was acknowledging that idea -- but was also suggesting (at least as I interpreted the comment) that "name" could be understood to be making the object more accessible to the document producer (in the navigation sense).

I suggested "Object Description" (as more neutral, and covering both the navigation and a11y functions).  Good arguments for either label, so no strong opinion from me.  And no opinion about whether to make separate sections for "Name" and "Accessibility"  (My interest is only to get a stable layout and labelling for the Options dialog tab so I can finish updating the help page, bug 149012)

> The real accessibility field is "svg:title" and that is missing here. 
Maybe you were testing/checking with a frame?  There it is missing. (no ticket filed for that)

But svg:title is found in the Properties - Option tab dialog for Image and Object (as "Alternative (Text only)") and from this afternoon in master as ("Text Alternative" - bug 148941)
Comment 13 sdc.blanco 2022-05-13 22:01:21 UTC
Not to preempt the discussion of the section name (and what controls should be included under a particular section name), but here is a patch to change "Names" to "Accessibility" -- if that is the way to go. 

https://gerrit.libreoffice.org/c/core/+/134182
Comment 14 Commit Notification 2022-05-14 12:11:20 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6c5542a82135b3527f883110d45a935661985d30

Partially resolve: tdf#149010 rename section "Names" -> "Accessibility"

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 15 sdc.blanco 2022-05-25 10:21:14 UTC
(In reply to Heiko Tietze from comment #4)
> (In reply to sdc.blanco from comment #2)
> > > > Question 2:  If only frames can be linked, then the "Previous Link" and
> > > > "Next Link" should not appear at all when selected OLE Objects and Images
> 
> Yes, rather hide in this case than disable.
@Heiko -- as you are hiding controls today -- maybe you could take this one as well, then we could close this ticket....unless...you also want to do the following....

> (In reply to sdc.blanco from comment #3)
> > Can the heading be improved for the section where Previous Link and Next
> > Link appear? 
> 
> We could separate these two controls from the Names frame and have an extra
> Sequence frame.
Comment 16 Commit Notification 2022-05-29 07:23:35 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/2df65a1ff7072dc0ec866f5dfe11846c15208199

tdf#149010,tdf#148941,tdf#149012,tdf#149130 update to reflect changes
Comment 17 sdc.blanco 2022-05-30 22:02:32 UTC
The extended tooltips for "Previous  Link" and "Next Link" were taken from the help page, which incorrectly described these options as applying to images, objects, and frames. The following patch corrects the extended tooltips and adds short tooltips as well.

https://gerrit.libreoffice.org/c/core/+/135071
Comment 18 Commit Notification 2022-06-01 09:53:30 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5ea5151467b2fb3d9487a178ef6d47436d4154d6

tdf#149010 add and improve tooltips to "Previous Link" and "Next Link"

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 19 sdc.blanco 2022-06-01 10:04:51 UTC
Current status on what remains to be done.

1. "Previous Link" and "Next Link" should:

   (a) only appear in the Options tab in the Frame Properties dialog. 
   (b) not appear in the Options tab for the Image and OLE  Object properties dialog. (comment 1)

2.  put "Next/Previous" into an extra frame labeled "Sequences"  (comment 7)

maybe EasyHack?
Comment 20 Heiko Tietze 2022-06-08 12:11:44 UTC
Patch at https://gerrit.libreoffice.org/c/core/+/135494
Comment 21 Commit Notification 2022-06-08 18:36:26 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/755e0cd60d4634111911469b752485da678988e1

Resolves tdf#149010 - MInor UI fixes

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.