Bug 149206 - FILEOPEN: EMF/WMF: Image displayed incorrectly
Summary: FILEOPEN: EMF/WMF: Image displayed incorrectly
Status: CLOSED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: graphics stack (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.4.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks: EMF-WMF PPTX
  Show dependency treegraph
 
Reported: 2022-05-20 14:57 UTC by Xisco Faulí
Modified: 2024-04-11 23:08 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Comparison LibreOffice 7.4 master and PP 2016 (335.47 KB, image/png)
2022-05-20 14:57 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2022-05-20 14:57:50 UTC
Created attachment 180258 [details]
Comparison LibreOffice 7.4 master and PP 2016

Steps to reproduce:
1. Open attachment 158365 [details] from bug 131109

-> The image has incorrect height. See comparison

Reproduced in

Version: 7.4.0.0.alpha1+ / LibreOffice Community
Build ID: 22d7cbc0f0c50c59abca7ab5f7db46e4d0e5f86a
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded

[Bug found by office-interoperability-tools]
Comment 1 Xisco Faulí 2022-05-20 14:58:56 UTC
Regression introduced by:

author	offtkp <parisoplop@gmail.com>	2022-04-02 15:49:32 +0300
committer	Tomaž Vajngerl <quikee@gmail.com>	2022-05-06 04:02:05 +0200
commit e9c50fbbc3b07ef927d133da9cf2395c55611e0f (patch)
tree 7b2dbf92184b5b2707685dc44ee4764d4d58fdad
parent e4a7a50d831cb6fca95f2afff2af5298d66b5876 (diff)
tdf#103954: Z compressed graphic formats support for EMF/WMF

Bisected with: bibisect-linux64-7.4

Adding Cc: to offtkp
Comment 2 Paris Oplopoios 2022-05-20 19:03:49 UTC
Reproduced, I'll look into this
Comment 3 Tomaz Vajngerl 2022-05-21 11:35:21 UTC
The problem is probably the code removed in GraphicDescriptor::ImpDetectEMF as that one reads the size from the metadata and sets it..
Comment 4 Commit Notification 2022-05-24 06:20:01 UTC
offtkp committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/063d641f023ac90f49116de105e32e38be72a1af

tdf#149206 Set size correctly when loading EMF

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2022-05-24 06:21:10 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/504d61697bac45236da27fba23c7189daf8c171e

tdf#149206: sd_import_tests2: Add unittest

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2022-05-24 06:21:19 UTC
offtkp committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5f30b778bccbcc417e4ed1da5997650babb942a8

tdf#149206: Add EMF test in GraphicDescriptorTest

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Xisco Faulí 2022-05-27 08:46:14 UTC
Verified in

Version: 7.4.0.0.alpha1+ / LibreOffice Community
Build ID: a8df5c815c8b002b7083b8777e3dd8beac573bf3
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded

@Paris, thanks for fixing this issue!!