Bug 149341 - When clicking an Insert-shape button, focus is wrong
Summary: When clicking an Insert-shape button, focus is wrong
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Sidebar
  Show dependency treegraph
 
Reported: 2022-05-28 10:18 UTC by Eyal Rozenberg
Modified: 2022-06-16 09:22 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Video showing the described workflow (44.39 KB, video/mp4)
2022-05-28 13:48 UTC, Rafael Lima
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eyal Rozenberg 2022-05-28 10:18:41 UTC
When clicking an Insert-shape button, the currently-selected shape should lose focus, as we will now be drawing the shape.

However, this is not what happens. What does happen is that the current shape remains in focus; and if you were typing in it, you go out of "typing mode" back to selection of the whole shape, which is distracting..
Comment 1 Rafael Lima 2022-05-28 13:48:18 UTC
Created attachment 180442 [details]
Video showing the described workflow

(In reply to Eyal Rozenberg from comment #0)
> However, this is not what happens. What does happen is that the current
> shape remains in focus; and if you were typing in it, you go out of "typing
> mode" back to selection of the whole shape, which is distracting..

Hi Eyal, I attached a video showing the workflow you described. So, after inserting the first shape and entering text, when I click the shape tool to insert the second shape you would like that nothing was selected?

The current implementation seems natural to me. What would be the advantage of having nothing selected?

IMO there are two things that could be improved in this workflow:
1) When the user finishes drawing the shape, the shape tool should no longer be selected in the sidebar, since the command is no longer enabled (you can't immediately draw a second shape)
2) If you click a shape tool and give up drawing the shape, it should be possible to press Esc and return to selection mode.
Comment 2 Eyal Rozenberg 2022-05-28 14:24:25 UTC
(In reply to Rafael Lima from comment #1)
> Hi Eyal, I attached a video showing the workflow you described. So, after
> inserting the first shape and entering text, when I click the shape tool to
> insert the second shape you would like that nothing was selected?

Yes, I expect a de-selection. Note that, in your example, your new text box did not intersect the existing box. It would be more distracting if you intended for the boxes to intersect; and even more distracting if the contour took up more of the shape's area on screen, e.g. a star shape for example.

> The current implementation seems natural to me. What would be the advantage
> of having nothing selected?

1. User will not be distracted to focus on now-selected shape (the selection indication attracts attention).
2. Contour won't obstruct the view of where you might place/draw the object.

> IMO there are two things that could be improved in this workflow:
> 1) When the user finishes drawing the shape, the shape tool should no longer
> be selected in the sidebar, since the command is no longer enabled (you
> can't immediately draw a second shape)
> 2) If you click a shape tool and give up drawing the shape, it should be
> possible to press Esc and return to selection mode.

That would be nice, but would be a different bug :-)
Comment 3 Rafael Lima 2022-05-28 14:56:19 UTC
Ok... I guess this can be viewed as an enhancement request.

Let's hear the opinion of the UX team about this.

(In reply to Eyal Rozenberg from comment #2)
> That would be nice, but would be a different bug :-)

Indeed. I'll start this discussion in a separate ticket.
Comment 4 Heiko Tietze 2022-05-31 10:42:21 UTC
The "Insert > Shape" button is not a precise description. Rafaels video considers the Shapes sidebar tab. Selecting and object here is similar to clicking a spin box or single-clicking an entry in the Stylist: you don't execute a function but focus a UI control.

It could be seen similarly for the drawing toolbar (and should because of consistency). To click the shape drawing function (for instance .uno:Rect) does not start the drawing process until you click the canvas.

Keep also in mind that selecting a toolbar button is necessary for accessibility. You tab over the buttons and "see" via the screen reader.
Comment 5 Heiko Tietze 2022-06-09 06:25:14 UTC
We discussed this request in the design meeting.

(In reply to Rafael Lima from comment #1)
> 1) When the user finishes drawing the shape, the shape tool should no longer
> be selected in the sidebar...
> 2) ...(by pressing) Esc and return to selection mode.

This makes sense. The Shapes sidebar should not keep any focus.
Comment 6 Eyal Rozenberg 2022-06-09 06:54:21 UTC
(In reply to Heiko Tietze from comment #5)
> We discussed this request in the design meeting.

Was your design focused only on the side-bar "angle" which Rafael brought up, or are you agreeing with my suggestion generally?
Comment 7 Heiko Tietze 2022-06-09 10:47:56 UTC
(In reply to Eyal Rozenberg from comment #6)
> Was your design focused only on the side-bar "angle" which Rafael brought
> up, or are you agreeing with my suggestion generally?

True, c1 has some different angle. Don't see much need to unfocus the object when a command/action is _selected_. You are not drawing a shape unless clicking the canvas and that's the moment when the previously focused object is unselected.
Comment 8 Eyal Rozenberg 2022-06-09 18:12:18 UTC
(In reply to Heiko Tietze from comment #7)
> (In reply to Eyal Rozenberg from comment #6)
> > Was your design focused only on the side-bar "angle" which Rafael brought
> > up, or are you agreeing with my suggestion generally?
> 
> True, c1 has some different angle. Don't see much need to unfocus the object
> when a command/action is _selected_. You are not drawing a shape unless
> clicking the canvas and that's the moment when the previously focused object
> is unselected.

But I get actively distracted by the change in focus, which makes a lot of visual changes in front of me, in places where I was going to draw a box. Sorry I couldn't be in the design meeting to clarify that, but I feel like the app is blinking at me, discouraging me from doing what I wanted to do.