Bug 149396 - "Character" -> "Character Bottom" in "to" option for "to character" anchor and "Below" and "From bottom" as Vertical position
Summary: "Character" -> "Character Bottom" in "to" option for "to character" anchor an...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: difficultyBeginner, easyHack, skillDesign, topicDesign
Depends on:
Blocks: Image-Dialog
  Show dependency treegraph
 
Reported: 2022-05-31 09:54 UTC by sdc.blanco
Modified: 2023-05-13 11:08 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2022-05-31 09:54:35 UTC
To see the issue, use Position and Size dialog for shapes (or tab in Properties for images, frames, OLE objects).

1. Anchor the object "to character"
2. Vertical: must be "From bottom" or "Below"

Actual Result:  "to" option is "Character" (and "Line of text")
Proposed Result: "to" option is "Character bottom"  (and "Line of text")

Reason/Justification.

1. As can be seen in the preview box, "Below" and "From bottom" are positioned in relation to the reference line (bottom of the character).
2. In contrast, the other Vertical options (for "to character" anchor) also offer a "Character" option for "to" -- but notice (in preview) that this "Character" is for a region "Character".
3. The point is that, at present, "Character" has two different meanings in this dialog, where in one case it is a region (or area) and the other it is a line. 

=> The name change would at least remove the likely confusion that "Character" is referring to the same positioning reference, and probably make it easier to explain (in help), because do not need to explain that "Character" has different meanings according to which configuration of options are used.

See bug 148486, comment 9 for support of this proposal.
Comment 1 sdc.blanco 2022-05-31 12:43:26 UTC
Additional discovery:

The OP was in relation to the "Vertical" part of the Position dialog.

This addition is in relation to the "Horizontal" part.

"Character" in "to" for Horizontal position should be "Character left" (if the preview box is to be believed) (and my own experiments support), because this option is positioning the object in relation to a reference line  (namely the left border of the character) and not a character region.

And to go back to "Vertical" position.
There is still need for "Character" as part of the Vertical "to" options (which should only be shown for "Top", "Bottom" and "Center"), while "Character bottom" is shown in "to" in Vertical is "Below" or "From bottom".

Making these changes is a little more demanding than just changing labels in svx/inc/swframeposstrings.hrc because cui/source/tabpages/swpossizetabpage.cxx uses LB:RelChar for all these cases.
Comment 2 Heiko Tietze 2022-06-03 06:02:25 UTC
Sounds reasonable and well thought out.
Comment 3 sdc.blanco 2022-06-03 10:44:42 UTC
(In reply to sdc.blanco from comment #1)
> Making these changes is a little more demanding than just changing labels in
> svx/inc/swframeposstrings.hrc because
> cui/source/tabpages/swpossizetabpage.cxx uses LB::RelChar for all these cases.
Just to avoid "surprises":  the quoted fragment was trying to point out that this is a SkillCPP and difficulty might be a little greater than Beginner -- because it probably will be necessary to (a) add code to create and use some new labels, (b) follow the internal logic for which labels are shown in the dialog, which will also require changes in the internal code, so that the new labels are applied to the right options, while (c) making sure not to change "Character" for some of the existing options.  

Here is a place to start looking at how the present dialog is constructed for "Horizontal" "to" field with the "to character" anchor:
https://opengrok.libreoffice.org/xref/core/cui/source/tabpages/swpossizetabpage.cxx?r=05fa375f#281