Bug 149408 - CRASH: opening the WriterInspectorTextPanel in a OLE object
Summary: CRASH: opening the WriterInspectorTextPanel in a OLE object
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.2.0.0.alpha0+
Hardware: All All
: high major
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.4.0 target:7.3.5 target:7.3.4
Keywords: haveBacktrace
Depends on:
Blocks:
 
Reported: 2022-05-31 16:57 UTC by Xisco Faulí
Modified: 2022-06-01 21:19 UTC (History)
3 users (show)

See Also:
Crash report or crash signature: ["SwDoc::GetEditShell()"]


Attachments
sample file (14.51 KB, application/vnd.oasis.opendocument.spreadsheet)
2022-05-31 16:57 UTC, Xisco Faulí
Details
bt with debug symbols (11.16 KB, text/plain)
2022-05-31 19:31 UTC, Julien Nabet
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2022-05-31 16:57:42 UTC
Created attachment 180507 [details]
sample file

Steps to reproduce:
1. Open attached document
2. Double click on 'Hello' -> Cursor changes to the OLE object
3. Sidebar - Style Inspector

-> Crash

Reproduced in

Version: 7.4.0.0.alpha1+ / LibreOffice Community
Build ID: c3baf2a7f48b5ee46c6792b3106cb4fedb4a2ad2
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded

and

Version: 7.1.0.0.alpha1+
Build ID: 738bcf5e9a8c443d60c29c3a8068e8c16c72638a
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded
Comment 1 Xisco Faulí 2022-05-31 17:00:06 UTC
@Caolán, @Julien, I thought you might be interested in this issue
Comment 2 Julien Nabet 2022-05-31 19:31:09 UTC
Created attachment 180508 [details]
bt with debug symbols

On pc Debian x86-64 with master sources updated today, I could reproduce this.
Comment 3 Caolán McNamara 2022-06-01 11:00:35 UTC
https://gerrit.libreoffice.org/c/core/+/135236
Comment 4 Xisco Faulí 2022-06-01 12:04:38 UTC
(In reply to Caolán McNamara from comment #3)
> https://gerrit.libreoffice.org/c/core/+/135236

Hi Caolán,
it still crashes when leaving the OLE object. Steps:

1. Clean user profile
2. Open attached file
3. Double click on the OLE object
4. Open the navigator - Style Inspector
5. Click somewhere else on the sheet

-> Crash
Comment 5 Commit Notification 2022-06-01 14:03:42 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1fe266c22fb7d277ae612cffd6cc89ef4dcb4269

Resolves: tdf#149408 inspector crash with a writer OLE inside calc

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2022-06-01 14:03:49 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/fc5833b86016b0a940dd87d43dbe490ba1308dfe

Related: tdf#149408 various crashes seen in redline panel

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Caolán McNamara 2022-06-01 14:33:01 UTC
and https://gerrit.libreoffice.org/c/core/+/135244 for that exiting ole issue
Comment 8 Commit Notification 2022-06-01 14:33:20 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/f23faaa44b8bde98bd979032fda9bfce71f7ff96

Resolves: tdf#149408 inspector crash with a writer OLE inside calc

It will be available in 7.3.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2022-06-01 16:13:52 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/31b4e6df39687f4366ff1ac36bb6a727dfa41b10

Related: tdf#149408 various crashes seen in redline panel

It will be available in 7.3.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2022-06-01 16:57:27 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-3-4":

https://git.libreoffice.org/core/commit/cd4a3750ca5473f7dc45250f686c75cdc6a59f83

Related: tdf#149408 various crashes seen in redline panel

It will be available in 7.3.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2022-06-01 17:07:12 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-3-4":

https://git.libreoffice.org/core/commit/8d2421f69afead098003eec63c809c2403924b6c

Resolves: tdf#149408 inspector crash with a writer OLE inside calc

It will be available in 7.3.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Commit Notification 2022-06-01 19:05:15 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/da250c36d43ab96e985b263f41a199b151cd34df

Related: tdf#149408 inspector crash with a writer OLE inside calc

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Julien Nabet 2022-06-01 21:02:23 UTC
With master sources updated today, I confirm I don't reproduce the crash with initial description and after clicking somewhere else in the sheet.

Thank you Caolán!
Comment 14 Commit Notification 2022-06-01 21:19:14 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/232523e1303b3ed6b8f1916a0a28f32b4a258f53

Related: tdf#149408 inspector crash with a writer OLE inside calc

It will be available in 7.3.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.