Bug 149484 - [FILEOPEN] ODS boolean number format missing
Summary: [FILEOPEN] ODS boolean number format missing
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Eike Rathke
URL:
Whiteboard: target:7.4.0 target:7.3.5
Keywords: filter:odf
Depends on:
Blocks:
 
Reported: 2022-06-08 05:19 UTC by SheetJS
Modified: 2022-06-13 02:59 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
lobug.ods (9.31 KB, application/vnd.oasis.opendocument.spreadsheet)
2022-06-08 05:19 UTC, SheetJS
Details

Note You need to log in before you can comment on or make changes to this bug.
Description SheetJS 2022-06-08 05:19:05 UTC
Description:
LO disregards specified number formats for boolean values

Steps to Reproduce:
Open attached file

Actual Results:
cell A3 is TRUE

Expected Results:
cell A3 is -TRUE-


Reproducible: Always


User Profile Reset: Yes



Additional Info:
          <table:table-cell table:style-name="ce6" table:formula="of:=TRUE()" office:value-type="boolean" office:boolean-value="true" calcext:value-type="boolean">

    <style:style style:name="ce6" style:family="table-cell" style:parent-style-name="Default" style:data-style-name="N124"/>

    <number:boolean-style style:name="N124">
      <number:text>-</number:text>
      <number:boolean/>
      <number:text>-</number:text>
    </number:boolean-style>

According to the spec, that is a valid style which should be interpreted as the literal "-" followed by the boolean value (interpretation omitted but TRUE/FALSE is plausible) followed by another literal "-".
Comment 1 SheetJS 2022-06-08 05:19:28 UTC
Created attachment 180627 [details]
lobug.ods
Comment 2 Mike Kaganski 2022-06-08 05:56:40 UTC
Repro with Version: 7.3.4.1 (x64) / LibreOffice Community
Build ID: 13668373362b52f6e3ebcaaecb031bd59a3ac66b
CPU threads: 12; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: en-US (ru_RU); UI: en-US
Calc: CL Jumbo

Also adding literal text to BOOLEAN specifier in cell format does not change the result.
Comment 3 Commit Notification 2022-06-08 18:15:53 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2932dc7aa0c1239d39e060e6b7627317f1305549

Related: tdf#149484 Display BOOLEAN literal string text additions

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2022-06-08 18:17:01 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/025231224b8b076e280235cd2b943addd2fb0755

Resolves: tdf#149484 Read and handle <number:text> in <number:boolean-style>

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2022-06-08 18:50:37 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/33a8c4bd0e8533ab42894280e7e04c13a47aefa9

Related: tdf#149484 Write proper <number:boolean-style> with <number:text>

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2022-06-09 10:35:51 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e04fab838f8088e7cf12b68ac3b505350521623c

tdf#149484: subsequent_filters: Add unittest

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Eike Rathke 2022-06-10 10:36:24 UTC
Pending review https://gerrit.libreoffice.org/c/core/+/135586 for 7-3
Comment 8 Commit Notification 2022-06-13 02:59:48 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/801303c4d9e02fbc46216fd3b58186b48aec0258

Resolves: tdf#149484 Handle <number:boolean-style> with <number:text>

It will be available in 7.3.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.