1. Make table, place cursor in a cell, find or open Table toolbar. 2. Click "Properties" icon (at right end of toolbar) multiple times. Actual: Table Properties dialog appears each time the icon is clicked. Expected: Only one dialog is opened; additional clicks return to the open dialog. Version: 7.4.0.0.alpha1+ (x64) / LibreOffice Community Build ID: bbec710bd25fc5da27636cde73fe4ab23c76904f CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: da-DK (da_DK); UI: en-US Calc: CL
Not repro with Version: 7.4.0.0.alpha1+ / LibreOffice Community Build ID: 118bafcfd1ce4a26ec9df912197ebd466d1bd497 CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: x11 Locale: pt-BR (pt_BR.UTF-8); UI: en-US Calc: CL I also could not reproduce in gtk3, gen or win. Can you check this again? The Table Properties dialog opens as modal for me and I cannot click anything outside the dialog.
(In reply to Rafael Lima from comment #1) > Can you check this again? Further testing (also in Safe Mode) reveals: Table bar docked. Only one copy (i.e., modal) (OK) Table bar undocked. Multiple copies (NOK) (changing summary)
Indeed... now with the undocked toolbar I can confirm this bug using "win" and "gen". However it does not happen in "kf5". I'm setting this to NEW, since the reported behavior should not be happenning.
Let's make this more interesting. (in all cases, clicking on "Properties" icon on relevant toolbar) 1. Frame: Undocked (multiple copies) Docked (one) 2. Image Undocked (multiple copies) Docked (one) 3. OLE Object: Undocked (multiple copies) Docked (multiple copies!) For a Shape -- no Properties dialog -- but: - click the "Position and Size" icon on the status bar multiple times (count how many). - it appears that only one Position and Size dialog is open -- but -- click "Cancel" and a new copy appears, until you have cancelled the number of times that you originally clicked. Additional information: I have encountered this multiple case before with Position and Size, and have had some crashes, without being able to figure out STR, but usually involves changing some control options, and cancelling
In Draw 1. With selected image, open Image toolbar undocked. 2. Click multiple times on "Line" icon Result: Multiple copies of Line dialog are opened. => Bold generalization: undocked toolbars (in all applications) with icons that open a dialog box will open multiple copies of that dialog (if the icon is clicked multiple times). cc: Caolán, because I think this is his bailiwick.
Can reproduce all described effects (also with docked OLE Object toolbar) with: Version: 7.2.6.2 (x64) / LibreOffice Community Build ID: b0ec3a565991f7569a5a7f5d24fed7f52653d754 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: da-DK (da_DK); UI: en-US Calc: threaded (changing version number)
I think "3. OLE Object: Undocked (multiple copies) Docked (multiple copies!)" is the special case and that dialog should be modal and its an oversight that it is not. https://gerrit.libreoffice.org/c/core/+/135655 for that the rest is then the general case that under "gen" modal dialogs don't lock floating toolbars? while it does lock under gtk3/kf5. Do we know if this was always the case or was there a time in the past when it was not true?
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7fee3f624370bd2911842bb8ed35d8cb27af8062 Related: tdf#149490 OLE Object dialog should be modal It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-4": https://git.libreoffice.org/core/commit/538845880bcc50cecb0bf9f03da90bbde0c189dc Related: tdf#149490 OLE Object dialog should be modal It will be available in 7.4.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-3": https://git.libreoffice.org/core/commit/f57b4c7e8bf83d9e59782a478b105aa9cdb7a042 Related: tdf#149490 OLE Object dialog should be modal It will be available in 7.3.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Caolán McNamara from comment #7) > the rest is then the general case that under "gen" modal dialogs don't lock > floating toolbars? while it does lock under gtk3/kf5. Do we know if this was > always the case or was there a time in the past when it was not true? cc: @Telesto -- can you help with testing earlier versions of LO. For example, with an undocked "Image" or "Frame" toolbar, click on the "Properties" icon and see if you get a new copy of the Properties dialog, each time you click the icon.