Bug 149536 - [UI] The Data Table dialog enables the button Move Row Up and disables the button Move Row Down when the opposite is needed (and vice versa).
Summary: [UI] The Data Table dialog enables the button Move Row Up and disables the bu...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.4.0.3 release
Hardware: All All
: medium normal
Assignee: Aron Budea
URL:
Whiteboard: target:7.5.0 target:7.3.5 target:7.4....
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Chart-Data
  Show dependency treegraph
 
Reported: 2022-06-12 20:30 UTC by LeroyG
Modified: 2022-06-15 03:42 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
File with a simple chart with data table. (12.28 KB, application/vnd.oasis.opendocument.spreadsheet)
2022-06-12 20:30 UTC, LeroyG
Details
Dialog screenshot (from Linux version, Elementary icon style). (32.71 KB, image/png)
2022-06-12 20:38 UTC, LeroyG
Details
Dialog screenshot (from Windows version). (27.94 KB, image/jpeg)
2022-06-12 20:40 UTC, LeroyG
Details

Note You need to log in before you can comment on or make changes to this bug.
Description LeroyG 2022-06-12 20:30:57 UTC
Created attachment 180695 [details]
File with a simple chart with data table.

In the Data Table dialog, for a chart, Move Row Up button is enabled for the first row, and Move Row Down button is enabled for the last row, when the opposite was expected.

Steps to reproduce:
1. Edit the data table of a chart (open the attached sample file)
2. Choose menu View - Data Table (you can access it from the chart context menu)
3. Select the first (and last) row
4. See the two rightmost buttons.

Tested with:
Version: 7.2.3.2 / LibreOffice Community
Build ID: 20(Build:2)
CPU threads: 1; OS: Linux 5.3; UI render: default; VCL: gtk3
Locale: es-MX (es_ES.UTF-8); UI: en-US
Calc: threaded

Version: 7.2.7.2 (x86) / LibreOffice Community
Build ID: 8d71d29d553c0f7dcbfa38fbfda25ee34cce99a2
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win
Locale: es-MX (es_MX); UI: en-US
Calc: threaded
Comment 1 LeroyG 2022-06-12 20:38:33 UTC
Created attachment 180696 [details]
Dialog screenshot (from Linux version, Elementary icon style).

Buttons are highlighted.
Comment 2 LeroyG 2022-06-12 20:40:25 UTC
Created attachment 180697 [details]
Dialog screenshot (from Windows version).
Comment 3 Rafael Lima 2022-06-13 20:18:23 UTC
Repro with

Version: 7.3.3.2 / LibreOffice Community
Build ID: 30(Build:2)
CPU threads: 12; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Ubuntu package version: 1:7.3.3~rc2-0ubuntu0.21.10.1~lo1
Calc: threaded

And with

Version: 7.4.0.0.alpha1+ / LibreOffice Community
Build ID: b2467d6c7af988f8ed4e090ebf9472be6c84fb06
CPU threads: 12; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: CL

This is definitely a bug... The user is unable to move down the first row; neither is it possible to move the last row up.
Comment 4 Aron Budea 2022-06-14 03:24:20 UTC
Fix: https://gerrit.libreoffice.org/c/core/+/135801

This is a regression from the following commit in 6.4:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=aa7e7747f4296b3b92379c3c7703b80ad8af6a8b
author		Caolán McNamara <caolanm@redhat.com>	2019-09-25 14:15:38 +0100
committer	Caolán McNamara <caolanm@redhat.com>	2019-09-26 13:21:22 +0200

weld DataEditor
Comment 5 Commit Notification 2022-06-14 15:17:15 UTC
Aron Budea committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b33d89d8e97ba4bfb17743632dee471727d11ac5

tdf#149536 Move Up/Down in Data Table switched enabled statuses

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Aron Budea 2022-06-14 15:28:19 UTC
Backports are in gerrit.
Comment 7 Commit Notification 2022-06-14 19:46:43 UTC
Aron Budea committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/2c37dc951b08f92406d1fc74052e20eb7cba98f9

tdf#149536 Move Up/Down in Data Table switched enabled statuses

It will be available in 7.3.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2022-06-15 03:42:17 UTC
Aron Budea committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/bba36d106c43513923cce393da05df3c732c5ea0

tdf#149536 Move Up/Down in Data Table switched enabled statuses

It will be available in 7.4.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.