Bug 149638 - F1 (Help) on Table toolbar for Impress / Draw does not open help page
Summary: F1 (Help) on Table toolbar for Impress / Draw does not open help page
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Documentation (show other bugs)
Version:
(earliest affected)
7.5.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.5.0 target:7.4.0.0.beta2
Keywords:
Depends on:
Blocks: Help-Link
  Show dependency treegraph
 
Reported: 2022-06-20 12:07 UTC by sdc.blanco
Modified: 2022-08-09 19:02 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2022-06-20 12:07:58 UTC
Table toolbar for Impress and Draw is different than Table toolbar for Writer.
No help page for Impress or Draw toolbar, which appears to be identical for both applications.
Comment 1 Ezinne 2022-06-30 07:41:57 UTC
Reproducible in :

Version: 7.4.0.0.alpha1+ / LibreOffice Community
Build ID: f572585756494c59fb81f5d93c51cc2d35421f0e
CPU threads: 4; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: en-NG (en_NG); UI: en-US
Calc: threaded
Comment 2 Commit Notification 2022-06-30 12:20:04 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/614feb3f2bc5f5c994dc6898b5af83f928a8b8f3

tdf#149638 (partial) add Table bar to Contents for Draw and Impress
Comment 3 Commit Notification 2022-06-30 12:30:17 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/help/commit/9f1db7394156428dba9c37ac76548562c825fed4

tdf#149638 (partial) add Table bar to Contents for Draw and Impress
Comment 4 sdc.blanco 2022-06-30 12:32:34 UTC
Found a Table bar help page for Draw/Impress:

https://help.libreoffice.org/7.5/en-US/text/shared/main0204.html?&DbPAR=DRAW
https://help.libreoffice.org/7.5/en-US/text/shared/main0204.html?&DbPAR=IMPRESS

But pressing F1 on Table toolbar (in Draw or Impress) should go to that page.
    Maybe this is needed: hid/.HelpId:tableobjectbar"

Updated bug summary to current situation.
Comment 5 Olivier Hallot 2022-08-08 20:16:42 UTC
I looked at this issue. It seems the toolbars are not set to launch a help page.

The only toolbar that has a HelpId is the findbar. But the findbar is wrapped in a .ui dialog that sends the right HelpId. See

https://opengrok.libreoffice.org/xref/help/source/text/shared/find_toolbar.xhp?r=8a560f13

Line 23 is the good one, line 24 is useless and can be removed.

It will require a new ticket to implement a helpid for the toolbars.
Comment 6 Maxim Monastirsky 2022-08-09 19:02:55 UTC
(In reply to Olivier Hallot from comment #5)
> I looked at this issue. It seems the toolbars are not set to launch a help
> page.
Actually we do set help ids for toolbars, see ToolBarManager::Init, and they seem to work fine for me. e.g. in Writer pressing F6 twice so the focus lands on the Standard toolbar, and then pressing F1, it will try to open the help for .HelpId:standardbar. Same works for me also with the outline toolbar in Impress.

But there was a recent regression with a missing colon in those, which should be fixed with https://gerrit.libreoffice.org/c/core/+/138066.

> The only toolbar that has a HelpId is the findbar. But the findbar is
> wrapped in a .ui dialog that sends the right HelpId.
This is only when the find text field has the focus, but if you tab to another button on the toolbar (e.g. Find Previous) it will request .HelpId:findbar.