Bug 149755 - Bottom of characters covered inside bookmarks / tables on zoom levels < 150% on Win GDI render
Summary: Bottom of characters covered inside bookmarks / tables on zoom levels < 150% ...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.4.0.0 beta1+
Hardware: All Windows (All)
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.5.0 target:7.4.0.0.beta2
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Font-Rendering
  Show dependency treegraph
 
Reported: 2022-06-28 09:23 UTC by Gabor Kelemen (allotropia)
Modified: 2022-06-28 19:34 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file from Writer (11.83 KB, application/vnd.oasis.opendocument.text)
2022-06-28 09:23 UTC, Gabor Kelemen (allotropia)
Details
The example file in Writer master (3.44 KB, image/png)
2022-06-28 09:24 UTC, Gabor Kelemen (allotropia)
Details
attachment 157397 in 7.3.0 and 7.4 master, with Win GDI render (152.02 KB, image/png)
2022-06-28 09:25 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2022-06-28 09:23:35 UTC
Created attachment 180992 [details]
Example file from Writer

Attached document contains some bookmarked texts.
When opening it on Windows with Skia turned off (on Linux it does not), the lower part of the bookmarked letters is hidden, as if there was some sort of inner margin hiding it.
This happens with zoom levels below 150%, at and above this zoom it is fine.

The same happens in some tables too, such as attachment 157397 [details] from bug 77417.

1/a, Open attached document
1/b, Open attachment 157397 [details] 
2/a, Notice the bookmarked text in the third and fourth paragraphs, "Ende" and "innerhalb" - the lower part of the characters is not visible.
2/b, Notice the text in the bottommost row of the second table on the first page, "Low" and the numbers - the lower part of the characters is not visible.

Bibisected on 7.4-windows to:

https://git.libreoffice.org/core/+/bb495c6a2f00346698a041bce69a5a97effc79d7%5E%21/#F0

author	Caolán McNamara <caolanm@redhat.com>	Mon Jan 17 12:48:43 2022 +0000
committer	Caolán McNamara <caolanm@redhat.com>	Mon Jan 17 17:23:18 2022 +0100

tdf#144862 set default render mode to LayoutAndMatchRender

Adding CC to: Caolán McNamara
Comment 1 Gabor Kelemen (allotropia) 2022-06-28 09:24:33 UTC
Created attachment 180993 [details]
The example file in Writer master

Version: 7.4.0.0.beta1+ (x64) / LibreOffice Community
Build ID: 3c4acc718549ab027be5465d60c8d5a0e3b8feaa
CPU threads: 14; OS: Windows 10.0 Build 19044; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: threaded
Comment 2 Gabor Kelemen (allotropia) 2022-06-28 09:25:46 UTC
Created attachment 180994 [details]
attachment 157397 [details] in 7.3.0 and 7.4 master, with Win GDI render
Comment 3 Caolán McNamara 2022-06-28 13:50:44 UTC
seems to be in the dwrite path, which is picked for this case
Comment 4 Caolán McNamara 2022-06-28 14:31:38 UTC
The bottom of the "g"s are clipped off too. https://gerrit.libreoffice.org/c/core/+/136577 looks promising locally.
Comment 5 Commit Notification 2022-06-28 18:34:56 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/496426503675c6da60c6f3cd78549c8a70a8c694

tdf#149755 bottom of characters missing in dwrite rendered case

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2022-06-28 18:36:08 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/d8963ecd20579a62906eae3ed14d498bf07cbb98

tdf#149755 bottom of characters missing in dwrite rendered case

It will be available in 7.4.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Caolán McNamara 2022-06-28 19:34:31 UTC
seems to solve it, double check appreciated