Bug 149796 - styles / document: "autoupdate" -- misleading meaning
Summary: styles / document: "autoupdate" -- misleading meaning
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium enhancement
Assignee: sdc.blanco
URL:
Whiteboard: target:24.2.0 inReleaseNotes:24.2
Keywords: difficultyBeginner, easyHack, skillDesign, topicDesign
Depends on:
Blocks: Styles-Dialog
  Show dependency treegraph
 
Reported: 2022-07-01 03:41 UTC by peter josvai
Modified: 2024-01-26 11:37 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
proposed tip for "Automatic update..." (26.42 KB, image/png)
2023-09-06 10:17 UTC, sdc.blanco
Details

Note You need to log in before you can comment on or make changes to this bug.
Description peter josvai 2022-07-01 03:41:01 UTC
hi, 


I'm sure that one can argue the opposite, but look at styles and the process of writing a document...

if you have a document (this is your "scope", the context within which you think), and see the checkbox and its title: "autoupdate", what would that mean?
What meaning would you rad from this?


it will mean: "if I check this, my page will automatically update once the style is modified, ah, cool, that's what I want"

How wrong! :)

It will mean, in reality, that once you modify a paragraph's "look" (by applying direct formatting), your style will be modified, I mean, your style in your template! And then all your documents, whenever you click "OK" to the popup: "your style has changed, do you want to update your document?", the template will me modded...


This shouldn't work like this. 


"autoupdate" is ANYWAY a superfluous category in terms of styles, cause the point in the using styles is to get pages "automatically updated"...


so, a different name should be invented to preserve / achieve integrity...

and that title / name should reflect what will happen...

for example:      

"reverse update" (something analogous to "feedback" would be better), 

or "doc-to-template update" .... (from this, the real-time is what's missing)


or "real time template update"


you name it :)


- - - - -


AND there is something faulty in it systemically, too:

cause this checkbox you can "tick" (check) in the template...
which will cause a LOOP...

cause if it is checked in the template... (the person using the program will think in the template's scope, thinking that the template's style will do what a template's style has to do anyway: autoupdate) 

whilst in reality, she or he will give all future documents based on that template a "write-back" editing access to the template's styles



I hope I'm not completely wrong :) or rather, I hope I am! :)


Peter


                - - - thank you for developing Writer - - -
Comment 1 Heiko Tietze 2022-07-01 07:46:12 UTC
We have plenty of space. How about "Update style when changing attributes"? Seth, what do you think?
Comment 2 sdc.blanco 2022-07-01 09:19:21 UTC
First attempt:

[] Automatic style update from document

Tooltip: Paragraph formatting changes to any paragraph with this style are applied automatically to update this style.

To "help page" [1] add this tip under this option: 

If this option is not enabled, then use *Styles – Update Selected Style* to add any formatting changes to the paragraph style.

[1] https://help.libreoffice.org/7.5/en-US/text/shared/01/05040100.html

Comment:  Have used "update" and "style" in label and tool tip -- to keep some connection to the menu command "Styles - Update Selected Style" (also in Sidebar).

Comment to Peter: (enjoyable OP) -- maybe you can see now that this Autoupdate "option" is "opposite" of "Update Selected Style".  It gives you a way to see the effects of formatting changes automatically to all paragraphs in the style. 

I agree that the label should be changed -- because it misleads -- gives the impression that any changes in the Style dialog will not be automatically updated for all paragraphs with that style. 

("Autoupdate" also appears in "Frame Style")
Comment 3 Heiko Tietze 2022-07-07 06:43:57 UTC
The topic was on the agenda of the design meeting but did not receive further comments. So let's do it as suggested.

Code pointer: sfx2/uiconfig/ui/managestylepage.ui
Comment 4 Dieter 2023-09-03 19:08:40 UTC
(In reply to Heiko Tietze from comment #3)
> So let's do it as suggested.
=> NEW
Comment 5 sdc.blanco 2023-09-04 09:17:16 UTC
Second draft proposal:

Label in organizer:   

 [ ] Modify style with paragraph formatting in document

Tooltip:  

Any paragraph formatting changes in the document to a paragraph with this style are applied automatically to modify the paragraph style.


Tip in help:

If this option is not enabled, then use *Styles – Update Selected Style* to modify the paragraph style of the current paragraph with any direct paragraph formatting changes made to that paragraph.


(also, the position of the labels in the Organizer tab do not follow the design guidelines.)
Comment 6 Heiko Tietze 2023-09-04 10:58:47 UTC
(In reply to sdc.blanco from comment #2)
> [ ] Automatic style update from document

(In reply to sdc.blanco from comment #5)
> [ ] Modify style with paragraph formatting in document

I'd prefer the first one (maybe without "style") while the second tooltip is a bit more clear.
Comment 7 Commit Notification 2023-09-05 21:03:27 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/fdb2a457708f345affa6dd254180220b08393c2e

(related) tdf#149796  align labels left - according to design guidelines

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 sdc.blanco 2023-09-06 10:17:33 UTC
Created attachment 189386 [details]
proposed tip for "Automatic update..."

Here is patch for UI (using "second" tooltip and "Automatic update from document")
https://gerrit.libreoffice.org/c/core/+/156593

And the attached file shows the proposed tip to be added in the help page [1].
No plans to change the currently existing text in the help page, unless further comment is received.


[1] https://help.libreoffice.org/24.2/en-US/text/shared/01/05040100.html?&DbPAR=WRITER
Comment 9 Commit Notification 2023-09-09 07:13:34 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f4d19e6bd5d33263019396d596dcc819f2b8e26a

tdf#149796 "autoupdate" -> "Automatic update from document"

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2023-09-09 09:45:51 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/9f24e78f7c45b3fae572c80e3a0542203c829fa8

(related) tdf#149796 "autoupdate" -> "Automatic update from document"
Comment 11 Stéphane Guillou (stragu) 2024-01-26 11:37:06 UTC
Verified in:

Version: 24.2.0.2 (X86_64) / LibreOffice Community
Build ID: b1fd3a6f0759c6f806568e15c957f97194bbec8f
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Thanks Seth!