Bug 149917 - LineStartName / LineEndName "Symmetric Arrow" vanished; braking old macro's using the style name attribute
Summary: LineStartName / LineEndName "Symmetric Arrow" vanished; braking old macro's u...
Status: REOPENED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
7.3.3.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, needsDevAdvice, regression
Depends on:
Blocks: Arrow_Style
  Show dependency treegraph
 
Reported: 2022-07-08 12:32 UTC by Wolfgang Jäger
Modified: 2023-11-29 19:35 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Wolfgang Jäger 2022-07-08 12:32:30 UTC
How to reproduce: 
1.
Create an empty (1 page)  'Draw' component.
Insert an ordinary line.
Edit its properties via the UI an try to find "Symmetric Arrow" (or "Symmetric arrow" for Arrow Styles (Start or End): Not offered
Select the line object.
Try to run in Basic IDE

l = ThisComponent.CurrentSelection(0)
l.LineStartName = "Symmetric arrow"

Error reported.

2. (Running V6.4.5 in parallel if possible)
Do the first two steps as described above.
Edit the line properties, and you find a name "Symmetric arrow".
Apply it to the start. Effect as expected.

3.
Copy the line object and insert it into the drawing created with 7.3.3
Inspect the pasted line with the UI: NO end styles though shown for the pasted line in the view for Start.
Create a new ordinary line now.
select it and run in Basic

l = ThisComponent.CurrentSelection(0)
l.LineStartName = "Symmetric arrow"

Runs without error.
Result showing in the view.
Not showing in the properties dialog.

The "imported name" is n ow "half known" to the component.
Comment 1 raal 2022-08-03 16:12:08 UTC
Confirm Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: 3ccbfaaf95005a34ca64ad250463ef5ce8842f43
CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: x11
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded

symmetric arrow missing. Stzle is present in Version: 6.3.0.0.alpha1+
Build ID: c98b1f1cd43b3e109bcaf6324ef2d1f449b34099
Comment 2 raal 2022-08-03 20:46:06 UTC
This seems to have begun at the below commit.
Adding Cc: to Andreas Kainz; Could you possibly take a look at this one?
Thanks
 57b15bb85dcf99e88326b110c033b4c07aa27e28 is the first bad commit
commit 57b15bb85dcf99e88326b110c033b4c07aa27e28
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Thu Apr 9 21:52:42 2020 +0200

    source 22a1557314ffa7c8ae57ebe5d0056893ed1103a8

https://git.libreoffice.org/core/+/22a1557314ffa7c8ae57ebe5d0056893ed1103a8
Comment 3 Julien Nabet 2022-08-21 07:19:34 UTC
See https://bugs.documentfoundation.org/show_bug.cgi?id=126648#c8
"I rename symmetric arrow to triangle cause this it the same".

Since the name style of arrows are not in a public something or equivalent and this part has been redesigned with tdf#126648, I'd say "NOTABUG" but I may be wrong.

Heiko: any thoughts here?
Comment 4 Heiko Tietze 2022-08-22 10:14:05 UTC
(In reply to Julien Nabet from comment #3)
> I'd say "NOTABUG"

Me too. And if Wolfgang really needs the legacy line style(s) it's pretty easy to change locally. Just add 

<draw:marker draw:name="Symmetric Arrow" svg:viewBox="0 0 1131 902" svg:d="M564 0l-564 902h1131z" />

to ~/.config/libreoffice/4/user/config/standard.soe (in case of Linux). Or use the dialog's "load arrow style" function (icon-only button above the preview) to load these styles into the document.
Comment 5 Wolfgang Jäger 2022-08-22 10:41:29 UTC
(In reply to Heiko Tietze from comment #4)
> (In reply to Julien Nabet from comment #3)
> > I'd say "NOTABUG"
> 
> Me too. And if Wolfgang really needs the legacy line style(s) it's pretty
> easy to change locally. Just add 
> ...

I didn't create the bug report because I "needed" that LineEndStyle, but because a qustioner in the ask site needed it. See https://ask.libreoffice.org/t//79362I. then tried and found the change confirmed. In addition the changed behavior includes a clear inconsistency as I alread explained. 

Since the "Symmetric Arrow" actually is an equilateral triangle with the expectable directions, and by that not just a fancy style, I would expect more than one user to be afflicted. The style should not be deprecated AND removed without notice. I therefore assume an effect vinadvertently induced by any change made for a different purpose.

Please consider my argument.
If you change your mind (as I expect), please re-open the bug.
Comment 6 Heiko Tietze 2022-09-01 06:57:57 UTC
We discussed this topic in the design meeting.

According bug 126648 the "Symmetric Arrow" was just renamed to "Arrow Short". And in my opinion a macro that relies on a certain style or name is wrong. If we cannot change design we would be able to only add more and break any KISS principle.

But others consider the reliability higher and suggest to investigate a code solution. Whatever this would look like. => needsDevAdvice