Bug 149975 - Fix tooltips for spacing options (and group them) in English-Sentence-Checking
Summary: Fix tooltips for spacing options (and group them) in English-Sentence-Checking
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.3.5.2 release
Hardware: x86-64 (AMD64) All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsDevEval
Depends on:
Blocks: Options-Dialog-Language
  Show dependency treegraph
 
Reported: 2022-07-13 12:21 UTC by taichi
Modified: 2023-04-13 10:54 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description taichi 2022-07-13 12:21:18 UTC
Description:
More-spaces on English-Sentence-Checking does not work with two extra spaces, it can work with more than three extra spaces.

Steps to Reproduce:
1.Select for [Options]->[Language Settings]->[English Sentence Checking].
2.Enable "More spaces" only.
3.Insert three spaces (one spaces + two extra spaces) between English words in a document.

Actual Results:
Spell-check does not work without additional spaces.

Expected Results:
Spell-check works and wavy lines appear in the blank spaces.


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: a93d7e7df6804cd6f1f2fa1ef0e6e95ce6c3752a
CPU threads: 8; OS: Windows 10.0 Build 22000; UI render: Skia/Vulkan; VCL: win
Locale: ja-JP (ja_JP); UI: ja-JP
Calc: CL
Comment 1 Ezinne 2022-07-21 21:16:06 UTC
Reproducible in:


Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: 36994c19fdbf425108f685de21464496bd93b651
CPU threads: 4; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: en-NG (en_NG); UI: en-US
Calc: threaded
Comment 2 taichi 2022-07-24 01:12:13 UTC Comment hidden (obsolete)
Comment 3 taichi 2022-07-24 01:19:30 UTC
I will repost the comment because it was difficult to read.


Reproducible in:

Version: 7.4.0.1 / LibreOffice Community
Build ID: 43e5fcfbbadd18fccee5a6f42ddd533e40151bcf
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: ja-JP (ja_JP.UTF-8); UI: ja-JP
Calc: threaded

Version: 7.3.5.2 / LibreOffice Community
Build ID: 184fe81b8c8c30d8b5082578aee2fed2ea847c01
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: ja-JP (ja_JP.UTF-8); UI: ja-JP
Calc: threaded(In reply to AAAA from comment #2)


Also, a similar bug occurred in pt-BR spell-check.
Comment 4 Stéphane Guillou (stragu) 2023-04-13 09:37:19 UTC
Testing with:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 1b06f35de68a555b85bceb5fc29d1a5f426f4bb7
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR
Calc: threaded

- Only "Word spacing" selected: Underlines groups of 2 or 3 spaces.
- Only "More spaces" selected: Only underlines 4 and above spaces.
- "Word spacing" and "More spaces" selected: all multiple spaces underlined.

This actually matches the tooltip for "More spaces", currently: "Check more than two extra space characters between words and sentences."
Admittedly, an awkward wording: "more than two extra spaces" is "more than 2 + 1", so "4 and above".

So in my opinion, it's the tooltips that need fixing:

- Word spacing: "Detect 2 or 3 spaces between words."
- Sentence spacing: "Detect 2 or 3 spaces between sentences."
- More spaces: "Detect 4 or more spaces between words and sentences."

In any case, I think these three settings should be grouped along with "Sentence spacing".

I changed the summary accordingly.

Hossein, could this be an easy hack?
Comment 5 Stéphane Guillou (stragu) 2023-04-13 10:54:09 UTC
See also suggestion to always use the form "Checks for" in https://bugs.documentfoundation.org/show_bug.cgi?id=143996#c8