Bug 150232 - Form Properties dialog becomes black on Datasource/Content type change
Summary: Form Properties dialog becomes black on Datasource/Content type change
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: graphics stack (show other bugs)
Version:
(earliest affected)
7.3.5.2 release
Hardware: All Windows (All)
: medium normal
Assignee: Julien Nabet
URL:
Whiteboard: target:7.5.0 target:7.4.1 target:7.3.6
Keywords:
: 142530 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-08-02 14:43 UTC by Elena Pazina
Modified: 2022-11-23 12:05 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Black form properties dialog (2.58 KB, image/png)
2022-08-02 14:43 UTC, Elena Pazina
Details
Black form properties dialog (8.26 KB, image/png)
2022-08-02 14:43 UTC, Elena Pazina
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Elena Pazina 2022-08-02 14:43:07 UTC
Created attachment 181548 [details]
Black form properties dialog

Steps to reproduce:
0. Launch Writer application
1. Create any type of form, for example Label
2. Open Form-Form properties dialog
3. Go to Data tab
4. Change Data source or Content type
Expected:
4. Dialog is rendered successfully
Actual:
4. Part of window turns to black, dialog cannot be used

Checked on:
Windows 10 LibreOffice Version: 7.3.4.2 (x64) VCL: win - reproducible
Windows 10 LibreOffice Version: 7.3.5.2 (x64) VCL: win - reproducible
Windows 10 LibreOffice Version: 6.2.5.2 (x64) VCL: win - not reproducible

The issue is not reproducible in the following cases on 7.3.4.2:
- if application is started in Safe mode
- if Skia is disabled in Tools-Options-View-Use Skia for all rendering - unchecked
- if Skia is disabled by env variable: SAL_DISABLESKIA=1

skia.log content:
RenderMethod: vulkan
Vendor: 0x8086
Device: 0x9a49
API: 1.2.204
Driver: 0.404.1404
DeviceType: integrated
DeviceName: Intel(R) Iris(R) Xe Graphics
Denylisted: no
Comment 1 Elena Pazina 2022-08-02 14:43:32 UTC
Created attachment 181549 [details]
Black form properties dialog
Comment 2 Julien Nabet 2022-08-02 17:50:24 UTC
Thank you for the clear and detailed report which includes Skia info.

Before modifying skia/skia_denylist_vulkan.xml which deals about combinations of device id, os, vendor and version, could you just confirm you got last version of graphic driver? (see first step of https://wiki.documentfoundation.org/QA/FirstSteps#Graphics-related_issues_.28_Skia_.29)
Comment 3 Elena Pazina 2022-08-03 14:19:14 UTC
I have updated my driver version to the latest and the issue is still reproducible.

Could you please find information about graphic driver below. 


Before update:
Display Adapters
-------------------------------------------------------------------------

Display adapter 0	
	ID			0x4000000
	Name			Intel(R) Iris(R) Xe Graphics
	Board Manufacturer	Hewlett-Packard
	Execution Units		96
	Memory type		DDR4
	Memory bus width	64 bits
	PCI device		bus 0 (0x0), device 2 (0x2), function 0 (0x0)
		Vendor ID	0x8086 (0x103C)
		Model ID	0x9A49 (0x87E1)
		Revision ID	0x1
	Driver version		30.0.101.1404
	WDDM Model		2.7

Win32_VideoController		AdapterRAM = 0x40000000 (1073741824)
Win32_VideoController		DriverVersion = 30.0.101.1404
Win32_VideoController		DriverDate = 02/18/2022

After update:
Display adapter 0	
	ID			0x4000000
	Name			Intel(R) Iris(R) Xe Graphics
	Board Manufacturer	Hewlett-Packard
	Execution Units		96
	Memory type		DDR4
	Memory bus width	64 bits
	PCI device		bus 0 (0x0), device 2 (0x2), function 0 (0x0)
		Vendor ID	0x8086 (0x103C)
		Model ID	0x9A49 (0x87E1)
		Revision ID	0x1
	Performance Level	Current
		Core clock	550.0 MHz
	Driver version		31.0.101.3222
	WDDM Model		2.7

Win32_VideoController		AdapterRAM = 0x40000000 (1073741824)
Win32_VideoController		DriverVersion = 31.0.101.3222
Win32_VideoController		DriverDate = 07/11/2022
Comment 4 Elena Pazina 2022-08-03 15:03:02 UTC
skia.log after update:
RenderMethod: vulkan
Vendor: 0x8086
Device: 0x9a49
API: 1.3.218
Driver: 0.404.3222
DeviceType: integrated
DeviceName: Intel(R) Iris(R) Xe Graphics
Denylisted: no

Skia trace:
info:vcl.skia:2644:8848:vcl/skia/SkiaHelper.cxx:135: Vulkan API version: 1.3.218, driver version: 0.404.3222, vendor: 0x8086 (Intel),
device: 0x9a49, type: integrated, name: Intel(R) Iris(R) Xe Graphics
Comment 5 Julien Nabet 2022-08-03 19:23:55 UTC
Thank you for your new feedback.

I gave a try with https://gerrit.libreoffice.org/c/core/+/137768.
It's not a fix per se just a patch to blacklist Iris driver (which seems to use device id="0x9a49") on Windows for any version instead of just a specific version of the driver.

Luboš/Ilmari: as you may have seen, I put you as reviewers of the patch if you've got some opinion here.
Comment 6 Elena Pazina 2022-08-04 08:09:03 UTC
I have checked the issue on another PC. It's also reproducible for:
RenderMethod: vulkan
Vendor: 0x10de
Device: 0x1401
API: 1.2.194
Driver: 511.92.0
DeviceType: discrete
DeviceName: NVIDIA GeForce GTX 960
Denylisted: no
Comment 7 Julien Nabet 2022-08-04 08:27:17 UTC
(In reply to Elena Pazina from comment #6)
> I have checked the issue on another PC. It's also reproducible for:
> RenderMethod: vulkan
> Vendor: 0x10de
> Device: 0x1401
> API: 1.2.194
> Driver: 511.92.0
> DeviceType: discrete
> DeviceName: NVIDIA GeForce GTX 960
> Denylisted: no

Argh, today we got:
        <entry os="windows" vendor="nvidia" compare="less" version="457.36.0">
            <device id="all"/>
        </entry>

it seems we should do remove the version/compare so Skia would be disabled in each Windows if Nvidia is used.

With Intel/Iris, it means there would be quite a lot of configs which won't use Skia.

We may also, create a specific entry like this:
        <entry os="windows" vendor="nvidia">
            <device id="0x1401"/>
        </entry>


Luboš: any thoughts here?
Comment 8 Julien Nabet 2022-08-06 13:14:20 UTC
Just for the record, I updated https://gerrit.libreoffice.org/c/core/+/137768 by adding the block indicated in https://bugs.documentfoundation.org/show_bug.cgi?id=150232#c7 so to take into account https://bugs.documentfoundation.org/show_bug.cgi?id=150232#c6.
Comment 9 Commit Notification 2022-08-06 14:31:05 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/407a61943539063c6d56eab8ab0c1b728dd642af

tdf#150232: put Intel Iris driver Skia/Vulkan in denylist for all versions

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Julien Nabet 2022-08-06 14:32:10 UTC
Cherry-pick on 7.4 waiting for review here:
https://gerrit.libreoffice.org/c/core/+/137818
Comment 11 Commit Notification 2022-08-09 09:29:31 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/7c1bb40087dc820042cac661ea8cdf293efbbc26

tdf#150232: put Intel Iris driver Skia/Vulkan in denylist for all versions

It will be available in 7.4.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Commit Notification 2022-08-09 16:22:24 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/97f687074db5d4972af9b163047aa233f7617a42

tdf#150232: put Intel Iris driver Skia/Vulkan in denylist for all versions

It will be available in 7.3.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Buovjaga 2022-11-23 12:05:19 UTC
*** Bug 142530 has been marked as a duplicate of this bug. ***