Bug 150269 - FILEOPEN RTF Single line breaks hidden property not imported
Summary: FILEOPEN RTF Single line breaks hidden property not imported
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.3.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.5.0 target:7.4.0
Keywords:
Depends on:
Blocks: RTF-Character
  Show dependency treegraph
 
Reported: 2022-08-04 16:14 UTC by Gabor Kelemen (allotropia)
Modified: 2022-08-12 11:25 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file from Word 2016 (41.69 KB, application/msword)
2022-08-04 16:14 UTC, Gabor Kelemen (allotropia)
Details
The example file in Word 2016 and Writer 7.3 with hidden formatting marks (93.16 KB, image/png)
2022-08-04 16:15 UTC, Gabor Kelemen (allotropia)
Details
Properties of the line break in Word and Writer 7.3 (111.00 KB, image/png)
2022-08-04 16:16 UTC, Gabor Kelemen (allotropia)
Details
The example file in 7.4 bibisect at the fixing commit (210.67 KB, image/png)
2022-08-04 16:18 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2022-08-04 16:14:50 UTC
Created attachment 181594 [details]
Example file from Word 2016

The attached Word-made RTF document has some line breaks with the attribute Hidden turned on.
When opened in Word and Formatting Marks is OFF, these are not visible.
When opened in Writer and Formatting Marks is OFF, these were visible.

1, Open attached document in Word and Writer
2, Turn off the display of formatting marks (PI icon)
3, In Word the lorem ipsum starts right below the header, but in Writer it starts 3 paragraphs below it.

Version: 7.3.0.3 (x64) / LibreOffice Community
Build ID: 0f246aa12d0eee4a0f7adcefbf7c878fc2238db3
CPU threads: 14; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: threaded

This bug is already fixed in 7.4 by:

https://git.libreoffice.org/core/+/3afe4f66f7266ede9922ce0682db38c9369349b7%5E%21/#F0
author Miklos Vajna <vmiklos@collabora.com> Mon Mar 21 10:20:34 2022 +0100
committer Miklos Vajna <vmiklos@collabora.com> Mon Mar 21 11:23:32 2022 +0100

sw clearing breaks: add RTF filter

But I think this is just a side effect, and these are NOT clearing breaks.

Filing still to have unit test, just in case.
Comment 1 Gabor Kelemen (allotropia) 2022-08-04 16:15:52 UTC
Created attachment 181595 [details]
The example file in Word 2016 and Writer 7.3 with hidden formatting marks
Comment 2 Gabor Kelemen (allotropia) 2022-08-04 16:16:25 UTC
Created attachment 181596 [details]
Properties of the line break in Word and Writer 7.3
Comment 3 Gabor Kelemen (allotropia) 2022-08-04 16:18:46 UTC
Created attachment 181597 [details]
The example file in 7.4 bibisect at the fixing commit
Comment 4 Commit Notification 2022-08-10 09:14:50 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b6e177982cb6c325ca67b208b2fb8397c03ab359

tdf#150269 sw: add unit test

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2022-08-11 12:17:40 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/a0e2dd443447cdbf7558e305f2e969e5b923c5c6

tdf#150269 sw: add unit test

It will be available in 7.4.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Michael Stahl (allotropia) 2022-08-12 11:25:36 UTC
was fixed by change to forward properties with "\n" in commit 3afe4f66f7266ede9922ce0682db38c9369349b7