Bug 150339 - Wrong type for text color: Property not convertible
Summary: Wrong type for text color: Property not convertible
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.5.0.0 alpha0+
Hardware: All Linux (All)
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.6.0
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-11 04:57 UTC by BogdanB
Modified: 2023-01-05 16:05 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
The strace log (1.70 MB, application/x-bzip)
2022-08-21 04:32 UTC, BogdanB
Details

Note You need to log in before you can comment on or make changes to this bug.
Description BogdanB 2022-08-11 04:57:32 UTC
Description:
I am using a dbg version of LIbreOffice

Open Writer, write any text, select and apply any text color: I get the message: 
"warn:legacy.osl:9348:9348:svl/source/items/custritm.cxx:70: CntUnencodedStringItem::PutValue(): Wrong type
warn:sfx:9348:9348:sfx2/source/appl/appuno.cxx:310: Property not convertible: Color"

Steps to Reproduce:
1.See description


Actual Results:
warning

Expected Results:
No warning, property to be convertible


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: 641d92a73e5b3d0e062e16ed4b42236e1a4796a5
CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 1 Ezinne 2022-08-19 07:20:46 UTC
Reproducible in:

Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: a9d225df2f8772e21435523ca20df1ece37390e4
CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: pt-BR (en_NG); UI: en-US
Calc: threaded
Comment 2 BogdanB 2022-08-21 04:32:39 UTC
Created attachment 181924 [details]
The strace log

The strace log in 7.5 master
Comment 3 BogdanB 2022-12-12 20:59:36 UTC
When I open sfx2/source/appl/appuno.cxx I see a hint message in Visual Code:
"Dereference of null smart pointer 'pItem' of type 'std::unique_ptr'"

warn:legacy.osl:82145:82145:svl/source/items/custritm.cxx:70: CntUnencodedStringItem::PutValue(): Wrong type
warn:sfx:82145:82145:sfx2/source/appl/appuno.cxx:310: Property not convertible: Color

The same in
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 01c9c971e43782800ebf63acc763a7e7fba096c1
CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 4 BogdanB 2022-12-28 19:03:36 UTC
warn:legacy.osl:79938:79938:svl/source/items/custritm.cxx:70: CntUnencodedStringItem::PutValue(): Wrong type
warn:sfx:79938:79938:sfx2/source/appl/appuno.cxx:310: Property not convertible: Color

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b9e3e20bfd102880d12384892eaeca094c38a519
CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded

Caolan, could you please take a look? (I'm using a dbg version)
Linux-rpm_deb-x86_64@tb87-TDF-dbg/
Comment 5 Caolán McNamara 2022-12-29 19:42:39 UTC
https://gerrit.libreoffice.org/c/core/+/144866 might do it, but then something else presumably is using "Color" that might need to be adjusted to use "ColorString" ?
Comment 6 BogdanB 2022-12-30 05:40:35 UTC
Caolan, I get a similar warn in Calc

warn:legacy.osl:46901:46901:svl/source/items/custritm.cxx:70: CntUnencodedStringItem::PutValue(): Wrong type
warn:sfx:46901:46901:sfx2/source/appl/appuno.cxx:310: Property not convertible: Color

Should I open a new bug or they shared the same code?
Comment 7 Caolán McNamara 2022-12-30 13:11:05 UTC
I think its the same, no need to file a new one unless it persists after this one gets resolved
Comment 8 Commit Notification 2023-01-02 19:05:13 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/cc4ead451cb3b6ce6994370b3a9263756ea284d1

Resolves: tdf#150339 two arguments called "Color"

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2023-01-04 14:06:41 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/bd5cc6a50f2acdabc1c93bd49ce52c79a70c2144

Related: tdf#150339 remove SID_ATTR_COLOR_STR

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 BogdanB 2023-01-04 14:22:03 UTC
Thank you Caolan, I was waiting for this commit.
I have seen it in the open ones.
Comment 11 BogdanB 2023-01-05 16:05:43 UTC
Wroking well now. No warnings.

Verified with
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: cb4c33ef88a0ef252383e7a12678f28c4432347e
CPU threads: 4; OS: Linux 5.19; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded