Bug 150382 - FILEOPEN RTF Paragraph border from style turned off with DF is still visible
Summary: FILEOPEN RTF Paragraph border from style turned off with DF is still visible
Status: CLOSED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.4.0.3 release
Hardware: All All
: medium normal
Assignee: Michael Stahl (allotropia)
URL:
Whiteboard: target:7.5.0 target:7.4.1
Keywords:
Depends on:
Blocks: RTF-Paragraph
  Show dependency treegraph
 
Reported: 2022-08-12 11:08 UTC by Gabor Kelemen (allotropia)
Modified: 2022-10-13 08:46 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Example file from Word 2010 (33.64 KB, application/msword)
2022-08-12 11:08 UTC, Gabor Kelemen (allotropia)
Details
Screenshot of the example file in todays nightly and Word 2010 (85.53 KB, image/png)
2022-08-12 11:09 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2022-08-12 11:08:58 UTC
Created attachment 181738 [details]
Example file from Word 2010

Attached RTF document contains a custom style Bordered with 1 pt green border.
Second paragraph has this disabled with direct formatting.
Writer still displays this paragraph border, even after fixing similar bug 129758.

1, Open attached file
2, Second paragraph has the green border enabled.

First paragraph should have a green 1 pt border, the second should not.

Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: bfca51d9035000e518e4938ceb145cb92cc17b1f
CPU threads: 14; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: threaded
Comment 1 Gabor Kelemen (allotropia) 2022-08-12 11:09:37 UTC
Created attachment 181739 [details]
Screenshot of the example file in todays nightly and Word 2010
Comment 2 Gabor Kelemen (allotropia) 2022-08-12 11:21:00 UTC
Looks like this started in 4.4.
Before in 4.2 the custom paragraph style was converted to direct formatting, and this gave the correct view.
In 4.3 the custom paragraph style has started to be imported, but was incorrectly applied, so the border of the first para was turned off, and the seconds turned on.
Comment 3 Commit Notification 2022-08-15 09:15:31 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6f42a2c8631bace1caa4fac0b3ea554942f1fca3

tdf#150382 writerfilter,sw: RTF import of paragraph border override

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Michael Stahl (allotropia) 2022-08-15 09:16:22 UTC
fixed on master
Comment 5 Commit Notification 2022-08-16 12:06:41 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/c63093aad97550f7d7a6698f72956656d39ce659

tdf#150382 writerfilter,sw: RTF import of paragraph border override

It will be available in 7.4.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Gabor Kelemen (allotropia) 2022-08-18 11:45:55 UTC
Verified in

Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: c1446da82b999349e1a09fed3420bd1c38d7b38c
CPU threads: 14; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: threaded

Second paragraph has no border upon file open, as expected.
Comment 7 jackstafflast 2022-10-13 04:06:55 UTC Comment hidden (spam)