Bug 150407 - ODF: invalid attribute "writing-mode" in case ODF 1.3 strict for frame style with bottom-top left-right
Summary: ODF: invalid attribute "writing-mode" in case ODF 1.3 strict for frame style ...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.5.0.0 alpha0+
Hardware: x86-64 (AMD64) Windows (All)
: medium normal
Assignee: Regina Henschel
URL:
Whiteboard: target:7.5.0 target:7.4.1 target:7.3....
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-14 13:01 UTC by Regina Henschel
Modified: 2022-08-30 09:06 UTC (History)
0 users

See Also:
Crash report or crash signature:


Attachments
vertical position relative top or bottom margin (18.15 KB, application/zip)
2022-08-19 18:17 UTC, Regina Henschel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2022-08-14 13:01:59 UTC
1. Start a Writer document.
2. Insert a frame with some text.
3. Set the text direction of the frame to "Bottom-to-top, left-to-right (vertical)". That is in tab "Options" of the frame properties dialog.
4. Set the save option to "ODF 1.3". That is in Tools > Options > Load/Save.
5. Save the document.
6. Validate the saved file. https://odfvalidator.org/
Result: The file is not valid.

The writing mode "bt-lr" does not exist in strict ODF 1.3. and therefore the attribute should not have been written at all.
Comment 1 Regina Henschel 2022-08-19 18:17:23 UTC
Created attachment 181890 [details]
vertical position relative top or bottom margin

The same error happens with object positions relative to top or bottom margin.

The error is in https://opengrok.libreoffice.org/xref/core/xmloff/source/style/xmlexppr.cxx?r=ca2a4a4b#1059

It does not consider, that loext is only allowed in ODF extended file format. In case the document is saved in ODF strict, a product build creates an invalid file and a debug build crashes because the loext namespace is not known.
Comment 2 Commit Notification 2022-08-20 23:09:45 UTC
Regina Henschel committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/64be7052ba7e02e248412222098e07a5f4106456

tdf#150407 do not use loext in save in ODF strict

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2022-08-23 10:43:39 UTC
Regina Henschel committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/34edaf8249107c4216fdaffe450d287a1908a0de

tdf#150407 do not use loext in save in ODF strict

It will be available in 7.4.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2022-08-24 14:29:23 UTC
Regina Henschel committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/89552d1652bbe026f9572325056056b449d74716

tdf#150407 do not use loext in save in ODF strict

It will be available in 7.3.7.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2022-08-30 09:06:36 UTC
Regina Henschel committed a patch related to this issue.
It has been pushed to "libreoffice-7-3-6":

https://git.libreoffice.org/core/commit/927b6e72274fa19a6a43e95a7f93901183ee1690

tdf#150407 do not use loext in save in ODF strict

It will be available in 7.3.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.