Bug 150453 - [EDITING] Select all in formula bar only selects partially for URLs
Summary: [EDITING] Select all in formula bar only selects partially for URLs
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
3.5.0 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: preBibisect, regression
Depends on:
Blocks: Calc-Formula-Bar Hyperlink-Calc
  Show dependency treegraph
 
Reported: 2022-08-16 23:32 UTC by Faisal
Modified: 2024-12-07 18:50 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Faisal 2022-08-16 23:32:52 UTC
Description:
When there is an URL in a cell, selecting all text in the formula bar will only select n+1 characters starting from the beginning of the cell content, where n = the number of characters that is not part of the URL.

Steps to Reproduce:
1. Open a new Calc spreadsheet
2. Type "https://documentfoundation.org" (without quotes) into any cell
3. Press enter and the URL will turn blue and become hyperlinked
4. Select the cell with the URL
5. Click on the formula bar to put focus on it
6. Try to select all by pressing ctrl+A or ctrl+shift+space or right click + select all

Actual Results:
Only the first character is highlighted.

Expected Results:
The entire URL should be highlighted.


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
Further testing: If you add characters after the URL, it will select n+1 characters, where n = the number of characters that is not part of the URL.


Version: 7.3.5.2 / LibreOffice Community
Build ID: 30(Build:2)
CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-GB (en_US.UTF-8); UI: en-US
7.3.5-1
Calc: threaded
Comment 1 Faisal 2022-08-18 04:32:27 UTC
This bug is not present in Libreoffice 3.3.0 - it's a regression.
Comment 2 LeroyG 2022-08-19 00:22:04 UTC
(In reply to Faisal from comment #0)
> Steps to Reproduce:
[...]
> 4. Select the cell with the URL

Step 4 must be done with mouse, not with keyboard.

Version: 7.2.7.2 (x64) / LibreOffice Community
Build ID: 8d71d29d553c0f7dcbfa38fbfda25ee34cce99a2
CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: default; VCL: win
Locale: en-US (es_ES); UI: en-US
Calc: CL
Comment 3 Xisco Faulí 2022-08-26 14:34:28 UTC
In version

Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: aa661046b2a49dd2f3e16a118af3b45c061e08fe
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: en-US (C); UI: en-US
Calc: threaded

if I follow the following steps:

1. Open a new Calc spreadsheet
2. Type "https://documentfoundation.org" (without quotes) into any cell
3. Press enter and the URL will turn blue and become hyperlinked
4. Select the cell with the URL
5. Click on the formula bar to put focus on it
6. Try to select all by pressing ctrl+A

I can't reproduce the issue, the url is selected. However, if I add some text after the url, I reproduced the problem once.

I'm not setting this report to NEW since I the steps to reproduce it are not clear
Comment 4 Xisco Faulí 2022-08-26 14:35:44 UTC
@Faisal, could you please share the specific steps to reproduce it systematically ?
Comment 5 Renan 2022-08-26 14:47:28 UTC
I can reproduce it on Windows.

Version: 7.3.5.2 (x64) / LibreOffice Community
Build ID: 184fe81b8c8c30d8b5082578aee2fed2ea847c01
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win
Locale: pt-BR (pt_BR); UI: pt-BR
Calc: threaded
Comment 6 Xisco Faulí 2022-08-26 16:37:33 UTC
I can't reproduce it in

Version: 7.4.0.3 (x64) / LibreOffice Community
Build ID: f85e47c08ddd19c015c0114a68350214f7066f5a
CPU threads: 1; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

@Faisal, Could you please try to reproduce it in LibreOffice 7.4 from https://www.libreoffice.org/download/download-libreoffice/
Comment 7 LeroyG 2022-08-26 18:12:04 UTC
(In reply to Xisco Faulí from comment #3)
> 1. Open a new Calc spreadsheet
> 2. Type "https://documentfoundation.org" (without quotes) into any cell
> 3. Press enter and the URL will turn blue and become hyperlinked

(In reply to LeroyG from comment #2)
> > Step 4 must be done with mouse, not with keyboard.

> 4. Select the cell with the URL
> 5. Click on the formula bar [Input line] to put focus on it
> 6. Try to select all by pressing ctrl+A

Version: 7.4.0.0.alpha1 (x86) / LibreOffice Community
Build ID: b871abad383583f02eb49c7e49aeae01f6941072
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: default; VCL: win
Locale: es-MX (es_MX); UI: es-ES
Calc: threaded
Comment 8 Faisal 2022-08-29 10:29:14 UTC
@Xisco Faulí

I can still reproduce on 7.4.0.3. As noted above by LeroyG, the cell with the URl must be selected with the mouse on step 4.


Version: 7.4.0.3 (x64) / LibreOffice Community
Build ID: f85e47c08ddd19c015c0114a68350214f7066f5a
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: en-GB (en_US); UI: en-GB
Calc: CL
Comment 9 raal 2023-04-25 16:15:09 UTC
repro Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 1e273de12710eabf908495d341311da93701868f
CPU threads: 4; OS: Linux 5.19; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded

and Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a)
Comment 10 ady 2023-04-25 23:34:15 UTC
(In reply to LeroyG from comment #2)

> Step 4 must be done with mouse, not with keyboard.

The focus on the relevant cell by means of keyboard will show the url highlighted, whereas the focus by means of mouse will not. This is the reason for the steps to reproduce the problem are meant with the mouse but not with the keyboard.

Additionally, by performing the focus by mouse, we can select part of the content of the cell, whereas focusing on the cell by keyboard we can see the complete content highlighted and it is not clear how to select only part of it.

I wonder whether this is (at least in part) a UX issue.
Comment 11 Stéphane Guillou (stragu) 2023-10-19 20:19:50 UTC
Difficulty in reproducing is likely because of the "cycling" in link formatting in the formula bar, which is described in bug 103447.

When the formula bar formats the hyperlink in blue, Ctrl + A works.
When the formula bar formats the whole cell content as plain text, Ctrl + A misbehaves work.

I'd say both issues would likely be fixed together.

Reproduced in:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b83f069101f1e6d8aaac09a805f02bbc4c619e7a
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 12 Stéphane Guillou (stragu) 2023-10-19 20:25:45 UTC
Repro in:

LibreOffice 3.5.0rc3 
Build ID: 7e68ba2-a744ebf-1f241b7-c506db1-7d53735

No repro in libreoffice-3.4.6rc2. Back then, clicking in formula bar would always format its contents as a hyperlink, and Ctrl + A would work as expected.
Likely the same cause as bug 103447.
Comment 13 Eric Rodriguez 2024-12-06 22:16:58 UTC
I was able to reproduce this issue several times while bisecting, this was the results from bisecting:
 3b3049c0a9c86c02e68a04be163cf7f8ab9c6895 is the first bad commit
commit 3b3049c0a9c86c02e68a04be163cf7f8ab9c6895 (HEAD)
Author: Norbert Thiebaud <nthiebaud@gmail.com>
Date:   Tue Apr 17 05:34:14 2018 -0700

    source a860c94f0da22065074cc36e8ddda73261641533

    source a860c94f0da22065074cc36e8ddda73261641533

 instdir/program/sclo.dll    | Bin 15659520 -> 15659520 bytes
 instdir/program/version.ini |   2 +-
 2 files changed, 1 insertion(+), 1 deletion(-)
Comment 14 Eric Rodriguez 2024-12-06 23:36:05 UTC
Version: 6.1.0.0.alpha0+
Build ID: d15ff312ad80e4d1f210636e3374a81c14c229a2
CPU threads: 8; OS: Windows 10.0; UI render: GL; 
Locale: en-US (en_US); Calc: CL
Comment 15 raal 2024-12-07 07:39:42 UTC
(In reply to Eric Rodriguez from comment #13)
> I was able to reproduce this issue several times while bisecting, this was
> the results from bisecting:
>  3b3049c0a9c86c02e68a04be163cf7f8ab9c6895 is the first bad commit
> commit 3b3049c0a9c86c02e68a04be163cf7f8ab9c6895 (HEAD)
> Author: Norbert Thiebaud <nthiebaud@gmail.com>
> Date:   Tue Apr 17 05:34:14 2018 -0700
> 
>     source a860c94f0da22065074cc36e8ddda73261641533
> 
>     source a860c94f0da22065074cc36e8ddda73261641533
> 
>  instdir/program/sclo.dll    | Bin 15659520 -> 15659520 bytes
>  instdir/program/version.ini |   2 +-
>  2 files changed, 1 insertion(+), 1 deletion(-)

CC 	Maxim Monastirsky
Comment 16 Buovjaga 2024-12-07 18:21:16 UTC
(In reply to raal from comment #15)
> (In reply to Eric Rodriguez from comment #13)
> > I was able to reproduce this issue several times while bisecting, this was
> > the results from bisecting:
> >  3b3049c0a9c86c02e68a04be163cf7f8ab9c6895 is the first bad commit
> > commit 3b3049c0a9c86c02e68a04be163cf7f8ab9c6895 (HEAD)
> > Author: Norbert Thiebaud <nthiebaud@gmail.com>
> > Date:   Tue Apr 17 05:34:14 2018 -0700
> > 
> >     source a860c94f0da22065074cc36e8ddda73261641533
> > 
> >     source a860c94f0da22065074cc36e8ddda73261641533
> > 
> >  instdir/program/sclo.dll    | Bin 15659520 -> 15659520 bytes
> >  instdir/program/version.ini |   2 +-
> >  2 files changed, 1 insertion(+), 1 deletion(-)
> 
> CC 	Maxim Monastirsky

Incorrect result (Maxim's change in 6.1 is about Alt key) and incorrect keywords left back in 2023. If this reproduces in 3.5, no need to keep a bibisectRequest.
Comment 17 Buovjaga 2024-12-07 18:50:50 UTC
(In reply to Buovjaga from comment #16)
> (In reply to raal from comment #15)
> > (In reply to Eric Rodriguez from comment #13)
> > > I was able to reproduce this issue several times while bisecting, this was
> > > the results from bisecting:
> > >  3b3049c0a9c86c02e68a04be163cf7f8ab9c6895 is the first bad commit
> > > commit 3b3049c0a9c86c02e68a04be163cf7f8ab9c6895 (HEAD)
> > > Author: Norbert Thiebaud <nthiebaud@gmail.com>
> > > Date:   Tue Apr 17 05:34:14 2018 -0700
> > > 
> > >     source a860c94f0da22065074cc36e8ddda73261641533
> > > 
> > >     source a860c94f0da22065074cc36e8ddda73261641533
> > > 
> > >  instdir/program/sclo.dll    | Bin 15659520 -> 15659520 bytes
> > >  instdir/program/version.ini |   2 +-
> > >  2 files changed, 1 insertion(+), 1 deletion(-)
> > 
> > CC 	Maxim Monastirsky
> 
> Incorrect result (Maxim's change in 6.1 is about Alt key) and incorrect
> keywords left back in 2023. If this reproduces in 3.5, no need to keep a
> bibisectRequest.

A brief explanation as to why that result might have seemed meaningful: apparently the issue that Maxim fixed did affect reproducing this selection bug. So it masked the bug. Bug 117017 has 5.4 as its version and indeed in the oldest of Linux 5.4 repo I get the selection bug with only the first letter selected, but inbetween the whole formula is selected and the link formatting is completely removed.