Description: Every time I open Draw it shows "Slide 1 of 1" in the bottom status bar when it shouldn't be "Page 1 of 1" like in Writer? Steps to Reproduce: 1.Open LO Draw 2. 3. Actual Results: Display "Slide 1 of 1" Expected Results: Display "Page 1 of x" or "Drawing 1 of x" Reproducible: Always User Profile Reset: No Additional Info: LibreOffice 7.4.x in Windows 10, hardware acceleration is enabled
Created attachment 181868 [details] Attachment of the bottom bar Screenshot of the bug
I don't see the pb here: - for a presentation software, I expect "Slide" - for a word processing software, I expect "Page"
Yes but in the spanish version of LibreOffice, in LO Draw, I see "Diapositiva 1 de 1"
(In reply to robomurphy98 from comment #3) > Yes but in the spanish version of LibreOffice, in LO Draw, I see > "Diapositiva 1 de 1" "Diapositiva" is the Spanish translation of "Slide" so we can expect this word in Draw or Impress when using Spanish language. For Writer, you'll find "Página" so the Spanish translation of "Page". I still don't see the pb here.
In Impress slide is used ok, but in Draw they are pages not slides so it makes no sense to put it there
LibreOffice Draw manages pages such diagrams etc but Impress other type (slides)
(In reply to robomurphy98 from comment #5) > In Impress slide is used ok, but in Draw they are pages not slides so it > makes no sense to put it there Ok I understand better, in Impress you got a menu "Slide" then for example "New Slide" whereas in Draw, there's a Page menu with "New Page" for example. So indeed, we may expect "Page 1 of 1" in Draw specifically (compared to Impress).
Yes, both in the menu and in the panel are changed but in the bottom bar it still says "Slide 1 of 1"
We have STR_SD_PAGE_COUNT and STR_SD_PAGE_COUNT_CUSTOM (shown when slides are hidden; not available in Draw, CMIIW). The implementation of the one or two new strings could follow STR_UNDO_DELETEPAGES/STR_UNDO_DELETEPAGES_DRAW in SelectionManager::DeleteSelectedPages() as done for bug 114175. It might be needed at SlotManager::GetStatusBarState(), DrawViewShell::GetStatusBarState(), and OutlineViewShell::GetStatusBarState() (that's at least where the strings are used).
Sorry, I didn't see CPP needed for this bug. I will set this as new again.
Start working on this.
Baole Fang committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/487010ef62405a1a728ae9b3d838e934015b1719 tdf#150477: Change "Slide" to "Page" in Draw status bar It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Thank you so much Baole! I don't see the patch in the daily build.
(In reply to robomurphy98 from comment #13) > Thank you so much Baole! I don't see the patch in the daily build. There was no new Windows master build last night, there must be some problem with the box.
It's page now. Thanks. Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 127eacf630e1712fd5addcabed404b2d33752311 CPU threads: 16; OS: Linux 5.19; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded
At the moment I do not see the version for Windows, it keeps appearing "slide". The build ID is fc6806c4be8585ce0d35a6b581bf8b3dbf858500 (Windows X86_64) with the date "2023-Apr-11 03:21".
(In reply to robomurphy98 from comment #16) > At the moment I do not see the version for Windows, it keeps appearing > "slide". The build ID is fc6806c4be8585ce0d35a6b581bf8b3dbf858500 (Windows > X86_64) with the date "2023-Apr-11 03:21". According to https://git.libreoffice.org/core/+/487010ef62405a1a728ae9b3d838e934015b1719%5E%21 the fix was pushed at: Tue Apr 11 15:24:43 2023 +0200 whereas the build id you got is updated until fc6806c4be8585ce0d35a6b581bf8b3dbf858500. It corresponds to https://git.libreoffice.org/core/+/fc6806c4be8585ce0d35a6b581bf8b3dbf858500%5E%21 commit was at: Mon Apr 10 23:59:28 2023 +0200 In brief, you must just wait for the next daily build, it should be ok.
(In reply to Julien Nabet from comment #17) > (In reply to robomurphy98 from comment #16) > > At the moment I do not see the version for Windows, it keeps appearing > > "slide". The build ID is fc6806c4be8585ce0d35a6b581bf8b3dbf858500 (Windows > > X86_64) with the date "2023-Apr-11 03:21". > > According to > https://git.libreoffice.org/core/+/ > 487010ef62405a1a728ae9b3d838e934015b1719%5E%21 > the fix was pushed at: > Tue Apr 11 15:24:43 2023 +0200 > > whereas the build id you got is updated until > fc6806c4be8585ce0d35a6b581bf8b3dbf858500. > It corresponds to > https://git.libreoffice.org/core/+/ > fc6806c4be8585ce0d35a6b581bf8b3dbf858500%5E%21 > commit was at: > Mon Apr 10 23:59:28 2023 +0200 > > In brief, you must just wait for the next daily build, it should be ok. Perfect, okay then I hope and thank you very much for the work! If I find more bugs in Draw I will report them.
Created attachment 186673 [details] Capture of the string now
I just installed the new daily version and I already see "Page 1 of 1", although it would still need to be translated for all languages, so it should be "Page 1 of 1" in the Spanish version, but hey, thanks for the work.
(In reply to robomurphy98 from comment #20) > I just installed the new daily version and I already see "Page 1 of 1", > although it would still need to be translated for all languages, so it > should be "Page 1 of 1" in the Spanish version, but hey, thanks for the work. It'll require a bit of time: - delay Weblate retrieves the change of the English string - delay translators translate the string - delay to synchronize Weblate to translation repo - delay of a new release with translation repo up-to-date and the first one isn't done yet, compare: https://translations.documentfoundation.org/languages/es/libo_ui-master/search/?offset=1&q=STR_SD_PAGE_COUNT&sort_by=-priority%2Cposition&checksum= and https://translations.documentfoundation.org/languages/es/libo_ui-master/search/?offset=1&q=STR_SD_PAGE_COUNT_DRAW&sort_by=-priority%2Cposition&checksum=
(In reply to Julien Nabet from comment #21) > (In reply to robomurphy98 from comment #20) > > I just installed the new daily version and I already see "Page 1 of 1", > > although it would still need to be translated for all languages, so it > > should be "Page 1 of 1" in the Spanish version, but hey, thanks for the work. > > It'll require a bit of time: > - delay Weblate retrieves the change of the English string > - delay translators translate the string > - delay to synchronize Weblate to translation repo > - delay of a new release with translation repo up-to-date > and the first one isn't done yet, compare: > https://translations.documentfoundation.org/languages/es/libo_ui-master/ > search/?offset=1&q=STR_SD_PAGE_COUNT&sort_by=-priority%2Cposition&checksum= > and > https://translations.documentfoundation.org/languages/es/libo_ui-master/ > search/?offset=1&q=STR_SD_PAGE_COUNT_DRAW&sort_by=- > priority%2Cposition&checksum= I understand it takes time but well, for the moment thanks for all the work. I'll wait for version 7.6 to see it hehe :)