Description: Undo of table in columns adds multiple additional pages Steps to Reproduce: 1. Open the attached file 2. Scroll to page 8 (Tabella1 in Navigator) 3. Delete the table (delete table button) 4. CTRL+Z Actual Results: Multiple additional pages/ distorted table layout Expected Results: Same as before undo Reproducible: Always User Profile Reset: No Additional Info: Found in Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 1c1647e6ee252fe68d7406d01043e88f1721590f CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL Still fine in Version: 7.1.8.0.0+ (x64) / LibreOffice Community Build ID: a94b58277c7aeaa83ce14347cd0b8f7137969d03 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL
Created attachment 182018 [details] Example file
I confirm it with Version: 7.4.0.3 (x64) / LibreOffice Community Build ID: f85e47c08ddd19c015c0114a68350214f7066f5a CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL Might be document related. Telesto, could you reproduce the problem with some more general steps? => NEEDINFO
Well it seems far easier to do a bibisect and having some commit as reference, compared to blind search for the cause.. The source file comes from the bug tracker: attachment 182008 [details]
NOT REPRODUCED Steps to Reproduce: 1. Open the attached file 2. Scroll to page 8 (Tabella1 in Navigator) 3. Delete the table (delete table button) 4. CTRL+Z ENVIRONMENT: Libreoffice 7.4.0.0.alpha0 linux mint 20.3
Actual Results: Multiple additional pages/ distorted table layout Expected Results: Same as before undo Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 465c3ad95059f0efa13c8027f7383c4d20a5b2ff CPU threads: 2; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: en-IN (en_IN); UI: en-US Calc: threaded REPRODUSE
bibisect-linux-64-6.2 - oldest - bug is not here bibisect-linux-64-6.2- master - crash when ctrl+z bibisect-linux-64-6.3 - oldest - crash when ctrl+z bibisect-linux-64-6.4 oldest - bug is here
Can't reproduce on Ubuntu 20.04: Version: 7.5.0.1 (X86_64) / LibreOffice Community Build ID: 77cd3d7ad4445740a0c6cf977992dafd8ebad8df CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Version: 7.4.4.2 / LibreOffice Community Build ID: 85569322deea74ec9134968a29af2df5663baa21 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Version: 7.3.7.2 / LibreOffice Community Build ID: e114eadc50a9ff8d8c8a0567d6da8f454beeb84f CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded But I can reproduce on Windows 10: Version: 7.5.0.1 (X86_64) / LibreOffice Community Build ID: 77cd3d7ad4445740a0c6cf977992dafd8ebad8df CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: en-GB (en_GB); UI: en-GB Calc: threaded Vengatesh, are you sure you were able to see the completely different table and many extra blank pages after undoing on Linux? To me, it looks like a Windows-only issue.
I marked comment 4 and comment 5 as obsolete, and also I marked this as a Windows specific.
at this commit ctrl+z stopped working, nothing happens after ctrl+z 203f805ec2622f0dcd6c871a6efc5af848b08e72 is the first bad commit commit 203f805ec2622f0dcd6c871a6efc5af848b08e72 Author: Norbert Thiebaud <nthiebaud@gmail.com> Date: Wed Sep 19 15:46:34 2018 -0700 source 723728cd358693b8f4bc9d913541aa4479f2bd48 https://git.libreoffice.org/core/+/723728cd358693b8f4bc9d913541aa4479f2bd48 at this commit ctrl+z started working again, but with broken layout as described in bug. 94e9a9c925c8b9d2404c61785b28935dfba5d3ec is the first bad commit commit 94e9a9c925c8b9d2404c61785b28935dfba5d3ec Author: Norbert Thiebaud <nthiebaud@gmail.com> Date: Fri Nov 16 03:34:48 2018 -0800 source 68880a3004623553bf1920ad8a4a4d2be4bca234 https://git.libreoffice.org/core/+/68880a3004623553bf1920ad8a4a4d2be4bca234
the problem appears to be this code in CalcContent prevents table from going to previous page or column: if ( static_cast<SwTabFrame*>(pFrame)->IsFollow() && ( !pSect || pSect == pFrame->FindSctFrame() ) ) { static_cast<SwTabFrame*>(pFrame)->m_bLockBackMove = true; }
Michael Stahl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/59987d3c77ec7dbf59fbea9f47cc226f4e8903f9 tdf#150606 sw: layout: leave follow SwTabFrame invalid in columns It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
fixed on master
Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-7-5": https://git.libreoffice.org/core/commit/560b94971b656914d17c9d1befdad2dbd3f1119a tdf#150606 sw: layout: leave follow SwTabFrame invalid in columns It will be available in 7.5.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Stahl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a9b19f78f3cdcbf5c949a85b45877e903114cc54 tdf#156551 tdf#150606 sw: layout: only invalidate SwTabFrame if it... It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-7-6": https://git.libreoffice.org/core/commit/1808306db7bec6cd668b5840eb8a0121ee89991f tdf#156551 tdf#150606 sw: layout: only invalidate SwTabFrame if it... It will be available in 7.6.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Stahl committed a patch related to this issue. It has been pushed to "libreoffice-7-5": https://git.libreoffice.org/core/commit/0bd916a78dc9e586d78dffdf57e6fa80b955eef6 tdf#156551 tdf#150606 sw: layout: only invalidate SwTabFrame if it... It will be available in 7.5.6. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
To NEEDINFO as of Comment #7 https://fun-games.io
closing to prevent more spam