Created attachment 182055 [details] test.ods Steps to Reproduce: 1. Open the attached test ods file. Observe that there are 7581 records. (Note that the non empty items in column E are prefixed with several spaces.) 2. Click on the autofilter dropdown in column E named "Cashflow Item", make the item named "(Empty)" unchecked (i.e. all other non-empty items are checked), then click OK. --> Good, there are 47 non-empty records. 3. Click on the autofilter dropdown in column E again, make the item named "(Empty") checked (i.e., all other non-empty items are not checked). Current Result: None records are shown in step 3. Expected: There are 7581 - 47 = 7534 records are empty in column E, thus 7534 records should show up in step 3. It works OK if you filter in column B. Version: 7.3.6.1 / LibreOffice Community Build ID: 92b673af3a5e8f7cf4716be88dfaca424612f244 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: zh-CN (zh_CN.UTF-8); UI: zh-CN Calc: threaded
Bibisected to the following range which covers 3 commits: 7d730cd58..938c89983 in which the following seems related: commit 938c899831bd5b165b2b7db3945867a1ce155483 Author: Xisco Fauli <xiscofauli@libreoffice.org> Date: Wed Aug 17 12:59:51 2022 +0200 tdf#150452: Revert "tdf#130795 use concurrent hashmap in SharedStringPool" Adding cc to Xisco Fauli: any idea? I don't think we should do a "revert revert".
Reproduced with: Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: 24087697d5cf78aac346d4dcea0596373e15a95c CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded
Hi Kevin, Thanks for the bisection. This is a bit weird since my commit just revert a patch. I expected the regression to be reproducible before 3749d9af3745c0eaff7239e379578e4e2af89e9d ( the commit I reverted ? but it's not the case. Investigating
Also reproduced in Version: 7.3.7.0.0+ / LibreOffice Community Build ID: d0312786571221c2dd4f63fa69f6f0489d7d39ec CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: es-ES (es_ES.UTF-8); UI: en-US Calc: threaded
I moved my branch to libreoffice-7-3, specifically to commit 20f35b9e185d501398619a615a3ebbb44db1b2a5, applied the revert and retested. The issue is already reproducible there
an update on this, I'm bisecting it manually building LibreOffice on every step reverting 938c899831bd5b165b2b7db3945867a1ce155483 and the commit introduced the issue is in this range: https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=899e8f813c559384ba11eb1d4ceafaf29b5e73a9..3d09becf194bf1702a389ee59a7d6df899a570dd. 6 steps to go...
Regression introduced by author Luboš Luňák <l.lunak@collabora.com> 2021-11-23 21:15:23 +0100 committer Luboš Luňák <l.lunak@collabora.com> 2021-11-23 22:41:28 +0100 commit 990d32dad6bdf5d92a14d8bc02ae2853facd9097 (patch) tree b049c19cf6664ba7960c8ed522031a577353d8b6 parent 758ff97066652fbdd960121d42e659d3ab90e7d4 (diff) allow matching of empty cells as svl::SharedString (tdf#133804) This may speed up some lookups. when 938c899831bd5b165b2b7db3945867a1ce155483 is not in place @Luboš, I'm wondering whether we should just revert that patch now ?
Adjusting the version field to 7.3 accordingly as this also affects 7.3 branch.
Luboš Luňák committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e47e0cb0ad1dc3554e9b57f8562a217cf785edbf make sure SharedString::EMPTY_STRING is interned in pools (tdf#150647) It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Luboš Luňák committed a patch related to this issue. It has been pushed to "libreoffice-7-4": https://git.libreoffice.org/core/commit/15d1660ef04492bfffe4fd30d7c1942499d44f0c make sure SharedString::EMPTY_STRING is interned in pools (tdf#150647) It will be available in 7.4.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Luboš Luňák committed a patch related to this issue. It has been pushed to "libreoffice-7-3": https://git.libreoffice.org/core/commit/66ebf61975a5d8d860eda5e661c5a82a9ca763b7 make sure SharedString::EMPTY_STRING is interned in pools (tdf#150647) It will be available in 7.3.7. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Verified in Version: 7.4.3.0.0+ / LibreOffice Community Build ID: 403ff3d3ccba1498568e82e4840a12e53a188406 CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: es-ES (es_ES.UTF-8); UI: en-US Calc: threaded I guess we can close it as VERIFIED FIXED
Thanks Lubos for fixing this issue!!
Luboš Luňák committed a patch related to this issue. It has been pushed to "libreoffice-7-4-2": https://git.libreoffice.org/core/commit/97715aacd8aa32bbd0fd4e0a3fa0bdb8e7fbeaa5 make sure SharedString::EMPTY_STRING is interned in pools (tdf#150647) It will be available in 7.4.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.