Bug 150695 - The string "IgnoreAll" is probably wrong
Summary: The string "IgnoreAll" is probably wrong
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.4.0.3 release
Hardware: All All
: medium trivial
Assignee: Julien Nabet
URL:
Whiteboard: target:24.8.0 target:24.2.0.0.beta2
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-30 18:00 UTC by Tuomas Hietala
Modified: 2023-12-17 11:00 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tuomas Hietala 2022-08-30 18:00:29 UTC
Description:
There is a UI string "IgnoreAll" in LO:
https://translations.documentfoundation.org/translate/libo_ui-master/officecfgregistrydataorgopenofficeofficeui/en/?checksum=32977a3c20b3a179

It should probably be something else, like "Ignore All" (with a space).

Steps to Reproduce:
1. Go to https://translations.documentfoundation.org/translate/libo_ui-master/officecfgregistrydataorgopenofficeofficeui/en/?checksum=32977a3c20b3a179


Actual Results:
The string is "IgnoreAll".

Expected Results:
"Ignore All", probably.


Reproducible: Always


User Profile Reset: No



Additional Info:
n/a
Comment 1 Rafael Lima 2022-08-31 13:19:57 UTC
Code pointer is:
https://opengrok.libreoffice.org/xref/core/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu?r=64b5eb22#2708

Indeed I think it should be "Ignore All", since it is a label value. However, I could not find where it appears in the UI.
Comment 2 Julien Nabet 2023-12-16 21:48:34 UTC
(In reply to Rafael Lima from comment #1)
> Code pointer is:
> https://opengrok.libreoffice.org/xref/core/officecfg/registry/data/org/
> openoffice/Office/UI/GenericCommands.xcu?r=64b5eb22#2708
> 
> Indeed I think it should be "Ignore All", since it is a label value.
> However, I could not find where it appears in the UI.

Taking a look, I see:
2742       <node oor:name=".uno:SpellCheckIgnoreAll" oor:op="replace">
2743         <prop oor:name="Label" oor:type="xs:string">
2744           <value xml:lang="en-US">IgnoreAll</value>

git grep -n SpellCheckIgnoreAll gives:
officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu:2742:      <node oor:name=".uno:SpellCheckIgnoreAll" oor:op="replace">
svx/sdi/svx.sdi:12494:SfxVoidItem SpellCheckIgnoreAll SID_SPELLCHECK_IGNORE_ALL
sw/source/uibase/lingu/olmenu.cxx:578:        m_xPopupMenu->SetItemCommand(m_nIgnoreWordId, ".uno:SpellCheckIgnoreAll?Type:string=Grammar");
sw/source/uibase/lingu/olmenu.cxx:580:        m_xPopupMenu->SetItemCommand(m_nIgnoreWordId, ".uno:SpellCheckIgnoreAll?Type:string=Spelling");

For editeng/source/editeng/editview.cxx
   920 static void LOKSendSpellPopupMenu(const weld::Menu& rMenu, LanguageType nGuessLangWord,
    921                                   LanguageType nGuessLangPara, sal_uInt16 nSuggestions)
    922 {   
    923     if (!comphelper::LibreOfficeKit::isActive())
    924         return;

for those in sw/source/uibase/lingu/olmenu.cxx:
    569 void SwSpellPopup::InitItemCommands(const css::uno::Sequence< OUString >& aSuggestions)
    570 {
    571     if (!comphelper::LibreOfficeKit::isActive())
    572         return;
    573 
    574     // None is added only for LOK, it means there is no need to execute anything
    575     m_xPopupMenu->SetItemCommand(MN_SHORT_COMMENT, ".uno:None");
    576     m_xPopupMenu->SetItemCommand(m_nSpellDialogId, ".uno:SpellingAndGrammarDialog");
    577     if(m_bGrammarResults)
    578         m_xPopupMenu->SetItemCommand(m_nIgnoreWordId, ".uno:SpellCheckIgnoreAll?Type:string=Grammar");
    579     else
    580         m_xPopupMenu->SetItemCommand(m_nIgnoreWordId, ".uno:SpellCheckIgnoreAll?Type:string=Spelling");

so it seems it only appears with LOKit

Anyway, I've submitted a patch here:
https://gerrit.libreoffice.org/c/core/+/160877

Tamás: put you in cc since I noticed 6564a1ab1e873cbc9e36f7f301d4a3c14d86861e
SpellingPopup: Create separate SID for Ignore / IgnoreAll / suggestion.
Comment 3 Commit Notification 2023-12-17 10:11:36 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/32b437559abcf7582f113dcb5c87f1a2dd2ba3ac

tdf#150695: The string "IgnoreAll" is probably wrong

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Julien Nabet 2023-12-17 10:14:30 UTC
Here's the patch for 24.2 waiting just Jenkins validation:
https://gerrit.libreoffice.org/c/core/+/160859
Comment 5 Commit Notification 2023-12-17 11:00:43 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/e91d0caeb408231c43cc3cc3cad2440efafd96ed

tdf#150695: The string "IgnoreAll" is probably wrong

It will be available in 24.2.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.