Bug 150729 - Daily build produces character style "__XXX___invalid"
Summary: Daily build produces character style "__XXX___invalid"
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.5.0.0 alpha0+
Hardware: x86-64 (AMD64) All
: low minor
Assignee: Not Assigned
URL:
Whiteboard: target:7.5.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2022-08-31 17:57 UTC by Regina Henschel
Modified: 2023-05-23 13:26 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
File to reprocude the error (11.04 KB, application/vnd.oasis.opendocument.text)
2022-08-31 17:57 UTC, Regina Henschel
Details
File made in LO7.3 (10.61 KB, application/vnd.oasis.opendocument.text)
2022-09-05 13:53 UTC, Regina Henschel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2022-08-31 17:57:47 UTC
Created attachment 182123 [details]
File to reprocude the error

Open attached document in a current daily build and save it without any changes. Inspect the styles.xml. You will find a character style "__XXX___invalid".

I see the error in Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: d05c176cc022f1b771f7c064f6ce74e9f8c27a1b
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

There was no error in Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 4e2ce2a460458f17ee4360c45a2da2fc4b4d753e
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: de-DE (en_US); UI: en-US
Calc: CL
Comment 1 m_a_riosv 2022-08-31 21:39:57 UTC
Reproducible
Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 4c96abd81460977d413d4d28e891bbbac5769ede
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL
Comment 2 Julien Nabet 2022-09-01 10:57:45 UTC
On pc Debian x86-64 with master sources updated today, I could reproduce this.

I noticed this on console during saving:
warn:legacy.osl:60939:60939:xmloff/source/style/xmlexppr.cxx:907: no prop type specified
warn:legacy.osl:60939:60939:xmloff/source/style/xmlexppr.cxx:907: no prop type specified
warn:legacy.osl:60939:60939:xmloff/source/style/xmlexppr.cxx:907: no prop type specified
warn:legacy.osl:60939:60939:xmloff/source/style/xmlexppr.cxx:907: no prop type specified
warn:legacy.osl:60939:60939:xmloff/source/text/txtparae.cxx:388: hyperlink without a URL --> no export to ODF
Comment 3 Timur 2022-09-03 09:13:40 UTC Comment hidden (obsolete)
Comment 4 phv 2022-09-03 11:15:11 UTC
In my case (bug report #149547), I was able to trace the error to the chapter numbering; "None" character style is not correctly restored when opening a document in LibreOfficeDev version exclusively and "__XXX___invalid" then replaces the default one.

I prefer to be sure that both bugs have the same origin before marking the reports as duplicates.
Comment 5 Timur 2022-09-05 12:30:31 UTC
Please clarify how this is a regression. 
on file open I already see character style "__XXX___invalid".
So it stays on save, also in earlier LO.
Seems a duplicate to bug 149547.
Comment 6 Regina Henschel 2022-09-05 13:53:59 UTC
Created attachment 182226 [details]
File made in LO7.3

The file was indeed wrong, attached is a new file.

The error happens already in file open.
Comment 7 Regina Henschel 2022-09-05 14:00:50 UTC
Inspect the markup of the attached file. It does not contain any __XXX___invalid.

I consider it a regression because Version: 7.3.2.2 (x64) / LibreOffice Community
Build ID: 49f2b1bff42cfccbd8f788c8dc32c1c309559be0
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: de-DE (en_US); UI: en-US
Calc: CL
does not have this error.

I have not manipulated any character style nor uses lists. So as long as it is not known, that it has the same reason as the other report, I would not set it as duplicate.
Comment 8 Timur 2022-09-05 15:04:58 UTC
I reproduce now.
Comment 9 Timur 2022-09-06 08:59:49 UTC
author	Justin Luth <jluth@mail.com>	2022-05-21 
committer	Justin Luth <jluth@mail.com>	2022-06-10 
commit 758945b077220fe151c1565c6d5b0bad02de6d58 (patch)
tdf#75297 sw uno: override default num char style when NONE
The problem was during ODT import. When no text:style-name
is provided, or if it is an empty string, then the default
"Numbering symbols" character style remained active,
preventing the ability to round-trip a NONE char style.

CC Justin. Please check.
Comment 10 Justin L 2022-09-07 14:49:48 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c24fe44064c6624fefe642508086c8562c372fba

tdf#149547 fix "tdf#75297 sw uno: override default num char style"

It will be available in 7.5.0.