Bug 150754 - GtkCheckMenuItem shows no check mark on macOS (GtkRadioMenuItem does)
Summary: GtkCheckMenuItem shows no check mark on macOS (GtkRadioMenuItem does)
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.4.0.3 release
Hardware: x86-64 (AMD64) macOS (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: macOS-UI-polish UI-Theming
  Show dependency treegraph
 
Reported: 2022-09-02 10:54 UTC by yuriy.tsalyy
Modified: 2024-09-05 03:17 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Expected vs actual visualisation (52.92 KB, image/jpeg)
2022-09-02 12:19 UTC, yuriy.tsalyy
Details
Correct on my machine (8.18 KB, image/png)
2022-09-02 12:37 UTC, jcsanz
Details

Note You need to log in before you can comment on or make changes to this bug.
Description yuriy.tsalyy 2022-09-02 10:54:19 UTC
Description:
When table is opened in Design View right-click on any row header brings up a context menu with "Primary Key" as the last row. According to Base Guide 7.3 (Fig.26 on page 34 in PDF version) "Primary Key" should have a checkmark if click on head of the primary key row, but the "Primary Key" status is not showing in the context menu.

Steps to Reproduce:
1.Open any table in Design View
2.Right-click on the Primary Key row header
3.Right-click on any other row header


Actual Results:
The context menu looks exactly the same for any row header

Expected Results:
The Primary Key status should be indicated in context menu when right-clicking on the Primary Key row header as it is showed in the PDF version of Base Guide 7.3, page 34, Fig.26.


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
Version: 7.4.0.3 / LibreOffice Community
Build ID: f85e47c08ddd19c015c0114a68350214f7066f5a
CPU threads: 4; OS: Mac OS X 12.5; UI render: default; VCL: osx
Locale: cs-CZ (en_GB.UTF-8); UI: en-US
Calc: threaded
Comment 1 yuriy.tsalyy 2022-09-02 12:19:42 UTC
Created attachment 182175 [details]
Expected vs actual visualisation

The picture clearly shows the difference between expected and actual results.
Comment 2 jcsanz 2022-09-02 12:37:37 UTC
Created attachment 182177 [details]
Correct on my machine

It is correct in my machine

Version: 7.4.0.3 (x64) / LibreOffice Community
Build ID: f85e47c08ddd19c015c0114a68350214f7066f5a
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: es-ES
Calc: CL
Comment 3 Alex Thurgood 2022-09-02 12:59:43 UTC
Confirming, and already present in

Version: 7.3.5.2 / LibreOffice Community
Build ID: 184fe81b8c8c30d8b5082578aee2fed2ea847c01
CPU threads: 8; OS: Mac OS X 12.5.1; UI render: default; VCL: osx
Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR
Calc: threaded

@Heiko : thoughts ?
Comment 4 Alex Thurgood 2022-09-02 13:03:47 UTC
FWIW, I can reproduce all the way back to 

Version: 7.1.8.1 / LibreOffice Community
Build ID: e1f30c802c3269a1d052614453f260e49458c82c
CPU threads: 8; OS: Mac OS X 10.16; UI render: default; VCL: osx
Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR
Calc: threaded

I no longer have anything older than 7.1.5.2 to see if it goes back even further.
Comment 5 yuriy.tsalyy 2022-09-03 11:35:39 UTC
(In reply to Alex Thurgood from comment #3)
> Confirming, and already present in
> 
> Version: 7.3.5.2 / LibreOffice Community
> Build ID: 184fe81b8c8c30d8b5082578aee2fed2ea847c01
> CPU threads: 8; OS: Mac OS X 12.5.1; UI render: default; VCL: osx
> Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR
> Calc: threaded
> 
> @Heiko : thoughts ?

I was trying to reproduce the error in the Windows Libreoffice installation and Primary Key has checkmark if it's the PM row, but the context menu for right-click on non-PM rows does not have ""Primary Key"at all. Feature request? 

Version: 7.4.0.3 (x86) / LibreOffice Community
Build ID: f85e47c08ddd19c015c0114a68350214f7066f5a
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: cs-CZ (cs_CZ); UI: en-GB
Calc: threaded
Comment 6 Alex Thurgood 2022-09-04 10:22:09 UTC
(In reply to yuriy.tsalyy from comment #5)
> (In reply to Alex Thurgood from comment #3)

> I was trying to reproduce the error in the Windows Libreoffice installation
> and Primary Key has checkmark if it's the PM row, but the context menu for
> right-click on non-PM rows does not have ""Primary Key"at all. Feature
> request? 
> 


For me, that would be a separate issue.
The current behavior should show a tick mark in the context menu when displayed against the PK defined field, and it doesn't on the macOS version. Whether this is a missing icon or some other bug remains to be determined, e.g. whether it is because the context menu takes a default display which is icon-less.
Comment 7 Heiko Tietze 2022-09-05 07:31:49 UTC
The "primarykey" menu item is added as GtkCheckMenuItem in dbaccess/uiconfig/ui/tabledesignrowmenu.ui. We use these kind of menu buttons on various places, for example "Preview" in the Gallery at the sidebar - not working. The Navigator in Writer has "Drag Mode > Insert as..." showing a check mark, but in this case it's a GtkRadioMenuItem.
Comment 8 QA Administrators 2024-09-05 03:17:41 UTC
Dear yuriy.tsalyy,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug