Bug 150770 - FILEOPEN: PPtX: Read error - Error reading file
Summary: FILEOPEN: PPtX: Read error - Error reading file
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.4.0.3 release
Hardware: All All
: high normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.4.2 target:7.5.0 target:7.4.1
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2022-09-04 01:40 UTC by Yarko
Modified: 2022-09-09 17:16 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Sample PPSX (5.80 MB, application/vnd.openxmlformats-officedocument.presentationml.slideshow)
2022-09-08 07:06 UTC, Timur
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yarko 2022-09-04 01:40:19 UTC
A pptx file with autoplay, transitions which opens and plays fine with 7.3 fails to upen with 7.4.

The source file is copyrighted (course slides); I can provide link if desired, w/ some sort of NDA.
Comment 1 Roman Kuznetsov 2022-09-05 14:29:54 UTC
You can send the file personally to me or Xisco (I added him to Cc list) if you want your problem will be fixed
Comment 2 Yarko 2022-09-05 17:55:53 UTC
I'll see about making a minimal example of a failure for the read file.

I may also look into trying this myself (looking at Easy Hacks now) - that will avert all copyright concerns (not my copyright).
Comment 3 Yarko 2022-09-07 01:53:34 UTC
after building head of the current tree w/ --enable-dbgtools, the open problem did not appear.

It may be because of debug tooling, or 7.5dev may not have the problem that 7.4 has.

I will rebuild first w/o debug;  then checkout the exact 7.4 version I saw fail, and update this.
Comment 4 Xisco Faulí 2022-09-07 05:31:25 UTC
Hi Yarko,
I would appreciate if you could share the file privately with me? that way I can check with both versions. Maybe the issue is fixed in master but not in 7.4 branch, and it needs a backport. Thanks in advance
Comment 5 Yarko 2022-09-07 19:45:36 UTC
I've trimmed the powerpoint *.ppsx file to just a few intro slides (no so worried about copyright) - Xisco (or anyone):  try it here:

https://www.dropbox.com/s/vhjkhalqow96wfk/Working%20Together%20intro.ppsx?dl=0


It, too, fails on 7.4

I'm also noting transitions (i.e. screen noice, and black-screen events) are notably different between 7.3 (7.3.5.2) and 7.5d

The full 7.5d took ... a _long_ time to build, and a lot of disk space, as well as being incredibly slow.   Any hints on how to start with a build, find areas to rebuild for debug (i.e. open failing message, and likely leadups) would be appreciated (I'd like to start getting sea legs w/ some of this).

THanks!

P.s. - here's what I've been playing with:

LibreOffice 7.3.5.2 184fe81b8c8c30d8b5082578aee2fed2ea847c01
LibreOffice 7.4.0.3 f85e47c08ddd19c015c0114a68350214f7066f5a
LibreOfficeDev 7.5.0.0.alpha0 a71f537c0243fd89b7bc153889fee0a65fed6726
Comment 6 Yarko 2022-09-07 19:46:12 UTC Comment hidden (obsolete)
Comment 7 QA Administrators 2022-09-08 05:07:34 UTC Comment hidden (obsolete)
Comment 8 Timur 2022-09-08 07:06:27 UTC
Created attachment 182298 [details]
Sample PPSX

Bug title is "read error". 
Repro 7.4.0, no repro master 7.5+ Windows, Linux. So WFM.
Comment 9 Timur 2022-09-08 07:11:26 UTC
I close this for "read error".

As for slowness, please test just with master, running with these (depending what you have) before soffice command:
SAL_USE_VCLPLUGIN=gen
SAL_USE_VCLPLUGIN=gtk
SAL_USE_VCLPLUGIN=qt5
SAL_USE_VCLPLUGIN=kf5

Also please paste Help-About info.
Comment 10 Xisco Faulí 2022-09-08 07:24:56 UTC
(In reply to Timur from comment #9)
> I close this for "read error".
> 
> As for slowness, please test just with master, running with these (depending
> what you have) before soffice command:
> SAL_USE_VCLPLUGIN=gen
> SAL_USE_VCLPLUGIN=gtk
> SAL_USE_VCLPLUGIN=qt5
> SAL_USE_VCLPLUGIN=kf5
> 
> Also please paste Help-About info.

Hi Timur,
The issue was reported for LibreOffice 7.4, so closing it as RESOLVED WORKSFORME because it's fixed in master is not enough. The issue is still reproducible in 7.4, thus, we have to investigate it further to see which commit needs backporting
Comment 11 Xisco Faulí 2022-09-08 07:25:28 UTC
Issue fixed by 

author	Caolán McNamara <caolanm@redhat.com>	2022-06-12 17:21:12 +0100
committer	Caolán McNamara <caolanm@redhat.com>	2022-06-13 06:54:39 +0200
commit 48de2ac37366d5671aabc64364660311431d3235 (patch)
tree 5641386dcd71d08bfc9fec851cf6c6e9f24c1c16
parent 67a661800e32bb371a0a23ba498915c4508772bd (diff)
crashtesting: assert seen on loading forum-mso-en-2633.pptx

Bisected with bibisect-linux64-7.5
Comment 12 Timur 2022-09-08 07:31:36 UTC
Well, I just did that bibisect, to see that you were faster..
Comment 13 Xisco Faulí 2022-09-08 07:37:22 UTC
Issue is reproduced in

Version: 7.4.2.0.0+ / LibreOffice Community
Build ID: 26d2a8d9a70255f2211f4256f27286653fbfba44
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded

backporting the commit
Comment 14 Timur 2022-09-08 07:37:49 UTC
Caolán wrote: 
probably since:
commit 855a56fea4561135a63cb729d7a625a950b210e7
Date:   Fri May 13 08:12:17 2022 +0200
    tdf#148965 PPTX import: fix internal hyperlinks on shapes

anr really it is. 

But I don't see that this fix was backported.
Comment 15 Timur 2022-09-08 07:38:48 UTC Comment hidden (obsolete)
Comment 16 Xisco Faulí 2022-09-08 07:45:37 UTC
(In reply to Timur from comment #15)
> Xisco, 7.4 repo is 3 months old, please update. An 7.3 please.

I just updated the linux one, updating the win one now...
Comment 17 Commit Notification 2022-09-08 09:48:13 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/f6b2bef0fc46bf6e087950cf712b79bf7d0bb2be

tdf#150770: crashtesting: assert seen on loading forum-mso-en-2633.pptx

It will be available in 7.4.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 18 Commit Notification 2022-09-08 10:09:29 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/db85b90b52e87a97f62c15900801e3297bde4de3

tdf#150770: sd_import_tests2: Add unittest

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 19 Commit Notification 2022-09-09 17:16:49 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-4-1":

https://git.libreoffice.org/core/commit/6167a3ca9c2a88814933b83f6ced75444983ae4a

tdf#150770: crashtesting: assert seen on loading forum-mso-en-2633.pptx

It will be available in 7.4.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.