Bug 151049 - 16K columns: Show an infobar when there are pre-defined now-invalid range names
Summary: 16K columns: Show an infobar when there are pre-defined now-invalid range names
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.4.0.3 release
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Infobar Calc-large-spreadsheets
  Show dependency treegraph
 
Reported: 2022-09-19 07:28 UTC by Mike Kaganski
Modified: 2022-11-08 13:39 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2022-09-19 07:28:01 UTC
Before increase of column count to 16k, range names like "num1" were valid, because they didn't conflict with valid cell/range references.

The mentioned increase made those range names invalid, and their definition is rejected by UI; still, they may come from existing files created in earlier versions / generators.

Since commit 582fc887f1faafe8ff5f16a13a0208483a93353f
  Author Luboš Luňák <l.lunak@collabora.com>
  Date   Wed Mar 02 17:30:30 2022 +0100
    keep conflicting named ranges working with 16k columns

those names are still read and handled as before, to avoid silent document breakage.

I believe that it would be an improvement if Calc showed an infobar in such an event, warning users about a possible name conflict. Imagine a user who opened their older spreadsheet, and started to fill column NUM, referencing NUM1 normally, and not realizing that it had such a named range defined long ago; they would be confused why doesn't it work correctly, if they aren't informed promptly. With the infobar, they would be advised to inspect named ranges (or database ranges?), and then the conflicting names could also be marked there in the dialog, too.
Comment 1 Roman Kuznetsov 2022-11-01 19:28:03 UTC
Valid enhancement, set to NEW

UX-team, do you have some additional ideas here? 
About infobar using in general here
About text on the infobar in this case
About some button that could open some dialog for change range name
etc...
Comment 2 Heiko Tietze 2022-11-07 14:23:01 UTC
Sounds to me as old document always present such an infobar. And I assume it's unlikely that non-developer understand the issue. Is it possible to only show the infobar if something is immediate to break? What exactly would be the warning (or is it an information) and what action would the infobar provide?
Comment 3 Mike Kaganski 2022-11-07 14:31:31 UTC
(In reply to Heiko Tietze from comment #2)
> Sounds to me as old document always present such an infobar.

Why?

> And I assume
> it's unlikely that non-developer understand the issue.

Why?

> Is it possible to only show the infobar if something is immediate to break?

The issue is to show the warning when "something is broken", not always. Let me repeat:

*Only* when the old spreadsheet already had *user-defined* ranges, and *only* when some of those ranges had names that were valid on older versions, but not in newer versions, *only then* (i.e., when the document *already* has invalid range names, and it only works because we implement a workaround) should a message be shown ...

> What exactly would be the warning (or is it an information) and what action
> would the infobar provide?

... with something like

"Some of the named ranges used in the spreadsheet have invalid names that conflict with row/column names:
* num1
* mom2
* kit3

Press this button to open Named ranges dialog and rename these ranges."
Comment 4 Heiko Tietze 2022-11-07 15:27:42 UTC
(In reply to Mike Kaganski from comment #3)
> *Only* when the old spreadsheet already had *user-defined* ranges...
Makes sense in this case.

> "Some of the named ranges used in the spreadsheet have invalid names that
> conflict with row/column names: ...

Could imagine that this list can be long, too long for the infobar. So perhaps we show it in a special list on click.

The infobar level would be warning, not info (makes it yellow, IIRC).
Comment 5 Eike Rathke 2022-11-08 13:39:17 UTC
(In reply to Heiko Tietze from comment #4)
> Could imagine that this list can be long, too long for the infobar. So
> perhaps we show it in a special list on click.
Just limit it to three entries and ellipsis if more. A click list on an infobar IMHO doesn't make much sense if it isn't actionable.