Description: Button text is black, should be bright, like other UI elements in dark mode Steps to Reproduce: 1. Enable experimental features under options, "Do not Use color themes", LibreOffice theme in "Application colors" 2. CTLR + F -> Look for "Find All" button; Actual Results: Button is invisible because of black text color of the button; Expected Results: Button text should be bright, like other buttons and checkboxes in UI Reproducible: Always User Profile Reset: No Additional Info: na
Created attachment 182541 [details] 1
Created attachment 182542 [details] 2
Created attachment 182543 [details] 3
Created attachment 182544 [details] 4
Version: 7.4.1.2 (x64) / LibreOffice Community Build ID: 3c58a8f3a960df8bc8fd77b461821e42c061c5f0 CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: default; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL
Confirmed. The 'Find All' button label is modal and toggles active when a find selection is made. It is a light gray when just an inactive label, but is black when there is a selection. Should get a fg text color appropriate to a dark bg. Note: Experimental features is no longer required for auto-triggering Windws os/DE 'Dark' color support (reading os/DE theme and switching to Dark icon theme). But the selection of Application Colors 'LibreOffice Dark' remains a manual selection. =-testing-= Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community Build ID: a3bbdfab809609bec3475613a918eda699fbdc29 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded
And of course Find Bar is common to modules and the labeling issue appears across the UI.
@Caolán, would the Find toolbar respond to solution for bug 151017, or need similar but for toolbars instead of the SC backingwindow?
I think the color used for that is "ToolTextColor" and we should set it to the same as "WindowTextColor" for darkmode similar to what we do for other cases. https://gerrit.libreoffice.org/c/core/+/140195 is untested (for the moment) but is the kind of thing I think is relevant here.
yeah, tested now, that'll work
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2f1ad908310918d964b2996ccf4e987b7b0af86f tdf#151052 set Windows darkmode "ToolTextColor" to same as "WindowTextColor" It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-4": https://git.libreoffice.org/core/commit/286000f2df456cffabd678e3bde56af14c7bd185 tdf#151052 set Windows darkmode "ToolTextColor" to same as "WindowTextColor" It will be available in 7.4.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Verified now visible in Win10 Dark color mode Version: 7.5.0.0.alpha0+ (x86) / LibreOffice Community Build ID: f0a36babf2ef1384666705697f91e7ff4166f4e4 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded