Bug 151110 - Search box in bottom bar has silly animation effect
Summary: Search box in bottom bar has silly animation effect
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.5.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 161063 (view as bug list)
Depends on:
Blocks: Find-Search GTK3
  Show dependency treegraph
 
Reported: 2022-09-21 17:58 UTC by Eyal Rozenberg
Modified: 2024-05-13 20:29 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Find animation in Calc (gtk3) (109.20 KB, image/gif)
2022-09-21 18:42 UTC, Rafael Lima
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eyal Rozenberg 2022-09-21 17:58:11 UTC
When you repeatedly search and fail, using the search bar in the bottom panel in Writer, it seems the text box contracts and expands back and forth.

This is silly, distracting and weird, please don't do that. There are other ways to gain attention (and I think the red color is enough to attract attention).
Comment 1 Rafael Lima 2022-09-21 18:16:06 UTC
It does not happen to me. At least in Linux (kf5) the search bar does not have such animation.

I press Ctrl+F in Writer and if I keep trying to search terms that do not match anything, no animation happens.

What OS / backend are you using?
Comment 2 Eyal Rozenberg 2022-09-21 18:27:36 UTC
Sorry, I forgot to add the build info, and got the app wrong.

Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: 6c81a09e3ef239a2d7a991d00fe3620a67298b99
CPU threads: 4; OS: Linux 5.18; UI render: default; VCL: gtk3
Locale: en-IL (en_IL); UI: en-US
Comment 3 Rafael Lima 2022-09-21 18:41:51 UTC
This only happens in Calc using gtk3 backend. It is a horizontal shrinking animation. I agree it looks a bit silly.

Actually we have very few animations in the UI, so this one seems too much to me.
Comment 4 Rafael Lima 2022-09-21 18:42:36 UTC
Created attachment 182605 [details]
Find animation in Calc (gtk3)

Here's a short gif showing the animation.
Comment 5 Eyal Rozenberg 2022-09-21 18:50:55 UTC
Thank you, Rafael, for taking the time to make the GIF :-)

I believe the NEEDINFO can be removed now - can we mark this as NEW?
Comment 6 Rafael Lima 2022-09-21 18:55:13 UTC
I am setting this to NEW because I believe this animation effect is derived from gtk3 and was not intended to be added to LO Calc.

BTW this animation also happens in Writer under gtk3.
Comment 7 Buovjaga 2022-09-21 19:19:07 UTC
(In reply to Rafael Lima from comment #6)
> I am setting this to NEW because I believe this animation effect is derived
> from gtk3 and was not intended to be added to LO Calc.
> 
> BTW this animation also happens in Writer under gtk3.

According to the blog post it was deliberately added: https://caolanm.blogspot.com/2022/04/gtk-calling-attention-to-widget-in.html
Comment 8 Rafael Lima 2022-09-21 19:37:22 UTC
(In reply to Buovjaga from comment #7)
> According to the blog post it was deliberately added:
> https://caolanm.blogspot.com/2022/04/gtk-calling-attention-to-widget-in.html

I had no idea about that. I thought it was some upstream change in Gtk.

TBH I like the idea of adding some animations to the UI to make it smoother and more modern. So kudos for Caolan for this initiative.

In this case specifically I think the animation feels a bit too long. It could be something shorter, similar to when you try to log in and the password fails, then the entry shakes very briefly.
Comment 9 Buovjaga 2022-09-21 19:45:00 UTC
I searched for a way to disable all animations and I wonder if this still works:

gsettings set org.gnome.desktop.interface enable-animations false

I don't seem to get the search box animation under gtk3 no matter if the setting is true or false.
Comment 10 Eyal Rozenberg 2022-09-21 20:08:31 UTC
Calling attention is good, and I think I even brought this up at some point, but the animation is totally overboard... :-P
Comment 11 Caolán McNamara 2022-09-21 20:24:48 UTC
this is "call_attention_to()" of include/vcl/weld.hxx, the gtk impl is in vcl/unx/gtk3/gtkinst.cxx (and the css for it in gtkdata.cxx as call_attention_to_1/call_attention_to_2
Comment 12 Eyal Rozenberg 2024-05-13 20:28:33 UTC
*** Bug 161063 has been marked as a duplicate of this bug. ***
Comment 13 Eyal Rozenberg 2024-05-13 20:29:14 UTC
Please make it stop. The horror...