Bug 151213 - Undo doesn't work after Find and replace with replacing blank cells
Summary: Undo doesn't work after Find and replace with replacing blank cells
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
4.1.6.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, regression
Depends on:
Blocks: Find-Search Undo-Redo
  Show dependency treegraph
 
Reported: 2022-09-28 12:02 UTC by Timur
Modified: 2022-09-29 08:11 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:
Regression By: Kohei Yoshida


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Timur 2022-09-28 12:02:15 UTC
Steps to Reproduce:
1. Write some text in a couple of non-adjacent Calc cells
2. Select that range of cells also including some empty cells
3. From the Edit menu, open the Find & Replace tool.
4. Leave "Find" empty and put something in "Replace" field
5. With Current selection only, do Replace All
6. Hit Undo

Actual Results:  
Undo removes text you wrote in step 1. 

Expected Results:
Undo should remove what's replaced.
Comment 2 Rafael Lima 2022-09-28 17:04:48 UTC
I can confirm the issue with:

Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: e4d377d117874d2dc9039751dc029cb7249bd86c
CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: CL threaded

If the cells are empty, replacing the empty values for something won't be registered for future Undo.

The problem does not occur if cells have value.
Comment 3 Timur 2022-09-29 08:11:56 UTC
That's the range, all Kohei:
https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=14afe7b9b057e5bbd68d41573884c8a85761712d..2f6b33da43a06ff43bda739c41245761ffdf97fa

With source 07bd80e7d94d90be0bc8059e98eade6b3ca2b6c6 it's OK, LO doesn't start with following commits and with source 2f6b33da43a06ff43bda739c41245761ffdf97fa it's already wrong.

Kohei was active few months ago, so let's try with CC @libreoffice.org.