Bug 151338 - Change label of "Position and Size" command depending on context
Summary: Change label of "Position and Size" command depending on context
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.5.0.0 alpha0+
Hardware: All All
: low normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.6.0
Keywords:
Depends on:
Blocks: ImpressDraw-Tables UNO-Command-Label
  Show dependency treegraph
 
Reported: 2022-10-04 15:38 UTC by Eyal Rozenberg
Modified: 2023-04-04 13:44 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot of the proposed fix (28.22 KB, image/png)
2023-03-29 22:57 UTC, Rafael Lima
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eyal Rozenberg 2022-10-04 15:38:06 UTC
When I select a table cell, table row, table column, or select nothing and have the cursor in a table cell, I expect "Position and Size" in the context menu to refer to: The cell, the row, the column, and the cell respectively.

Yet - in all these cases, they refer to the table's overall position and size.
Comment 1 Heiko Tietze 2022-11-24 09:47:04 UTC
Boils down to be a duplicate of bug 151337. You understand the workflow but expect to enter precise values for row/col height/width. The question is whether this is needed for Draw/Impress.

*** This bug has been marked as a duplicate of bug 151337 ***
Comment 2 Eyal Rozenberg 2022-11-25 16:58:27 UTC
> Boils down to be a duplicate of bug 151337. 

No, the bugs are unrelated. That is, even I were ok with not changing the row height without selecting the row - I would still expect the same thing I described in the opening comment. The principle I am claiming should be enforced is: text in the context menu regards the selected entity/set of entities.
Comment 3 Buovjaga 2023-03-06 09:47:17 UTC
(In reply to Eyal Rozenberg from comment #0)
> When I select a table cell, table row, table column, or select nothing and
> have the cursor in a table cell, I expect "Position and Size" in the context
> menu to refer to: The cell, the row, the column, and the cell respectively.
> 
> Yet - in all these cases, they refer to the table's overall position and
> size.

I don't understand why it would refer to such table elements, when you can't change their position. I read the request as disabling the context menu entry for all situations except when the table object itself is selected. Why would you deprive me of the ability to open the Position and Size dialog freely?
Comment 4 Eyal Rozenberg 2023-03-06 10:02:46 UTC
(In reply to Buovjaga from comment #3)
> I don't understand why it would refer to such table elements, when you can't
> change their position.

Well, because:

1. I can change their size.
2. The table is one level (or more) outwards, away, from the most specific thing I selected or am inside of.
3. Other items on the menu - "Character..." and "Paragraph..." regard the cell, column, or row - not the whole table.

> I read the request as disabling the context menu
> entry for all situations except when the table object itself is selected.

That's not what I meant...

Now, if you believe the table position and size should always be accessible on the context menu, anywhere in the table - I can live with that, but then I would expect two things:

1. Be explicit about it, i.e. "Table Position & Size", not "Position & Size"
2. Add a context menu item for changing the size of the row or column (and for a cell - either both row and column or none of them)
Comment 5 Heiko Tietze 2023-03-06 10:55:42 UTC
Bug 153271 makes a precise input necessary, bug 142529 and bug 145204 about missing functionality (not confirming nor disconfirming).

I wonder if Draw/Impress tables have a precise cell height/width at all or are defined by the content with some random initial value.
Comment 6 Heiko Tietze 2023-03-24 09:56:51 UTC
We discussed the topic in the design meeting.

The request is about the command "Position and Size" being available in the cell context. If we rename the command it has to be done contextually as this function also applies to ordinary shapes, images etc.

MSO has "Format Shape" (along with "Format Text Effects") but only to modify the background and border. Tables have unlike shapes and text boxes no "Size and Position" option.
Comment 7 Eyal Rozenberg 2023-03-24 13:13:33 UTC
(In reply to Heiko Tietze from comment #6)

Heiko, you said there was an open bug about adding "Row Height..." and "Column Width..." (and perhaps "Optional Height..." and "Optimal Width...") to the context menu; can you link to it?
Comment 8 Heiko Tietze 2023-03-28 08:31:25 UTC
Bug 142529 - Minimal row height not working for tables in Impress
Bug 145204 - Optimize Row Height / Minimal Row Height not working in Impress
Bug 151337 - Can't change table row height without selecting the row
Comment 9 Rafael Lima 2023-03-29 22:57:30 UTC
Created attachment 186305 [details]
Screenshot of the proposed fix

So I changed the command label for "Table Position and Size" only for this popup. Notice that I also rearranged the order so that commands that are applicable to the table (and not to the selection) are grouped together.

Patch here:
https://gerrit.libreoffice.org/c/core/+/149700

I just don't know if the string I added will be caught for translation.
Comment 10 Heiko Tietze 2023-03-30 07:08:49 UTC
(In reply to Rafael Lima from comment #9)
> I just don't know if the string I added will be caught for translation.

Likely not
Comment 11 Rafael Lima 2023-03-30 15:09:02 UTC
(In reply to Heiko Tietze from comment #10)
> Likely not

I changed the patch... now the string will be localized.
Comment 12 Commit Notification 2023-04-04 13:38:49 UTC
Rafael Lima committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/894ddf0251b1b8dcd44e588430215e35b91eb02e

tdf#151338 Rearrange table popup menu in Draw/Impress

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.