Bug 151342 - Animation sidebar rendering cut off in a displeasing manner
Summary: Animation sidebar rendering cut off in a displeasing manner
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.5.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 156175 (view as bug list)
Depends on:
Blocks: Sidebar-Animation
  Show dependency treegraph
 
Reported: 2022-10-04 15:47 UTC by Eyal Rozenberg
Modified: 2023-07-07 20:18 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Impress window with problematic animation sidebar rendering (100.47 KB, image/png)
2022-10-04 15:48 UTC, Eyal Rozenberg
Details
the Impress Sidebar Animation deck for a slide with elements assigned animation (107.74 KB, image/png)
2022-10-04 16:24 UTC, V Stuart Foote
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eyal Rozenberg 2022-10-04 15:47:43 UTC
When I create a new Impress presentation, with the animation sidebar having been selected and set to a not-very-high width earlier, I get the attached window rendering.

That doesn't seem like what's intended to happen... right?
Comment 1 Eyal Rozenberg 2022-10-04 15:48:03 UTC
Created attachment 182831 [details]
Impress window with problematic animation sidebar rendering
Comment 2 Eyal Rozenberg 2022-10-04 15:48:32 UTC
Build info:

Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: bb67f10786fd5e232b198d09139c41078c3fc60d
CPU threads: 4; OS: Linux 5.18; UI render: default; VCL: gtk3
Locale: en-IL (en_IL); UI: en-US
Comment 3 Eyal Rozenberg 2022-10-04 15:51:06 UTC
Getting the same result with kf5.

However - when I press the width adjustment handle, the sidebar snaps to its minimum legitimate size and won't let me reduce the size to what it just was (which is a good thing I suppose).
Comment 4 V Stuart Foote 2022-10-04 15:55:54 UTC
*** Bug 151339 has been marked as a duplicate of this bug. ***
Comment 5 V Stuart Foote 2022-10-04 16:16:29 UTC
The Animation listing panel in attachment is empty--so just shows the starting "hint". 

You have yet to select an element on current slide, and apply an animation effect to it.  Once you start, the animation listing panel makes more sense and does not need to be full width of the textbox content, or allow it to wrap as single line keeps the outline/sequence intelligible.

IMHO => NAB

(In reply to Eyal Rozenberg from comment #3)
> Getting the same result with kf5.
> 
> However - when I press the width adjustment handle, the sidebar snaps to its
> minimum legitimate size and won't let me reduce the size to what it just was
> (which is a good thing I suppose).

You can also set "false" the UI.Sidebar 'MinimumWidth' in Tools -> Options -> Advanced Expert Configuration. That will allow the different decks on the Sidebar to shrink as you like.
Comment 6 V Stuart Foote 2022-10-04 16:24:57 UTC
Created attachment 182834 [details]
the Impress Sidebar Animation deck for a slide with elements assigned animation

No need (undesirable) to wrap or show the full textbox content. Rather just expose the animation effect assigned to the element which is done correctly, even at reduced widths.
Comment 7 Eyal Rozenberg 2022-10-04 17:26:01 UTC
(In reply to V Stuart Foote from comment #5)
> Once you start, the animation listing panel makes more sense

I'm concerned about the fact that text boxes and the list boxes end off-window, and the sidebar seems like it continues to the side of the window.

> You can also set "false" the UI.Sidebar 'MinimumWidth' in Tools -> Options
> -> Advanced Expert Configuration. That will allow the different decks on the
> Sidebar to shrink as you like.

My concern is with the default settings and most users. Should the sidebar in the case I'm describing not be either collapsed or expanded to the minimum width? When the window is created, I mean?
Comment 8 Eyal Rozenberg 2022-10-04 17:27:38 UTC
(In reply to V Stuart Foote from comment #6)
> No need (undesirable) to wrap or show the full textbox content. Rather just
> expose the animation effect assigned to the element which is done correctly,
> even at reduced widths.

Even when there are no animation effect, I think it looks bad to users when text boxes are just cut off like that. Breaks the metaphor of the sidebar - that none of it belong beyond the edge of the screen.
Comment 9 V Stuart Foote 2022-10-04 18:06:54 UTC
I'll throw it on the UX-Advise pile, but it remains that having the content of each textbox or list element receiving an animation Effect *NOT* fully exposed is preferred.  

Only the Animation effect, and enough of the start of the text run for identification is required, the rest can be pruned or allowed to run off screen. The UI is suitable to task (organizing the Animation Effects of elements on a single slide).

IMHO => NAB and WF
Comment 10 Heiko Tietze 2022-10-05 12:33:13 UTC
Works for me besides the cut-off right edge due to missing scrollbar consideration. Cannot resize the sidebar smaller than the longest dropdown following Start plus the Play button.

Version: 7.4.1.2 / LibreOffice Community
Build ID: 40(Build:2)
CPU threads: 8; OS: Linux 5.19; UI render: default; VCL: kf5 (cairo+xcb)
Locale: de-DE (en_US.UTF-8); UI: en-US
7.4.1-3
Calc: threaded
Comment 11 Eyal Rozenberg 2022-10-05 13:39:37 UTC
(In reply to Heiko Tietze from comment #10)
> Works for me besides the cut-off right edge due to missing scrollbar
> consideration. 

> Cannot resize the sidebar smaller than the longest dropdown
> following Start plus the Play button.

I can't resize it manually either, to make it narrower than the widest drop-down. But somehow it got it self to that size.

So, there are actually two bugs here:

1. A tricky bug which made the sidebar have invalid width - which I don't know how to reproduce.
2. The bug of not checking, on window creation, that the sidebar width is valid, where an invalid width triggers a widening or collapse.
Comment 12 QA Administrators 2022-10-06 04:13:18 UTC Comment hidden (obsolete)
Comment 13 Heiko Tietze 2022-10-06 09:27:42 UTC
And both issues likely have been reported.
Comment 14 Buovjaga 2023-02-16 17:55:34 UTC
There is bug 128180. Is there a need to keep this one open?
Comment 15 Eyal Rozenberg 2023-02-16 21:17:19 UTC
(In reply to Buovjaga from comment #14)
> There is bug 128180. Is there a need to keep this one open?

Well, I think so, because:

1. This bug can be fixed without 128180 being fixed. IIANM.
2. Even if 128180 is fixed, I'm not sure this bug will automatically go away.

(In reply to Heiko Tietze from comment #13)
> And both issues likely have been reported.

I'm perfectly ok with this being closed as a dupe if the appropriate issues are located...
Comment 16 Stéphane Guillou (stragu) 2023-07-06 09:28:27 UTC
Eyal, are you able to scroll to the bottom of the sidebar or is that hidden and inaccessible?
Comment 17 Sophie Sipasseuth 2023-07-06 13:28:42 UTC
*** Bug 156175 has been marked as a duplicate of this bug. ***
Comment 18 Sophie Sipasseuth 2023-07-06 13:31:44 UTC
Repro

Version: 7.6.0.0.beta1+ (X86_64) / LibreOffice Community
Build ID: 1b5cee822e0bc15ddbdfc86926678ca35ab3e082
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: fr-FR (fr_FR); UI: en-US
Calc: threaded
Comment 19 Eyal Rozenberg 2023-07-07 10:47:21 UTC
(In reply to V Stuart Foote from comment #5)
> You can also set "false" the UI.Sidebar 'MinimumWidth' in Tools -> Options
> -> Advanced Expert Configuration. That will allow the different decks on the
> Sidebar to shrink as you like.

Interesting to know, but not relevant here, because we're discussing UX with the default settings.

> The Animation listing panel in attachment is empty--so just shows the
> starting "hint". 
> 
> You have yet to select an element on current slide, and apply an animation
> effect to it.  Once you start, the animation listing panel makes more sense
> and does not need to be full width of the textbox content, or allow it to
> wrap as single line keeps the outline/sequence intelligible.

Widgets should not be cut off in the middle, and UI text - hint or otherwise - should not be cut off in the middle, regardless of what I do later. When I create a new document, I expect the UI to be in a "decent" state, not broken-but-restorable.
Comment 20 V Stuart Foote 2023-07-07 13:36:46 UTC
(In reply to Eyal Rozenberg from comment #19)
> 
> Widgets should not be cut off in the middle, and UI text - hint or otherwise
> - should not be cut off in the middle, regardless of what I do later. When I
> create a new document, I expect the UI to be in a "decent" state, not
> broken-but-restorable.

No. There is nothing incorrect in UI where a tree view  text string or name of a given element being animated not being fully displayed. Especially so when "Wrap" of those strings would make the 'Animation' panel or the 'Effects' panel of the SB completely _unintelligible_.

See the discussion around bug 140360 implementing the SB "MinimumWidth" handling. 

And here, some misguided change to the UI to enforce wrap (i.e. make full text visible by default) do not improve the UX. An equally viable solution would be an 'on mouseover' popup of the string.

For other similar UI handling of long strings, look at the 'Replacement' tab of the Autocorrect dialog or the 'Value' column of the Expert Configuration dialog. Wrap of tree view there would be equally unhelpful.

Handling of the Impress Animation deck's widgets is functional and efficient for working with a presentation. It does not require string wrap to deliver good UX.
Comment 21 Eyal Rozenberg 2023-07-07 20:18:33 UTC
(In reply to V Stuart Foote from comment #20)
> No. There is nothing incorrect in UI where a tree view  text string or name
> of a given element being animated not being fully displayed. 
>
>
> (several paragraphs about text wrapping)

That's not the problem. The problem is with the inscription covering the empty list of effects; with the boxes for category and effect etc. Have a look at the screenshot.

But - even those are just symptoms of the fundamental problem: The problem of  the sidebar width is set to a value which the user did not set it to, and cannot set it to. It does not make sense for the sidebar to be visible on startup, but set to a width below the minimum.

(In no-minimum mode - fine, whatever happens happens, it's an advanced config option.)