Created attachment 182839 [details] Screenshot Steps to reproduce: 1. Open LibreOffice with SAL_USE_VCLPLUGIN=gen 2. Click on Templates, then click on Recent Documents -> The text is not readable in those buttons. See screenshot Reproduced in Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: ca1fd7535770139044f7c1a9f7e59a082d710b6d CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: x11 Locale: es-ES (es_ES.UTF-8); UI: en-US Calc: threaded
Regression introduced by: author Heiko Tietze <tietze.heiko@gmail.com> 2022-09-09 16:07:28 +0200 committer Heiko Tietze <heiko.tietze@documentfoundation.org> 2022-09-16 10:31:45 +0200 commit 164a1f4c3315fc44161128d3d9ca886f767f7d30 (patch) tree 006195133ef2eb486902d16f5417ee3fe5b58f11 parent 08bce8eeb2e18c7cea4108dbfc2519ada56e8b61 (diff) Resolves tdf#80934 - GUI means to filter thumbnails in start center Bisected with: bibisect-linux64-7.5 Adding Cc: to Heiko Tietze
Changed GtkToggleMenuButton into GtkToggleButton, which obviously don't pick up the right background color. My theme is dark and font are respectively bright - which works well for kf5 and gtk3. Caolan, guess I could set the text color but wonder if some more basic fix makes sense. What do you think?
There is use of "set_stack_background" and "set_highlight_background", do we know the motivation behind using those. Is there a reason to not just drop the overriding defaults?
(In reply to Caolán McNamara from comment #3) > There is use of "set_stack_background" and "set_highlight_background", do we > know the motivation behind using those. No idea about set_highlight_background(). I wanted the button to clearly show the toggled state, which wasn't working before. Btw, there is another ticket about start center being too large and it might make sense to move these two buttons to the newly introduced "toolbar".
lets try and tweak the "flat mode" in gen a bit and fix up the kf5 flat toggle button "pressed" state.
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4006b855cc94fbd817f9c19d7361b5d6a06d152e Related: tdf#151351 kf5 pressed flat toggle buttons not visually depressed It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f61b6a3a23303aff75051bc704375db92ae8f345 Resolves: tdf#151351 rework flat button rendering It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1490923bea9c3ec763488a73912ff0a143329a24 Related: tdf#151351 don't use stack/highlight bg for buttons It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
that looks reasonable to me now, visually "depressed" toggle button in gen and kf5 and (IMO) better flat buttons for gen
LNTM, looks nice to me