Bug 151538 - Can't choose import filter when typing in the search bar in GTK3 file open dialog
Summary: Can't choose import filter when typing in the search bar in GTK3 file open di...
Status: RESOLVED NOTOURBUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.5.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL: https://gitlab.gnome.org/GNOME/gtk/-/...
Whiteboard:
Keywords: needsUXEval
Depends on:
Blocks: LO-File-Dialog GTK3
  Show dependency treegraph
 
Reported: 2022-10-15 09:14 UTC by Eyal Rozenberg
Modified: 2022-10-17 19:01 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eyal Rozenberg 2022-10-15 09:14:51 UTC
If you open the file open dialog, with the GTK3 VCL, and type something in the search bar - filtering the list - the file type box gets grayed out and you can no longer choose the file type / import filter.
Comment 1 raal 2022-10-15 13:39:18 UTC
Hello, the same behaviour is for example in Gedit, the dialog should be identical - system dialog. I don't think it's a bug.
Comment 2 Jean-Baptiste Faure 2022-10-16 15:46:45 UTC
(In reply to raal from comment #1)
> Hello, the same behaviour is for example in Gedit, the dialog should be
> identical - system dialog. I don't think it's a bug.

Indeed. Idem in Geany.
Closing as Not a Bug.

Best regards. JBF
Comment 3 Eyal Rozenberg 2022-10-16 16:22:54 UTC
(In reply to Jean-Baptiste Faure from comment #2)
> Closing as Not a Bug.

Don't you mean NOTOURBUG?
Comment 4 Jean-Baptiste Faure 2022-10-16 21:46:30 UTC
(In reply to Eyal Rozenberg from comment #3)
> (In reply to Jean-Baptiste Faure from comment #2)
> > Closing as Not a Bug.
> 
> Don't you mean NOTOURBUG?

No, I think it's not a bug it's a feature, because using the search field you can filter both the file name and the file type / extension. So the filtering list is not necessary when using the search field. For example, if you have several files in the folder with one named test1.odt and another named test1.pdf, you can find test1.pdf with the search criteria "test pdf".

That said, you can report this issue against Gnome and see if a bug report is accepted.

Best regards. JBF
Comment 5 Eyal Rozenberg 2022-10-17 09:05:22 UTC
(In reply to Jean-Baptiste Faure from comment #4)
> No, I think it's not a bug it's a feature, because using the search field
> you can filter both the file name and the file type / extension.

Ah, so - you've misunderstood my bug report.

The problem is not with filtering results. The problem is with the choice of input filter, i.e. the choice of how the document will be opened and with which module.

The OS/DE typically assumes that opening a file is opening a file, and it's a single app which opens it, regardless of the controls used in the file open dialog box. We, however, give that list additional semantics. So it is _a_ bug that we cannot both use the file open dialog box' facilities for searching and filtering, and at the same time choose the appropriate input filter; and while this might have been resolved by more flexible OS/DE behavior, it is _our_ responsibility to allow the user to choose the import filter to be used. So it is not just _a_ bug, but _our_ bug.
Comment 6 Caolán McNamara 2022-10-17 18:18:30 UTC
I don't think there is anything we can do about it anyway when using the system gtk file picker, we don't have full control over that widget, so its all fairly moot IMO.
Comment 7 Eyal Rozenberg 2022-10-17 18:48:26 UTC
(In reply to Caolán McNamara from comment #6)
> I don't think there is anything we can do about it anyway when using the
> system gtk file picker, we don't have full control over that widget, so its
> all fairly moot IMO.

Well, actually, we could in theory only use the file picker's built-in file-type widget to make choices which don't affect the input filter, and use another widget, or more than one, for forcing the module to open and/or the input filter to use (with the default being automatic choice of everything of course). That may also partially address bug 151537.

Still, that would be more of a mitigation than a solution.

Another thing we could/should do is take this up with the GTK developers:

https://gitlab.gnome.org/GNOME/gtk/
Comment 8 Eyal Rozenberg 2022-10-17 19:01:44 UTC
(In reply to Eyal Rozenberg from comment #7)
> Another thing we could/should do is take this up with the GTK developers:
> 
> https://gitlab.gnome.org/GNOME/gtk/

I've just filed:

https://gitlab.gnome.org/GNOME/gtk/-/issues/5272

please consider going over there and supporting it on behalf of the project :-)