Bug 151539 - The three Kodak Photo CD flavors look redundant
Summary: The three Kodak Photo CD flavors look redundant
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: filters and storage (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: File-Dialog
  Show dependency treegraph
 
Reported: 2022-10-15 09:49 UTC by Mike Kaganski
Modified: 2025-01-04 03:16 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2022-10-15 09:49:32 UTC
We have three filters for Kodak Photo CD (PCD) format:

* PCD - Kodak Photo CD (758x512)
* PCD - Kodak Photo CD (192x128)
* PCD - Kodak Photo CD (384x256)

They seem to be all using the same code GraphicFilter::readPCD [1], and that only checks the value of Office.Common/Filter/Graphic/Import/PCD config, which defines the resolution.

The config is written in SdFilterDetect::detect [2], where it relies on user's explicit filter choice (because automatic detection, implemented in GraphicFormatDetector::checkPCD [3], does nothing to detect resolution).

It seems that if this information is absent in the format, it could be better served by using a filter options dialog with user choice for resolution, just as with e.g. CSV or Text (Choose Encoding) filters. That would also decrease number of import filters a bit in the huge list (see bug 151537; it is also present in e.g. Insert Image dialog). The format shouldn't be of much use nowadays, so having three entries in the list looks a bit too much :)

[1] https://opengrok.libreoffice.org/xref/core/vcl/source/filter/graphicfilter.cxx?r=ca510d64#readPCD
[2] https://opengrok.libreoffice.org/xref/core/sd/source/ui/unoidl/sddetect.cxx?r=2ab40e9e#51
[3] https://opengrok.libreoffice.org/xref/core/vcl/source/filter/GraphicFormatDetector.cxx?r=8ad101aa#1032
Comment 1 Stéphane Guillou (stragu) 2023-01-04 09:41:47 UTC
Repro in built-in LO file dialogs as well as KF5 file dialog:

Version: 7.5.0.1 (X86_64) / LibreOffice Community
Build ID: 77cd3d7ad4445740a0c6cf977992dafd8ebad8df
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Inherited from OOo:

OpenOffice.org 3.3.0
OOO330m20 (Build:9567)

I agree they should be merged in the filetype list(s).
Comment 2 QA Administrators 2025-01-04 03:16:30 UTC
Dear Mike Kaganski,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug