Bug 151539 - The three Kodak Photo CD flavors look redundant
Summary: The three Kodak Photo CD flavors look redundant
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: filters and storage (show other bugs)
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
Depends on:
Blocks: File-Dialog
  Show dependency treegraph
Reported: 2022-10-15 09:49 UTC by Mike Kaganski
Modified: 2023-01-04 09:41 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2022-10-15 09:49:32 UTC
We have three filters for Kodak Photo CD (PCD) format:

* PCD - Kodak Photo CD (758x512)
* PCD - Kodak Photo CD (192x128)
* PCD - Kodak Photo CD (384x256)

They seem to be all using the same code GraphicFilter::readPCD [1], and that only checks the value of Office.Common/Filter/Graphic/Import/PCD config, which defines the resolution.

The config is written in SdFilterDetect::detect [2], where it relies on user's explicit filter choice (because automatic detection, implemented in GraphicFormatDetector::checkPCD [3], does nothing to detect resolution).

It seems that if this information is absent in the format, it could be better served by using a filter options dialog with user choice for resolution, just as with e.g. CSV or Text (Choose Encoding) filters. That would also decrease number of import filters a bit in the huge list (see bug 151537; it is also present in e.g. Insert Image dialog). The format shouldn't be of much use nowadays, so having three entries in the list looks a bit too much :)

[1] https://opengrok.libreoffice.org/xref/core/vcl/source/filter/graphicfilter.cxx?r=ca510d64#readPCD
[2] https://opengrok.libreoffice.org/xref/core/sd/source/ui/unoidl/sddetect.cxx?r=2ab40e9e#51
[3] https://opengrok.libreoffice.org/xref/core/vcl/source/filter/GraphicFormatDetector.cxx?r=8ad101aa#1032
Comment 1 Stéphane Guillou (stragu) 2023-01-04 09:41:47 UTC
Repro in built-in LO file dialogs as well as KF5 file dialog:

Version: (X86_64) / LibreOffice Community
Build ID: 77cd3d7ad4445740a0c6cf977992dafd8ebad8df
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Inherited from OOo:

OpenOffice.org 3.3.0
OOO330m20 (Build:9567)

I agree they should be merged in the filetype list(s).