Bug 151551 - Suggestion to drop frame target options from Link dialog
Summary: Suggestion to drop frame target options from Link dialog
Status: ASSIGNED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.4.0.3 release
Hardware: All All
: low enhancement
Assignee: Karthik
URL:
Whiteboard: target:25.8.0
Keywords: difficultyMedium, easyHack, skillDesign, topicUI
Depends on:
Blocks: Hyperlink-Dialog
  Show dependency treegraph
 
Reported: 2022-10-15 19:36 UTC by jan d
Modified: 2025-03-17 17:28 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jan d 2022-10-15 19:36:51 UTC
Writer’s Hyperlink dialog offers an option to choose frame targets in a dropdown. However, frames are an outdated technology, not recommended to be used since over a decade. 

Suggestion: Remove option from the dialog.
Comment 1 Ezinne 2022-10-18 06:57:34 UTC
The option does not perform any task when chosen. 

Repro on:

Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: f486d2220d5b51f422c8feca21c831e1c1d143d7
CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-GB (en_GB.UTF-8); UI: en-US
Calc: threaded
Comment 2 Heiko Tietze 2022-11-02 16:54:05 UTC
(In reply to jan d from comment #0)
> However, frames are an outdated technology, not recommended to be
> used since over a decade. 

Do you have a reference? Frames are essential for advanced layouts...

Wrong me, we are talking about the "Further Settings" which allow some HTML stuff. However, adding a clickable button to jump somewhere sounds still desirable to me.
Comment 3 jan d 2022-11-02 17:06:51 UTC
> Do you have a reference?

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/frameset

"Though some browsers might still support it, it may have already been removed from the relevant web standards…Be aware that this feature may cease to work at any time."

> Frames are essential for advanced layouts...

They were used for some time, but I think even when I started learning about HMTL/CSS in 2004 or so they were already considered problematic and advanced layouts were build with tables and then CSS2.

Sometimes, iframes are used today, which perform a different function I think are usually not jumped to with link attributes.
Comment 4 Heiko Tietze 2022-11-07 15:23:36 UTC
No objection so let's do it (at least remove the UI part to keep legacy documents intact).

Code pointer /cui/uiconfig/ui/hyperlinkmailpage.ui and hyperlinkdocpage.ui, hyperlinkinternetpage.ui, hyperlinknewdocpage.ui

The frame variables needs to be removed from the code as well. See cui/source/dialogs/hltpbase.cxx for this.
Comment 5 Commit Notification 2025-03-17 14:54:29 UTC
Karthik committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/74147823a7c933c796239b00cd9bf89edb899eb3

tdf#151551 Remove frame target option from Hyperlink dialog

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Buovjaga 2025-03-17 17:28:05 UTC
It seems in Help we need to make changes at least in

source/text/shared/01/02220000.xhp:244:  <paragraph id="par_id3150208" role="paragraph">Enter the name of the target frame that you want to open the URL in. You can also select a standard frame name from the list.</paragraph>
source/text/shared/01/02220100.xhp:50:   <paragraph role="paragraph" xml-lang="en-US" id="par_id3155922"><ahelp hid="cui/ui/cuiimapdlg/frameCB">Enter the name of the target frame that you want to open the URL in. You can also select a standard frame name that is recognized by all browsers from the list.</ahelp></paragraph>
source/text/shared/02/01170101.xhp:91:       <paragraph id="par_id3150010" role="tablecontent">Opens the URL that is specified under <emph>URL</emph>. You can use <emph>Frame</emph> to specify the target frame.</paragraph>
source/text/shared/02/01170101.xhp:370:  <paragraph id="par_id3154991" role="paragraph"><ahelp hid="." visibility="hidden">Specifies the target frame to display the document that is opened by the "Open document / web page" action.</ahelp> You can also specify the target frame to display a URL that you open when you click a button that has been assigned to the "Open document or web page" action.</paragraph>
source/text/shared/02/01170201.xhp:49: <paragraph role="paragraph" id="par_id3154823" xml-lang="en-US">Defines the target frame in which the loaded URL is to appear.</paragraph>
source/text/shared/02/09070100.xhp:42: <paragraph role="paragraph" id="par_id9887081" xml-lang="en-US"><ahelp hid=".">Enter a URL for the file that you want to open when you click the hyperlink. If you do not specify a target frame, the file opens in the current document or frame.</ahelp><comment>see i48946</comment></paragraph>
source/text/shared/02/09070300.xhp:44: <paragraph role="paragraph" id="par_id9462263" xml-lang="en-US"><ahelp hid=".">Enter a <emph>URL</emph> for the file that you want to open when you click the hyperlink. If you do not specify a target frame, the file opens in the current document or frame.</ahelp></paragraph>
source/text/swriter/01/05060800.xhp:57:       <paragraph xml-lang="en-US" id="par_id3149042" role="paragraph"><ahelp hid="modules/swriter/ui/frmurlpage/frame">Specify the name of the frame where you want to open the targeted file.</ahelp> The predefined target frame names are described <link href="text/shared/01/05020400.xhp#targets">here</link>.</paragraph>