Writer’s Hyperlink dialog offers an option to choose frame targets in a dropdown. However, frames are an outdated technology, not recommended to be used since over a decade. Suggestion: Remove option from the dialog.
The option does not perform any task when chosen. Repro on: Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: f486d2220d5b51f422c8feca21c831e1c1d143d7 CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-GB (en_GB.UTF-8); UI: en-US Calc: threaded
(In reply to jan d from comment #0) > However, frames are an outdated technology, not recommended to be > used since over a decade. Do you have a reference? Frames are essential for advanced layouts... Wrong me, we are talking about the "Further Settings" which allow some HTML stuff. However, adding a clickable button to jump somewhere sounds still desirable to me.
> Do you have a reference? https://developer.mozilla.org/en-US/docs/Web/HTML/Element/frameset "Though some browsers might still support it, it may have already been removed from the relevant web standards…Be aware that this feature may cease to work at any time." > Frames are essential for advanced layouts... They were used for some time, but I think even when I started learning about HMTL/CSS in 2004 or so they were already considered problematic and advanced layouts were build with tables and then CSS2. Sometimes, iframes are used today, which perform a different function I think are usually not jumped to with link attributes.
No objection so let's do it (at least remove the UI part to keep legacy documents intact). Code pointer /cui/uiconfig/ui/hyperlinkmailpage.ui and hyperlinkdocpage.ui, hyperlinkinternetpage.ui, hyperlinknewdocpage.ui The frame variables needs to be removed from the code as well. See cui/source/dialogs/hltpbase.cxx for this.
Karthik committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/74147823a7c933c796239b00cd9bf89edb899eb3 tdf#151551 Remove frame target option from Hyperlink dialog It will be available in 25.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
It seems in Help we need to make changes at least in source/text/shared/01/02220000.xhp:244: <paragraph id="par_id3150208" role="paragraph">Enter the name of the target frame that you want to open the URL in. You can also select a standard frame name from the list.</paragraph> source/text/shared/01/02220100.xhp:50: <paragraph role="paragraph" xml-lang="en-US" id="par_id3155922"><ahelp hid="cui/ui/cuiimapdlg/frameCB">Enter the name of the target frame that you want to open the URL in. You can also select a standard frame name that is recognized by all browsers from the list.</ahelp></paragraph> source/text/shared/02/01170101.xhp:91: <paragraph id="par_id3150010" role="tablecontent">Opens the URL that is specified under <emph>URL</emph>. You can use <emph>Frame</emph> to specify the target frame.</paragraph> source/text/shared/02/01170101.xhp:370: <paragraph id="par_id3154991" role="paragraph"><ahelp hid="." visibility="hidden">Specifies the target frame to display the document that is opened by the "Open document / web page" action.</ahelp> You can also specify the target frame to display a URL that you open when you click a button that has been assigned to the "Open document or web page" action.</paragraph> source/text/shared/02/01170201.xhp:49: <paragraph role="paragraph" id="par_id3154823" xml-lang="en-US">Defines the target frame in which the loaded URL is to appear.</paragraph> source/text/shared/02/09070100.xhp:42: <paragraph role="paragraph" id="par_id9887081" xml-lang="en-US"><ahelp hid=".">Enter a URL for the file that you want to open when you click the hyperlink. If you do not specify a target frame, the file opens in the current document or frame.</ahelp><comment>see i48946</comment></paragraph> source/text/shared/02/09070300.xhp:44: <paragraph role="paragraph" id="par_id9462263" xml-lang="en-US"><ahelp hid=".">Enter a <emph>URL</emph> for the file that you want to open when you click the hyperlink. If you do not specify a target frame, the file opens in the current document or frame.</ahelp></paragraph> source/text/swriter/01/05060800.xhp:57: <paragraph xml-lang="en-US" id="par_id3149042" role="paragraph"><ahelp hid="modules/swriter/ui/frmurlpage/frame">Specify the name of the frame where you want to open the targeted file.</ahelp> The predefined target frame names are described <link href="text/shared/01/05020400.xhp#targets">here</link>.</paragraph>
Olivier: it doesn't seem like Karthik is going to work on the help updates, so maybe you can take a look at what I pointed out in comment 6 (and if I missed any occurrences).
Sorry, I missed comment 6. I will work on it.
(In reply to Karthik from comment #8) > Sorry, I missed comment 6. I will work on it. If you add to your autogen.input --with-help=online it will clone helpcontent2 as a submodule. See here for how to work with it: https://wiki.documentfoundation.org/Documentation/Help#Editing_LibreOffice_Help_file_in_your_local_computer https://wiki.documentfoundation.org/Documentation/Help#How_to_send_it_back_for_approval_(via_gerrit)
Karthik Godha committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/help/commit/10793e69187eaa6092dad7943dbf78b2e6f556f1 tdf#151551 Help Updates for Hyperlink Dialog
Olivier Hallot committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/help/commit/0f5426c7fc371d3c2dacef75c96f9e7f94051956 tdf#151551 (subsequent) Revisit hyperlink Help pages
(In reply to jan d from comment #0) > frames are an outdated technology, not recommended to be used since over a decade. (In reply to jan d from comment #3) > https://developer.mozilla.org/en-US/docs/Web/HTML/Element/frameset Sigh. The removed functionality was not "frameset"; the *correct* reference to what was dropped is https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/a#target and it is quite relevant today. E.g., there are a number of special targets; you can request your hyperlink to open in a new tab using them. As the thing was called "frame", it just needed a rename to "target".
I indeed misunderstood these to related to frames only due to their name. It seems that the options parent and top actually relate to frames as technology, self opens the link in the same tab/window, blank opens in a new tab/window. There is the argument against using these at all (favoring user control rather than the document setting it), but I can see that opening in new tab/window is useful.
Ilmari Lauhakangas committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a2ed9aa09ad8d2601cf6198c8cd8647c08f09c16 Revert "tdf#151551 Remove frame target option from Hyperlink dialog" It will be available in 26.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Ilmari Lauhakangas committed a patch related to this issue. It has been pushed to "libreoffice-25-8": https://git.libreoffice.org/core/commit/87de4e9da06aa91e6bd92bbd2d4c0b81d22c5d7a Revert "tdf#151551 Remove frame target option from Hyperlink dialog" It will be available in 25.8.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Ilmari Lauhakangas committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/help/commit/67cf1084e0f8897deb522fc9bd8b8a47776b2c02 Revert "tdf#151551 Help Updates for Hyperlink Dialog"
Ilmari Lauhakangas committed a patch related to this issue. It has been pushed to "libreoffice-25-8": https://git.libreoffice.org/help/commit/fee16ab5d16ee912ac40010c9ebed311ac5991ed Revert "tdf#151551 Help Updates for Hyperlink Dialog"