Bug 151551 - Suggestion to drop frame target options from Link dialog
Summary: Suggestion to drop frame target options from Link dialog
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.4.0.3 release
Hardware: All All
: low enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: difficultyMedium, easyHack, skillDesign, topicUI
Depends on:
Blocks: Hyperlink-Dialog
  Show dependency treegraph
 
Reported: 2022-10-15 19:36 UTC by jan d
Modified: 2023-04-25 19:24 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jan d 2022-10-15 19:36:51 UTC
Writer’s Hyperlink dialog offers an option to choose frame targets in a dropdown. However, frames are an outdated technology, not recommended to be used since over a decade. 

Suggestion: Remove option from the dialog.
Comment 1 Ezinne 2022-10-18 06:57:34 UTC
The option does not perform any task when chosen. 

Repro on:

Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: f486d2220d5b51f422c8feca21c831e1c1d143d7
CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-GB (en_GB.UTF-8); UI: en-US
Calc: threaded
Comment 2 Heiko Tietze 2022-11-02 16:54:05 UTC
(In reply to jan d from comment #0)
> However, frames are an outdated technology, not recommended to be
> used since over a decade. 

Do you have a reference? Frames are essential for advanced layouts...

Wrong me, we are talking about the "Further Settings" which allow some HTML stuff. However, adding a clickable button to jump somewhere sounds still desirable to me.
Comment 3 jan d 2022-11-02 17:06:51 UTC
> Do you have a reference?

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/frameset

"Though some browsers might still support it, it may have already been removed from the relevant web standards…Be aware that this feature may cease to work at any time."

> Frames are essential for advanced layouts...

They were used for some time, but I think even when I started learning about HMTL/CSS in 2004 or so they were already considered problematic and advanced layouts were build with tables and then CSS2.

Sometimes, iframes are used today, which perform a different function I think are usually not jumped to with link attributes.
Comment 4 Heiko Tietze 2022-11-07 15:23:36 UTC
No objection so let's do it (at least remove the UI part to keep legacy documents intact).

Code pointer /cui/uiconfig/ui/hyperlinkmailpage.ui and hyperlinkdocpage.ui, hyperlinkinternetpage.ui, hyperlinknewdocpage.ui

The frame variables needs to be removed from the code as well. See cui/source/dialogs/hltpbase.cxx for this.