Bug 151835 - Can't switch tracked-changes visibility off in print preview
Summary: Can't switch tracked-changes visibility off in print preview
Status: RESOLVED NOTABUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.4.1.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsUXEval
Depends on:
Blocks: Track-Changes Print-Preview
  Show dependency treegraph
 
Reported: 2022-10-30 21:35 UTC by Eyal Rozenberg
Modified: 2022-11-07 19:11 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eyal Rozenberg 2022-10-30 21:35:35 UTC
The Show Tracked Changes toggle (on the toolbar and in the View menu) is disabled when in Print Preview. It shouldn't - I should be able to say I want to see the preview without changes, if I chose Print Preview while changes were visible (and possibly, the other way around).

I realize this might mean having to re-render the entire print preview, which would not be very snappy, but - this command should be available to the user.
Comment 1 Heiko Tietze 2022-11-07 09:44:23 UTC
It depends on whether we want to print TC as shown or "auto" accept/decline. My take is that unless you decide whether a change is accepted or decline you should get what you see, the current state. And I wouldn't overload the print preview with irrelevant functions.

Nevertheless I see the problem that inline vs. margin is ignored. László, what do you think?
Comment 2 László Németh 2022-11-07 13:49:36 UTC
(In reply to Heiko Tietze from comment #1)
> It depends on whether we want to print TC as shown or "auto" accept/decline.
> My take is that unless you decide whether a change is accepted or decline
> you should get what you see, the current state. And I wouldn't overload the
> print preview with irrelevant functions.
> 
> Nevertheless I see the problem that inline vs. margin is ignored. László,
> what do you think?

I think, hiding the switch is very important for the sake of the final review process of the document ready for printing. Changing the view means breaking the printed page content. If the changes are there only on the already verified and not visible pages, a bad click could result bad printing without being noticed.
Comment 3 Heiko Tietze 2022-11-07 14:25:59 UTC
(In reply to László Németh from comment #2)
> I think, hiding the switch is very important...

Thanks for supporting my take of NAB. Think you've seen the inline vs. margin problem. And we better deal with it in a different ticket.
Comment 4 Eyal Rozenberg 2022-11-07 19:11:55 UTC
(In reply to László Németh from comment #2)
> I think, hiding the switch is very important for the sake of the final
> review process of the document ready for printing.

Hiding or disabling?

> Changing the view

You mean, toggling "View TC"?