Bug 151940 - tooltip ‘show/hide comment’ also shown far away from related control button
Summary: tooltip ‘show/hide comment’ also shown far away from related control button
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.0.3.1 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, difficultyBeginner, easyHack, regression
Depends on:
Blocks: Apple, because, Libre, of, Office, opening, problem, Writer-Comments
  Show dependency tree / graph
 
Reported: 2022-11-06 23:26 UTC by TorrAB
Modified: 2024-09-18 03:16 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:

Attachments
file with comment (9.35 KB, application/vnd.oasis.opendocument.text)
2022-11-06 23:29 UTC, TorrAB 		Details
Screenshot (20.76 KB, image/png)
2022-11-07 06:06 UTC, Rainer Bielefeld Retired 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description TorrAB 2022-11-06 23:26:59 UTC 
Description:
cmnt.odt has a comment. Hover mouse cursor over horizontal ruler, tooltip ‘show comments’ appears; click on it: this adds a tabStop instead of showing the comment. Only View>Comment does it.

Steps to Reproduce:
1.open cmnt.odt
2.Hover mouse cursor over horizontal ruler;
3.click  tooltip ‘show comments’

Actual Results:
it adds a tabStop

Expected Results:
open comment


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.4.2.3 (x64) / LibreOffice Community
Build ID: 382eef1f22670f7f4118c8c2dd222ec7ad009daf
CPU threads: 4; OS: Windows 10.0 Build 22621; UI render: Skia/Vulkan; VCL: win
Locale: en-CA (en_CA); UI: en-US
Calc: CL
Comment 1 TorrAB 2022-11-06 23:29:35 UTC 
Created attachment 183443 [details]
file with comment
Comment 2 Rainer Bielefeld Retired 2022-11-07 06:06:30 UTC 
Created attachment 183444 [details]
Screenshot

More or less REPRODUCIBLE with Installation of Version:7.4.2.3 (x64) 
Build ID: 382eef1f22670f7f4118c8c2dd222ec7ad009daf
CPU threads: 12; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE |  Calc: threaded | ElementaryTheme | My normal User Profile	

The problem is not that the action does not work.
Problem is that a tooltip is shown where it should not be.

In the screenshot you see a "Comments" button, click on it hides or shows comments in the document.

And the Tooltip only should be shown for mouse pointer above that button, not for mouse pointer somewhere in height of ruler. Tooltip also appears with mouse pointer far right or left from the ruler
Comment 3 Rainer Bielefeld Retired 2022-11-07 06:20:06 UTC 
Additional info
---------------
a) There was no such tooltip for that control button in LibO Portable 6.4.7
   and Server Installation of Version: 6.0.7.3 (x64) 
   Build-ID dc89aa7a9eabfd848af146d5086077aeed2ae4a5; CPU-Threads: 12; 
   OS: Windows 10.0; UI-Render: GL; Gebietsschema: de-DE (de_DE); Calc: CL, 
   Special devUserProfile
b) Still REPRODUCIBLE with Server Installation of Version: 7.5.0.0.alpha0+  
   Build ID: 2a7fcaf582df3ada57ca519b50e29011973a1b6f
   CPU-Threads: 12; BS: Windows 10.0 Build 19044; UI render: default; VCL: win
   Locale: de-DE (de_DE); UI: en-US
   Calc: Calc: threaded |  Elementary Theme  |  
   Special devUserProfile  (based on my normal one)
c) So it seems that there happened 2 accidents
c1) Tooltip has been forgotten when introducing that control button
c2) Horizontal limitations for appearance of for tooltip has been defined wrong
    When Tooltip became introduced.
d) No obvious DUPs found with query <https://bugs.documentfoundation.org/buglist.cgi?cmdtype=dorem&remaction=run&namedcmd=DUPs151940&sharer_id=19321>
Comment 4 Telesto 2022-11-07 13:23:45 UTC 
Repro with
7.1

No extended tooltip visible with
Version: 6.4.0.0.beta1+ (x64)
Build ID: e75dd1fc992f168f24d66595265a978071cdd277
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win; 
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: CL
Comment 5 Kira Tubo 2023-09-15 19:32:53 UTC 
Reproduced with 7.0.3.1 and daily master build

Version: 7.0.3.1 (x64)
Build ID: d7547858d014d4cf69878db179d326fc3483e082
CPU threads: 6; OS: Windows 10.0 Build 22621; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 9a37652b79001bf5208841b9221dee851b9b6d0f
CPU threads: 6; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded
Comment 6 Kira Tubo 2023-09-15 20:58:54 UTC 
Bibisected win64-7.0. Added Jan-Marek Glogowski to cc. 

Regression was found at: https://git.libreoffice.org/core/+/172c290f86b961fb786b48d18a81004c7fa14867


commit 172c290f86b961fb786b48d18a81004c7fa14867	[log]
author	Jan-Marek Glogowski <glogow@fbihome.de>	Thu Jul 11 13:37:26 2019 +0000
committer	Adolfo Jayme Barrientos <fitojb@ubuntu.com>	Wed Jun 03 17:11:20 2020 +0200
tree 0591df2caa42c7b4a6107399794e525d813394dd
parent 0fe109a27c9a1b10b0b8a3314cb55926ecf103ae [diff]
Comment 7 Jim Raykowski 2024-09-17 19:26:39 UTC 
(In reply to Rainer Bielefeld Retired from comment #2)
> And the Tooltip only should be shown for mouse pointer above that button,
> not for mouse pointer somewhere in height of ruler. Tooltip also appears
> with mouse pointer far right or left from the ruler
Code pointers:

sw/source/uibase/misc/swruler.cxx
void SwCommentRuler::MouseMove(const MouseEvent& rMEvt)

UpdateCommentHelpText() should only be called when the comment control region contains the mouse position.