Bug 151976 - missing Standard Toolbar buttons when editing chart
Summary: missing Standard Toolbar buttons when editing chart
Status: RESOLVED NOTABUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Chart (show other bugs)
Version:
(earliest affected)
5.0.0.5 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsUXEval
Depends on:
Blocks: Chart Toolbars
  Show dependency treegraph
 
Reported: 2022-11-09 10:47 UTC by Alt Walter
Modified: 2023-06-20 12:08 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
compare the pictures what changes when you double click on the graphic (1.28 MB, image/jpeg)
2023-06-09 07:39 UTC, Alt Walter
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alt Walter 2022-11-09 10:47:55 UTC
Description:
Diagram: double click on the diagram to make changes in the data area, the toolbar will be moved to the left so that New and Open are no longer visible.

Actual Results:
this error is only visual, the toolbar is back to normal after the data update

Expected Results:
please fix this error. Openoffice works normally in this area without moving the toolbar


Reproducible: Always


User Profile Reset: No

Additional Info:
no further details
Comment 1 Stéphane Guillou (stragu) 2022-11-09 14:28:53 UTC
Thank you for your report!
Could you please provide use with the information copied from Help > About LibreOffice?
Have you actually tested this and seen the issue in the version 3.3 of LibreOffice too?
Thank you!
Comment 2 QA Administrators 2023-05-09 03:16:53 UTC Comment hidden (obsolete)
Comment 3 QA Administrators 2023-06-09 03:14:50 UTC Comment hidden (obsolete)
Comment 4 Alt Walter 2023-06-09 07:39:10 UTC
Created attachment 187798 [details]
compare the pictures what changes when you double click on the graphic
Comment 5 Stéphane Guillou (stragu) 2023-06-14 17:11:10 UTC
First version affected is 5.0.0.1 (identified with linux-64-releases bibisect repository, at commit 74fe407600b30673bc73b572df90f3101cd18b2d).

Not sure if that was by design or a regression, but I think there is no reason one shouldn't be able to create or open documents while editing a chart.
The Export to PDF button exports the whole document, not just the chart. So why not keep these other buttons that are not exclusively related to chart editing? There's enough space.

Workaround: customise the Chart Default toolbar to add missing buttons.
Comment 6 Stéphane Guillou (stragu) 2023-06-14 17:21:06 UTC
Design team, agree that some/all should come back?

Before 5.0.0.1:

New | Open | Save | E-Mail | PDF | Print | Cut | Copy | Paste | Undo | Redo

In 24.2:

Save | PDF | Print | Undo | Redo

I think they can all come back.
Could be an easyHack.
Comment 7 V Stuart Foote 2023-06-14 18:32:30 UTC
The standard menu in chart2 was configured for bug 90492

commit to hide the chart mode standard menu buttons was:

https://gerrit.libreoffice.org/c/core/+/15225

We now had over 200 release builds with that intact--can *NOT* call it a regression, and frankly it made sense as it was implemented for bug 90492.
Comment 8 Stéphane Guillou (stragu) 2023-06-15 15:05:45 UTC
(In reply to V Stuart Foote from comment #7)
> The standard menu in chart2 was configured for bug 90492

Thanks for finding it, Stuart!
In that report, UX eval was asked after the commit was merged for some reason. Wondering if we could get it discussed at the next design meeting?

After reading the comments there, I still think the standard toolbar should have  the usual defaults. There was opposition to removing Copy and Paste from the toolbar in bug 90492 comment 2.
Comment 9 V Stuart Foote 2023-06-15 23:17:37 UTC
Things are not being hidden, rather the 'Standard' toolbar is no longer active.

That is when the integrated chart2 editing context view mode is activated it has its own implementation of the Standard toolbar and the Formatting toolbar.  They replace the toolbars of the 'normal' view.

As the UI for the chart2 was being reworked, buttons on that toolbar were set to not shown mode--and the 'standard' and 'formatting' toolbars activated by chart2 in edit mode were merged onto one line. 

To streamline the UI, unnecessary buttons (for majority of use cases) were suppressed, not removed.

Yes it is trivial to restore by commit removing the toggle in the UI XML but it is also trivial for users to do that directly and has been so since 5.0.0. And changing from default (expanding the chart2 'Standard toolbar) and setting any visible is persistent and recorded into user profile.

So no need to back track on a dev choice decision done back at the 5.0.0 release. 
Doing so is a bad precedence to second guess implemented features, which chart2 is. 

Rather, it is a a RTM opportunity for users to explore the UI functions--which ever UI or MUFFIN flavor.

IMHO => NAB and WF
Comment 10 Heiko Tietze 2023-06-16 08:16:23 UTC
(In reply to Alt Walter from comment #0)
> ... New and Open are no longer visible.

What is the issue not having these commands in the chart editing mode? You cannot open a chart nor create a new one (and the other commands aka buttons are also related to the whole document).
Comment 11 Stéphane Guillou (stragu) 2023-06-20 12:08:31 UTC
Well, as it was implemented on purpose and hasn't seen much complaints since then, I agree it can be left as it is.

I still feel like it should be an all-or-nothing situation: if we have Export _whole document_ to PDF and Save _whole document_, then why shouldn't we be able to Print the whole document from the toolbar as well? Or create a new document while spending time customising a complex chart?

In any case, I'm definitely not looking to die on this hill! :D

Happy with a "not a bug" resolution if that's the position of design team members.

Alt, you can customise the toolbar by right-clicking on it, or using Tools > Customize.

Thanks!