Bug 152057 - Improve Help Online (source/text/shared/01/01010000.xhp)
Summary: Improve Help Online (source/text/shared/01/01010000.xhp)
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Documentation (show other bugs)
Version:
(earliest affected)
7.5.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: BogdanB
URL:
Whiteboard: target:7.5.0
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-15 19:19 UTC by BogdanB
Modified: 2022-11-21 20:20 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description BogdanB 2022-11-15 19:19:53 UTC
Description:
When we open Writer the order for new documents in File - New is Text, Spreadsheet, Presentation, Drawing, Formula, Database, HTML Document, XML, Labels, Business, Master, Templates. In Help have to be changed.

The icon for Templates is wrong/missing.

Everything else is ok (text, links, icons).

Steps to Reproduce:
-

Actual Results:
-

Expected Results:
-


Reproducible: Always


User Profile Reset: No

Additional Info:
-
Comment 1 BogdanB 2022-11-15 20:42:09 UTC
For the first aspect the patch is here:
https://gerrit.libreoffice.org/c/help/+/142689

------

This is the address for the missing image
https://newdesign.libreoffice.org/xhpeditor/icon-themes/res/sx03242.svg

This is the address for the previous image, where the image IS available.
https://newdesign.libreoffice.org/xhpeditor/icon-themes/res/odm_16_8.svg
Comment 2 Buovjaga 2022-11-16 09:01:43 UTC
(In reply to BogdanB from comment #1)
> For the first aspect the patch is here:
> https://gerrit.libreoffice.org/c/help/+/142689
> 
> ------
> 
> This is the address for the missing image
> https://newdesign.libreoffice.org/xhpeditor/icon-themes/res/sx03242.svg
> 
> This is the address for the previous image, where the image IS available.
> https://newdesign.libreoffice.org/xhpeditor/icon-themes/res/odm_16_8.svg

odm is ODF Master Document, though. Should be icon for template. The reference to sx03242.png is already there in 2012, when some directory changes were made.
Comment 3 BogdanB 2022-11-16 09:32:43 UTC
(In reply to Buovjaga from comment #2)
> (In reply to BogdanB from comment #1)
> > For the first aspect the patch is here:
> > https://gerrit.libreoffice.org/c/help/+/142689
> > 
> > ------
> > 
> > This is the address for the missing image
> > https://newdesign.libreoffice.org/xhpeditor/icon-themes/res/sx03242.svg
> > 
> > This is the address for the previous image, where the image IS available.
> > https://newdesign.libreoffice.org/xhpeditor/icon-themes/res/odm_16_8.svg
> 
> odm is ODF Master Document, though. Should be icon for template. The
> reference to sx03242.png is already there in 2012, when some directory
> changes were made.

Yes, I meant previously image on the same page, that is working... In order to compare the address of images.
Comment 4 Buovjaga 2022-11-16 11:56:57 UTC
(In reply to BogdanB from comment #1)
> This is the address for the missing image
> https://newdesign.libreoffice.org/xhpeditor/icon-themes/res/sx03242.svg

This is very strange to me and hopefully Olivier can somehow figure this out. Indeed, if you copy & paste the source/text/shared/01/01010000.xhp contents to the XHP editor and render the page, you will see that icon image. However, in both LibO and Help source there is no other trace of the image than src="res/sx03242.png" in the XHP. It is not even in any links.txt, so how is it being created for the editor??
Comment 5 Buovjaga 2022-11-16 12:28:40 UTC
Cloph pointed out that the icon was removed in https://git.libreoffice.org/core/commit/9bf6c9d7e87472f1800e447361ab416407243dcd

So probably XHP editor online is using the files from before this commit.
Comment 6 BogdanB 2022-11-16 16:04:35 UTC
(In reply to Buovjaga from comment #5)
> Cloph pointed out that the icon was removed in
> https://git.libreoffice.org/core/commit/
> 9bf6c9d7e87472f1800e447361ab416407243dcd
> 
> So probably XHP editor online is using the files from before this commit.

I found that the image was deleted. See here https://git.libreoffice.org/core/+/9bf6c9d7e87472f1800e447361ab416407243dcd%5E%21 and search for 'sx03242.png'

diff --git a/icon-themes/colibre/res/sx03242.png b/icon-themes/colibre/res/sx03242.png
deleted file mode 100644
index 3ac0b35..0000000
--- a/icon-themes/colibre/res/sx03242.png
+++ /dev/null
Binary files differ

We need to add Rizmut to CC. Maybe he will help us with this image.
Comment 7 BogdanB 2022-11-16 16:07:21 UTC
This is the page from Help with the missing icon.
https://help.libreoffice.org/latest/en-US/text/shared/01/01010000.html?DbPAR=WRITER#bm_id3149687
Comment 8 Olivier Hallot 2022-11-17 11:09:39 UTC
(In reply to BogdanB from comment #6)
> (In reply to Buovjaga from comment #5)
> > Cloph pointed out that the icon was removed in
> > https://git.libreoffice.org/core/commit/
> > 9bf6c9d7e87472f1800e447361ab416407243dcd
> > 
> > So probably XHP editor online is using the files from before this commit.
> 
> I found that the image was deleted. See here
> https://git.libreoffice.org/core/+/
> 9bf6c9d7e87472f1800e447361ab416407243dcd%5E%21 and search for 'sx03242.png'


Indeed the XHP editor needs update.
Comment 9 BogdanB 2022-11-17 20:40:18 UTC
Rizmut, I added you to CC. Could you please take a look?
Comment 10 BogdanB 2022-11-19 05:08:33 UTC
All the changes are in this gerrit 
https://gerrit.libreoffice.org/c/help/+/142689

Thanks Olivier for changes on this patch, I didn't know how to do that alone.
Comment 11 Commit Notification 2022-11-21 19:32:07 UTC
Bogdan B committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/9a51c0944dd694febb2c007f497c22ec57d159aa

tdf#152057 Complete revision of shared/01/01010000.xhp