Bug 152078 - Add control to Basic IDE to easily adjust the UI font size
Summary: Add control to Basic IDE to easily adjust the UI font size
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: BASIC (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:7.5.0 inReleaseNotes:7.5
Keywords:
Depends on:
Blocks: BASIC-IDE
  Show dependency treegraph
 
Reported: 2022-11-16 22:33 UTC by Rafael Lima
Modified: 2022-12-09 14:02 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Video showing how the new commands would work (682.91 KB, video/mp4)
2022-11-16 22:33 UTC, Rafael Lima
Details
Video showing the Zoom slider in action (482.81 KB, video/mp4)
2022-11-30 22:07 UTC, Rafael Lima
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Lima 2022-11-16 22:33:20 UTC
Created attachment 183635 [details]
Video showing how the new commands would work

Currently, if you want to grow/shrink the font height in the Basic IDE, you need to go to Tools - Options - Fonts and then set the font height for Basic/HTML/SQL.

This is not very convenient, since most IDEs/Editors provide very quick methods to increase / decrease the editor's font size.

So I would like to propose the creation of two new UNO commands (.uno:BasicIdeGrow and .uno:BasicIdeShrink) that can be used in the toolbar of the Basic IDE to quickly increase/decrease font size.

The attached video shows how the proposed commands would work (beware that the commands do not have icons yet).

I already have a functioning code, however it needs a lot of polishing. So before I keep on working on this new feature, I would like to hear the opinions of others.
Comment 1 Stéphane Guillou (stragu) 2022-11-17 00:50:47 UTC
I think this makes perfect sense, but curious to hear what UX/Design have to say.
It would be good to also have the usual Ctrl + Scroll shortcut work in the IDE as well, given that it can be used in all components already.
Comment 2 Heiko Tietze 2022-11-17 06:32:11 UTC
Would prefer one command .uno:BasicIdeZoom and a slider at the statusbar. Two buttons to control UI aspects are not so well suited at the primary toolbar which presents the most frequently used functions. And I'd also keep the UNO API as small as possible.
Comment 3 Rafael Lima 2022-11-17 18:22:56 UTC
(In reply to Heiko Tietze from comment #2)
> Would prefer one command .uno:BasicIdeZoom and a slider at the statusbar.
> Two buttons to control UI aspects are not so well suited at the primary
> toolbar which presents the most frequently used functions. And I'd also keep
> the UNO API as small as possible.

The idea of having two commands seeks to mimic what we already have in Writer/Impress/Calc to increase/decease font size in the editor.

I like the idea of having a slider in the status bar. I'll see if it's something I can handle. If it turns out to be too complicated, then I'll let you know.
Comment 4 Heiko Tietze 2022-11-18 14:49:41 UTC
If you follow the two-command idea I suggest to only bind it to shortcuts and not have this option on the toolbar. Could be ctrl+num+/-, although it wont work on TKL keyboards.
Comment 5 Rafael Lima 2022-11-24 12:09:03 UTC
A WIP patch using the Zoom slider is here:

https://gerrit.libreoffice.org/c/core/+/143159

Beware that it's still not complete.
Comment 6 Rafael Lima 2022-11-30 22:07:34 UTC
Created attachment 183925 [details]
Video showing the Zoom slider in action

The zoom slider is now working as intended.

See the attached video to see how it works.
Comment 7 Commit Notification 2022-12-01 11:34:53 UTC
Rafael Lima committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0d9231f2133def9254e0220b8033a46e5fc17658

tdf#152078 Add a Zoom slider to the Basic IDE

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Stéphane Guillou (stragu) 2022-12-04 13:21:48 UTC
Verified as fixed in:

Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: c50cf1883af26daebdfc9d796ced3c20c222f43b
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Thank you Rafael! If you don't plan on other commits, please feel free to mark this fix as verified yourself.

I added a screenshot in the release notes.
Comment 9 Rafael Lima 2022-12-04 13:46:55 UTC
(In reply to Stéphane Guillou (stragu) from comment #8)
> Thank you Rafael! If you don't plan on other commits, please feel free to
> mark this fix as verified yourself.

I am now working on the Ctrl+Wheel zooming. Maybe it'll be ready in time for 7.5.
Comment 10 Commit Notification 2022-12-08 08:25:30 UTC
Rafael Lima committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/be6024a2d4fc11c908aeb29b58ce33f851dab6bc

tdf#152078 Enable Ctrl+Wheel zoom in Basic code editor

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Stéphane Guillou (stragu) 2022-12-09 13:30:35 UTC
Also verified the scroll zoom in:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 95a3d7733c5b48c99b2b74b06c7eeee718fdcd03
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Thank you, Rafael!

Apologies about marking the report as resolved. Please mark it yourself when you are done and I'll mark as verified later.

I've mention the Ctrl + Scroll shortcut in the release notes.
Comment 12 Rafael Lima 2022-12-09 13:37:06 UTC
(In reply to Stéphane Guillou (stragu) from comment #11)
> Apologies about marking the report as resolved. Please mark it yourself when
> you are done and I'll mark as verified later.

No problem... actually it's fixed now. I'm setting to Resolved - Fixed.