Bug 152361 - Actual value type of ParaAdjust is different from specified type in API
Summary: Actual value type of ParaAdjust is different from specified type in API
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: sdk (show other bugs)
Version:
(earliest affected)
7.5.0.0 alpha0+
Hardware: x86-64 (AMD64) Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Dev-related
  Show dependency treegraph
 
Reported: 2022-12-03 09:17 UTC by Regina Henschel
Modified: 2025-05-17 03:12 UTC (History)
0 users

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2022-12-03 09:17:14 UTC
The API specifies
com::sun::star::style::ParagraphAdjust ParaAdjust
in ParagraphProperties Service Reference

And com::sun::star::style::ParagraphAdjust as enum ParagraphAdjust

Now take a text document or a shape with text and look at property ParaAdjust using the DevelopmentTools. There you see that "ParaAdjust" has type "short".

That is a problem, as for example the C++ code
     sal_Int16 nParaAdjust(3);
     xParagraphPropSet->getPropertyValue("ParaAdjust") >>= nParaAdjust;
works, but
     style::ParagraphAdjust eParaAdjust(style::ParagraphAdjust_CENTER);
     xParagraphPropSet->getPropertyValue("ParaAdjust") >>= eParaAdjust;
does not work.

Example of its use in core is
https://opengrok.libreoffice.org/xref/core/filter/source/svg/svgexport.cxx?r=7dd9790b#2173
There you see the required type conversions.

I don't know what is the best solution. But in case we keep it as "short" in core, there should be a comment in the API description of ParaAdjust property, that its actual value type is "short" and using the enum needs type conversions.
Comment 1 Mike Kaganski 2022-12-03 09:34:48 UTC
https://gerrit.libreoffice.org/c/core/+/140344
Comment 2 Mike Kaganski 2022-12-05 08:26:29 UTC
FTR: the innermost implementation is SvxAdjustItem::QueryValue, putting sal_Int16. The counterpart, SvxAdjustItem::PutValue, uses cppu::enum2int, so is prepared for both plain integers and enums in the passed Any.
Comment 3 QA Administrators 2025-05-17 03:12:17 UTC
Dear Regina Henschel,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug