Bug 152421 - Gtk-CRITICAL: 'GTK_IS_LABEL (label)' assertion failure when opening Options > LibreOffice Calc > View
Summary: Gtk-CRITICAL: 'GTK_IS_LABEL (label)' assertion failure when opening Options >...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.4.3.2 release
Hardware: All All
: low minor
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.5.0 target:7.4.4
Keywords: bibisected, bisected, regression
Depends on:
Blocks: GTK3 Options-Dialog-Calc
  Show dependency treegraph
 
Reported: 2022-12-08 13:42 UTC by Stéphane Guillou (stragu)
Modified: 2022-12-09 13:11 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stéphane Guillou (stragu) 2022-12-08 13:42:52 UTC
Steps:

1. Open LO Calc from command line, e.g.: 
2. Open Tools > Options... > LibreOffice Calc > View

Results:

Several Gtk-CRITICAL assertion failures + GLib-GObject-WARNINGs:

(soffice:38914): GLib-GObject-WARNING **: 14:34:34.877: invalid cast from 'GtkImage' to 'GtkLabel'

(soffice:38914): Gtk-CRITICAL **: 14:34:34.877: gtk_label_set_label: assertion 'GTK_IS_LABEL (label)' failed

In:

Version: 7.4.3.2 / LibreOffice Community
Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: de-DE (en_AU.UTF-8); UI: en-US
Calc: threaded

and a master build from today:

Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: ad085990b8073a122ac5222e5220f8f1d6826dcf
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

But not in:

Version: 7.3.7.2 / LibreOffice Community
Build ID: e114eadc50a9ff8d8c8a0567d6da8f454beeb84f
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: de-DE (en_AU.UTF-8); UI: en-US
Calc: threaded

Therefore, regression.

GTK-specific as could not be reproduced with:

Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: ad085990b8073a122ac5222e5220f8f1d6826dcf
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Caolán, you might be interested after the fix for Bug 152301.
Comment 1 Stéphane Guillou (stragu) 2022-12-08 13:58:22 UTC
Bisected on 7.4 Linux repo to:
 85176c3ff7d240617048c3d1563fd388fb1c112b is the first bad commit
commit 85176c3ff7d240617048c3d1563fd388fb1c112b
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Sat Jan 15 13:44:02 2022 +0100
    
    source 0c141900b49c2efeb0535dbcbea94f7b9b6aacd2

 instdir/program/setuprc                            |   2 +-
 instdir/program/versionrc                          |   2 +-
 instdir/share/config/images_breeze.zip             | Bin 1897459 -> 1897459 bytes
 instdir/share/config/images_breeze_dark.zip        | Bin 1893132 -> 1893132 bytes
 instdir/share/config/images_breeze_dark_svg.zip    | Bin 1574850 -> 1574850 bytes
 instdir/share/config/images_breeze_svg.zip         | Bin 1572323 -> 1572323 bytes
 instdir/share/config/images_colibre.zip            | Bin 2750384 -> 2750384 bytes
 instdir/share/config/images_colibre_svg.zip        | Bin 2907029 -> 2907029 bytes
 instdir/share/config/images_elementary.zip         | Bin 4206629 -> 4206629 bytes
 instdir/share/config/images_elementary_svg.zip     | Bin 5531757 -> 5531757 bytes
 instdir/share/config/images_karasa_jaga.zip        | Bin 4845240 -> 4845240 bytes
 instdir/share/config/images_karasa_jaga_svg.zip    | Bin 19324292 -> 19324292 bytes
 instdir/share/config/images_sifr.zip               | Bin 2116787 -> 2116787 bytes
 instdir/share/config/images_sifr_dark.zip          | Bin 2118725 -> 2118725 bytes
 instdir/share/config/images_sifr_dark_svg.zip      | Bin 1767488 -> 1767488 bytes
 instdir/share/config/images_sifr_svg.zip           | Bin 1763591 -> 1763591 bytes
 instdir/share/config/images_sukapura.zip           | Bin 3048726 -> 3048726 bytes
 instdir/share/config/images_sukapura_svg.zip       | Bin 4367096 -> 4367096 bytes
 .../soffice.cfg/modules/scalc/ui/tpviewpage.ui     |   5 ++---
 19 files changed, 4 insertions(+), 5 deletions(-)

Which points to:

commit 0c141900b49c2efeb0535dbcbea94f7b9b6aacd2
author	Olivier Hallot <olivier.hallot@libreoffice.org>	Fri Jan 14 17:50:52 2022 -0300
committer	Olivier Hallot <olivier.hallot@libreoffice.org>	Sat Jan 15 13:32:58 2022 +0100
tree f4f06384bdabbb92cea3df0fd6511b23c1c881b8
parent e19f4c1a1c24de32043c6d94394d048e1dc63dba

Change cursor -> pointer in spreadsheet option tip

Olivier, could you please have a look?
Comment 2 Commit Notification 2022-12-08 16:05:42 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/78da075e1b9d3b3a5c0b1302f5536678f0c04923

Resolves: tdf#152421 'GTK_IS_LABEL (label)' assertion failure

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2022-12-08 16:38:50 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/b4d491808b65188f342a5ab25b893156b285deab

Resolves: tdf#152421 'GTK_IS_LABEL (label)' assertion failure

It will be available in 7.4.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Stéphane Guillou (stragu) 2022-12-09 13:11:46 UTC
Fix verified:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 95a3d7733c5b48c99b2b74b06c7eeee718fdcd03
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Thank you Caolán!