Bug 152484 - UI Images Decorative flag should disable Description text box when enabled
Summary: UI Images Decorative flag should disable Description text box when enabled
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.5.0.0 alpha1+
Hardware: All All
: medium enhancement
Assignee: Michael Stahl (allotropia)
URL:
Whiteboard: target:24.2.0 target:7.6.0.0.beta2
Keywords: accessibility
Depends on:
Blocks: a11y, Accessibility
  Show dependency treegraph
 
Reported: 2022-12-12 12:51 UTC by Gabor Kelemen (allotropia)
Modified: 2023-07-07 14:30 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
The example documents A11Y UI in Word 2019 and Writer (270.14 KB, image/png)
2022-12-12 12:51 UTC, Gabor Kelemen (allotropia)
Details
Edited example document with Decorative image having A11Y description text (26.72 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2022-12-12 12:52 UTC, Gabor Kelemen (allotropia)
Details
The edited document in Word and Writer (229.36 KB, image/png)
2022-12-12 13:03 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2022-12-12 12:51:34 UTC
Created attachment 184109 [details]
The example documents A11Y UI in Word 2019 and Writer

This is a followup to bug 143311

A new image property "Decorative" was added to the UI for A11Y purposes.
Now when enabled, this does not disable the Description text box which is normally used to provide an accessible description of the image.
Disabling would make sense since Decorative attribute means it should not be announced by screen readers in PDF files, so why bother providing it?

This is also what Word does, and providing a Description to a Decorative image confuses Word, so this is also generating an interop issue.

1, Open attachment 173503 [details]
2, Open the Properties dialog of the butterfly image
3, On the Options tab notice the Decorative checkbox is checked (good), and the Description can be edited. Enter something.
4, Save the file as DOCX, open it in Word 2019 (this is a new feature in that version, older ones don't support it yet).

In Word the added Description is visible, and the Mark as editable box is unchecked, while it is checked in Writer.

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 9b46020c262045aed0beace4708565235c2523cc
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded
Comment 1 Gabor Kelemen (allotropia) 2022-12-12 12:52:53 UTC
Created attachment 184110 [details]
Edited example document with Decorative image having A11Y description text
Comment 2 Gabor Kelemen (allotropia) 2022-12-12 13:03:08 UTC
Created attachment 184111 [details]
The edited document in Word and Writer
Comment 3 Commit Notification 2023-07-07 13:45:49 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/04e90103b9a031af4073967228c6ccfc59438ec0

tdf#152484 cui,sw: if decorative is enabled, disable title/description

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Michael Stahl (allotropia) 2023-07-07 13:47:01 UTC
fixed on master
Comment 5 Commit Notification 2023-07-07 14:30:55 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/89b032b0cafa005729c693d9f2cfab83246697ab

tdf#152484 cui,sw: if decorative is enabled, disable title/description

It will be available in 7.6.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.