Bug 152553 - Spell Check Dialog Box Fails to Automatically Close When Done
Summary: Spell Check Dialog Box Fails to Automatically Close When Done
Status: REOPENED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.3.2.2 release
Hardware: All Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Spell-Checking-Dialog
  Show dependency treegraph
 
Reported: 2022-12-16 15:29 UTC by kitchm
Modified: 2023-01-12 23:23 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description kitchm 2022-12-16 15:29:55 UTC
Description:
The dialog box that is displayed when accessing spell check, has problems in its function.  If a user selects a word and then selects the spell check icon, a new window comes up on the screen.  When finished with that word's correction and the user selects not to start again at beginning of document, the window fails to close properly.

Steps to Reproduce:
1.Type in the phrase "Did you do it on purpos?"
2.Obviously the word should be "purpose".
3.Select the word and open spell check.
4.Select the correct word and then Correct.
5.See the new sub pop-up that states "Continue checking at beginning of document?".
6.Select "No".
7.Main pop-up window does not close, but loses focus instead.

Actual Results:
See description above.

The user was forced to select the box and then closed it; for two unnecessary steps.

Expected Results:
The main pop-up window should have closed.


Reproducible: Always


User Profile Reset: No

Additional Info:
[Information automatically included from LibreOffice]
Locale: en-US
Module: TextDocument
[Information guessed from browser]
OS: Linux (All)
OS is 64bit: yes

Version: 7.3.2.2 / LibreOffice Community
Build ID: 49f2b1bff42cfccbd8f788c8dc32c1c309559be0
CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

Debian Bullseye and Xfce 4.16
Comment 1 Ezinne 2022-12-17 08:59:41 UTC
Reproducible in:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 4e4a31ac7d920c71e26ca4acd18c11ec2bd015bb
CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

I think it may require evaluation from the UX team
Comment 2 Heiko Tietze 2023-01-09 12:21:33 UTC
Intentionally done for bug 79312. Imagine when you click Ignore or Correct and the dialog closes.
Comment 3 kitchm 2023-01-09 17:39:49 UTC
The so-called "fix" appears to be short-sighted.  The proposal assumes that a programmer cannot think of another way to do the job.

As one example, there are already flaws in the existing dialog box, such as a pop-up that asks if one wished to start at the beginning of the document.  When that closes, the focus of the dialog box is lost.  Oops.

No, the whole thing deserves a re-think and re-program.  The basic assumption is that the buttons all work the same.  That is incorrect.

I was selecting the Spelling Check button; not a Grammar Check button.  These are two separate and distinct functions.

I could go on, but there is no point.  If the idea of separate functions is not understood, then the whole issue cannot be corrected.
Comment 4 Heiko Tietze 2023-01-10 08:13:00 UTC
No question that this dialog offers plenty of room for improvements. But requesting to automatically close when done would be a mistake in most scenarios. And was rejected therefore in the past.
Comment 5 kitchm 2023-01-12 23:23:43 UTC
As I already pointed out, that is just short-sighted, and actually sort of sad.  After starting a project, to just stop improving it is a waste and indicates it should never have been started in the first place.