Created attachment 184268 [details] Screenhot showing the problem (dark theme) When editing a dialog in Basic IDE controls such as labels, radio buttons and checkboxes get an incorrect background color. In dark themes the background is painted black whereas in light themes the background is white. It should use the same color applied to the window. See attached image for more details Tested with Version: 7.4.2.3 / LibreOffice Community Build ID: 40(Build:3) CPU threads: 16; OS: Linux 5.19; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Ubuntu package version: 1:7.4.2~rc3-0ubuntu1 Calc: threaded
The fix is quite simple and is available for review at https://gerrit.libreoffice.org/c/core/+/144363
Created attachment 184270 [details] Screenshot for GNOME light theme I can confirm the difference in colour in dark theme, but I also see a difference in colour in light theme (see attachment). Does a difference actually help knowing where elements are located? Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: ad387d5b984c6666906505d25685065f710ed55d CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded
(In reply to Stéphane Guillou (stragu) from comment #2) > Does a difference actually help knowing where elements are located? I don't think this was the reason for the difference in color. It always felt like a bug to me. If the user wants to know the boundaries of the control, clicking it will show the resize handle that give the area covered by the control. For comparison, in MS VBA dialog editor the background color of controls is the same as the dialog color.
Thanks Rafael. Apologies, I somehow missed that you had tested a light theme as well, and that the issue is not just about dark themes. Sounds sensible to me! Also in: Version: 6.2.0.0.beta1 Build ID: d1b41307be3f8c19fe6f1938cf056e7ff1eb1d18 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3; Locale: en-AU (en_AU.UTF-8); UI-Language: en-US Calc: threaded
Buttons look terrible in edit mode but are appealing when the macro runs. I can follow Stéphane's "concerns" (rather question) to have a special background in edit mode. Nevertheless the patch works well and you decide.
Rafael Lima committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3c70cfc93bf196503a59188ac0d7b93f8c1fe4af tdf#152617 Fix color of controls in the Dialog Editor It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rafael Lima committed a patch related to this issue. It has been pushed to "libreoffice-7-5": https://git.libreoffice.org/core/commit/29c2a583c6e82a9281794b147db94c945d398cac tdf#152617 Fix color of controls in the Dialog Editor It will be available in 7.5.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.